0053480: core2 build generateApp step fails with NullPointerException (using merged+pos-modules as input set of modules)

Description

the core2 specific build step we have as part of pos2 build

ant -f modules/org.openbravo.core2/build.xml build

fails with a NullPointerException for a set of modules where "and check.module.consistency" shows no issues.

Error is observed with set of modules when combining current merged.json + pos2-modules
See branch with concrete reproducer json in steps to reproduce

Exception details are:
[generateApp] 10862 [main] INFO org.openbravo.core2.build.AppGenerator - Generating POS2 application...

BUILD FAILED
<workspace>/modules/org.openbravo.core2/build.xml:62: java.lang.NullPointerException
        at org.openbravo.dal.core.SessionHandler.createSession(SessionHandler.java:230)
        at org.openbravo.dal.core.SessionHandler.begin(SessionHandler.java:576)
        at org.openbravo.dal.core.SessionHandler.getSession(SessionHandler.java:183)
        at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:535)
        at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:501)
        at org.openbravo.dal.core.SessionHandler.find(SessionHandler.java:481)
        at org.openbravo.dal.core.OBContext.initialize(OBContext.java:838)
        at org.openbravo.dal.core.OBContext.setOBContext(OBContext.java:530)
        at org.openbravo.dal.core.OBContext.setOBContext(OBContext.java:486)
        at org.openbravo.dal.core.OBContext.setAdminContextLocally(OBContext.java:186)
        at org.openbravo.dal.core.OBContext.setAdminMode(OBContext.java:218)
        at org.openbravo.dal.core.OBContext.setAdminMode(OBContext.java:240)
        at org.openbravo.client.kernel.KernelUtils.getModulesOrderedByDependency(KernelUtils.java:257)
        at org.openbravo.client.kernel.KernelUtils.getModule(KernelUtils.java:221)
        at org.openbravo.retail.verystar.OBVERComponentProvider.getGlobalComponentResources(OBVERComponentProvider.java:53)
        at org.openbravo.core2.build.BusinessLogicBundler.lambda$generatebaseBusinessLogicBundle$0(BusinessLogicBundler.java:63)
        at java.base/java.util.stream.ReferencePipeline$7$1.accept(ReferencePipeline.java:271)
        at java.base/java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1655)
        at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484)
        at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474)
        at java.base/java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913)
        at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.base/java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:578)
        at org.openbravo.core2.build.BusinessLogicBundler.generatebaseBusinessLogicBundle(BusinessLogicBundler.java:68)
        at org.openbravo.core2.build.AppGenerator.execute(AppGenerator.java:48)

Steps To Reproduce

Set of modules available in this file:
https://gitlab.com/openbravo/devel/ci/context_definitions/-/blob/fr/shutest3a/merged/merged.json?ref_type=heads [^]

ant install.source
npm ci --omit=dev
ant -f modules/org.openbravo.core2/build.xml build

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0154968) hgbot (developer) 2023-09-19 08:41	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.verystar/-/merge_requests/5 [^]

(0154970) hgbot (developer) 2023-09-19 09:22	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.verystar/-/merge_requests/5 [^]

(0154971) hgbot (developer) 2023-09-19 09:22	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.verystar [^] Changeset: 25da9e5869294c9623edb21e5c1fef2bad814c3c Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 19-09-2023 08:34:23 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.verystar/-/commit/25da9e5869294c9623edb21e5c1fef2bad814c3c [^] fixes BUG-53480: core2 build fails Building pos2 with verystar module installed thrown a NPE performing core2's generate.app step. It was caused by verystar's component provider trying to use DAL in an stage that is not available. --- M src/org/openbravo/retail/verystar/OBVERComponentProvider.java ---

Issue History
Date Modified	Username	Field	Change
2023-09-18 19:58	shuehner	New Issue
2023-09-18 19:58	shuehner	Assigned To	=> Triage Platform Base
2023-09-18 19:58	shuehner	Triggers an Emergency Pack	=> No
2023-09-18 19:59	shuehner	Description Updated	View Revisions
2023-09-18 20:04	shuehner	Summary	core2 build steps fails with NullPointerException (using merged+pos-modules as input set of modules) => core2 build generateApp step fails with NullPointerException (using merged+pos-modules as input set of modules)
2023-09-19 08:41	hgbot	Note Added: 0154968
2023-09-19 08:41	alostale	Assigned To	Triage Platform Base => alostale
2023-09-19 09:22	hgbot	Resolution	open => fixed
2023-09-19 09:22	hgbot	Status	new => closed
2023-09-19 09:22	hgbot	Note Added: 0154970
2023-09-19 09:22	hgbot	Note Added: 0154971