Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0053203
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminoralways2023-08-11 09:222023-09-06 11:00
Reporteragusti_gallegoView Statuspublic 
Assigned Toagusti_gallego 
PrioritynormalResolutionfixedFixed in VersionPR23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0053203: [Stock take] [Total] Absent EAN in excel file during import does not provide a clear error message

DescriptionWhen the EAN is not informed, the following error is displayed. It is not clear.

https://openbravo.atlassian.net/browse/RM-7630 [^]

Additional Info: The error shown in the screenshot is the result of using a generic product, and not due to a lack of EAN.
Steps To Reproduce1. Go to the back office.
2. Create a Physical Inventory Count with the option Total selected.
3. Export the data as a CSV.
4. Add a generic product to the CSV.
5. Import the data. The banner with the error appears.
Proposed SolutionInclude the more detailed error information in the result file downloaded after the importing process.
TagsNo tags attached.
Attached Filespng file icon 7630rm.png [^] (111,279 bytes) 2023-08-11 09:22

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0153449)
hgbot (developer)
2023-08-11 09:40

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/969 [^]
(0153637)
hgbot (developer)
2023-08-17 23:32

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/969 [^]
(0153638)
hgbot (developer)
2023-08-17 23:32

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 0daf1a4f46b851d33829dfbc146048cab076e8d8
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 17-08-2023 21:32:14
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0daf1a4f46b851d33829dfbc146048cab076e8d8 [^]

Fixed ISSUE-53203: Improved the messages for errors when importing stock data. Changed transaction logic to avoid having a rollback when failing in a line.

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportInventoryLines.java
---
(0154399)
hgbot (developer)
2023-09-04 11:59

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/985 [^]
(0154404)
agusti_gallego (viewer)
2023-09-04 12:49

 Test plan:

To properly test that the fix works, we need to first replicate the issue. To replicate the issue, use the master branch and do as follows:

1. Before starting the server, execute the following SQL statement in the DB: update m_product set upc='' where isgeneric = 'Y';
2. Start the server, log in to BO and switch to AWO-QA, US organization, US West Coast warehouse.
3. In Product, create a new Product with the Search Key TEST_PRODUCT (the name can be whatever).
4. In Physical Inventory, create a new Total inventory count. Export the Data as CSV and add the following line just after the header: ,TEST_PRODUCT,,0,,Unit,RCT202,,
5. Import the modified file. The process should fail with 0 lines correctly imported and 1 with error. The error should mention a product completely different from TEST_PRODUCT (Chinesse plum in some cases).

To check that this issue is fixed:

1. Checkout the fix/53203 branch in devel remote. Make sure to build the changes.
2. Start the server, log in to BO and switch to AWO-QA, US organization, US West Coast warehouse.
3. Go to Physical Inventory, select the count created above and re-import the file. The process should now finish correctly with all lines imported and 0 errors.
(0154535)
hgbot (developer)
2023-09-06 11:00

 Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: e3199d89e4c532a437aa77a2ccdd80ca0cb8d0f9
Author: Agustí Gállego <agusti.gallego@openbravo.com>
Date: 06-09-2023 08:58:06
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/e3199d89e4c532a437aa77a2ccdd80ca0cb8d0f9 [^]

Related to ISSUE-53203: Fixed generic product bug that appeared in some environments

---
M modules/org.openbravo.client.application/src/org/openbravo/client/application/businesslogic/ImportInventoryLines.java
---
(0154536)
hgbot (developer)
2023-09-06 11:00

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/985 [^]

- Issue History
Date Modified Username Field Change
2023-08-11 09:22 agusti_gallego New Issue
2023-08-11 09:22 agusti_gallego Assigned To => agusti_gallego
2023-08-11 09:22 agusti_gallego File Added: 7630rm.png
2023-08-11 09:22 agusti_gallego OBNetwork customer => No
2023-08-11 09:22 agusti_gallego Modules => Core
2023-08-11 09:22 agusti_gallego Triggers an Emergency Pack => No
2023-08-11 09:40 hgbot Merge Request Status => open
2023-08-11 09:40 hgbot Note Added: 0153449
2023-08-17 23:25 hgbot Merge Request Status open => approved
2023-08-17 23:32 hgbot Resolution open => fixed
2023-08-17 23:32 hgbot Status new => closed
2023-08-17 23:32 hgbot Note Added: 0153637
2023-08-17 23:32 hgbot Fixed in Version => PR23Q4
2023-08-17 23:32 hgbot Note Added: 0153638
2023-09-04 11:59 hgbot Note Added: 0154399
2023-09-04 12:49 agusti_gallego Note Added: 0154404
2023-09-06 11:00 hgbot Note Added: 0154535
2023-09-06 11:00 hgbot Note Added: 0154536

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker