Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053176 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] Core | minor | have not tried | 2023-08-07 15:59 | 2023-08-22 13:35 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053176: Support themeMode as a Setting | |||||||
| Description | The themeMode (light/dark) is going to be managed as a setting. This requires some changes in org.openbravo.core2: - We need to create a new component for SettingItems that instead of containing a checkbox, renders multiple buttons, allowing the user to select one of them (see attached image). This can be done by creating a wrapper over [2] BaseButtonGroup - We need to update ThemeProvider [1] so that it retrieves the theme mode from the Setting model, instead of from the session context - We will create a Setting.setSettingValue action that will be convenient to manage settings that are not booleans [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/ThemeProvider/ThemeProvider.jsx#L22 [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/web-jspack/org.openbravo.core2/src/components/BaseButtonGroup/BaseButtonGroup.jsx [^] | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  themeModeSetting.png [^] (52,788 bytes) 2023-08-08 14:04
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0153351) hgbot (developer) 2023-08-08 17:16 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1191 [^] |
|
(0153764) hgbot (developer) 2023-08-22 09:58 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/976 [^] |
|
(0153765) hgbot (developer) 2023-08-22 10:01 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1311 [^] |
|
(0153783) hgbot (developer) 2023-08-22 13:15 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1311 [^] |
|
(0153784) hgbot (developer) 2023-08-22 13:15 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: a8d05b2295cc814063a9c57d2da955d6fd62d828 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 22-08-2023 11:44:38 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/a8d05b2295cc814063a9c57d2da955d6fd62d828 [^] Related to ISSUE-53176: Adds include company logos for dark theme in terminal object --- M src/org/openbravo/retail/posterminal/term/Terminal.java --- |
|
(0153785) hgbot (developer) 2023-08-22 13:15 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: d7378fc047c4d18632285281c13fac3ea77fcaf0 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 22-08-2023 11:42:44 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d7378fc047c4d18632285281c13fac3ea77fcaf0 [^] Related to ISSUE-53176: Adds fields to define company logos for dark theme --- M src-db/database/sourcedata/AD_FIELD.xml M src/org/openbravo/erpCommon/utility/companylogo/CompanyLogoUtils.java --- |
|
(0153786) hgbot (developer) 2023-08-22 13:15 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/976 [^] |
|
(0153787) hgbot (developer) 2023-08-22 13:26 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 1dfdca59016d46b26f3da2a563f36f47bbf20d7f Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 22-08-2023 13:25:22 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1dfdca59016d46b26f3da2a563f36f47bbf20d7f [^] Fixes ISSUE-53176: Merges dark/light setting project --- A src-db/database/model/tables/OBPOS2_USER_TTYPE_CONFIG.xml A src/org/openbravo/pos2/importprocess/TerminalTypeUserConfigurationLoaderProcessor.java A src/org/openbravo/pos2/login/TerminalTypeUserPropertiesProvider.java A src/org/openbravo/pos2/process/TerminalTypeUserConfigurationLoader.java A web-jspack/org.openbravo.pos2/src/components/ThemeModeSetting/ThemeModeSetting.config.json A web-jspack/org.openbravo.pos2/src/model/setting/hooks/UpdateTerminalTypeUserConfiguration.js M src-db/database/model/modifiedTables/OBPOS_TERMINALTYPE.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_REFERENCE.xml M src-db/database/sourcedata/AD_REF_LIST.xml M src-db/database/sourcedata/AD_TAB.xml M src-db/database/sourcedata/AD_TABLE.xml M src-db/database/sourcedata/AD_VAL_RULE.xml M src-db/database/sourcedata/OBMOBC_SERVICES.xml M web-jspack/org.openbravo.pos2/src/authentication/loginInitActions.js M web-jspack/org.openbravo.pos2/src/model/setting/SettingExtension.js --- |
|
(0153789) hgbot (developer) 2023-08-22 13:35 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: fa9ee1fc6a2a6c73c2541e891063fc66dc8d4d65 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 22-08-2023 13:34:18 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/fa9ee1fc6a2a6c73c2541e891063fc66dc8d4d65 [^] Fixes ISSUE-53176: Adds component to support ButtonGroup settings, improves management of dark/light mode --- A web-jspack/org.openbravo.core2/src/assets/icons/dark.svg A web-jspack/org.openbravo.core2/src/assets/icons/light-dark-mode.svg A web-jspack/org.openbravo.core2/src/assets/icons/light.svg A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/SettingButtonGroupItem.jsx A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/SettingButtonGroupItem.scss A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/__test__/SettingButtonGroupItem.test.jsx A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/index.js A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/stories/SettingButtonGroupItem.stories.jsx A web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingButtonGroupItem/stories/SettingButtonGroupItem.stories.scss A web-jspack/org.openbravo.core2/src/model/setting/actions/SetSettingValue.js A web-jspack/org.openbravo.core2/src/model/setting/user-actions/SetSettingValue.js M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.core2/src/assets/style/iconography.scss M web-jspack/org.openbravo.core2/src/components/AppBar/__test__/AppBar.test.jsx M web-jspack/org.openbravo.core2/src/components/AppBar/stories/AppBar.stories.jsx M web-jspack/org.openbravo.core2/src/components/AutocompleteFormInput/AutocompleteFormInput.jsx M web-jspack/org.openbravo.core2/src/components/BaseButtonGroup/BaseButtonGroup.jsx M web-jspack/org.openbravo.core2/src/components/BaseButtonGroup/BaseButtonGroup.scss M web-jspack/org.openbravo.core2/src/components/BaseDialog/BaseDialog.jsx M web-jspack/org.openbravo.core2/src/components/BaseDialog/__test__/BaseDialog.test.jsx M web-jspack/org.openbravo.core2/src/components/BaseFormDatePicker/BaseFormDatePicker.jsx M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.jsx M web-jspack/org.openbravo.core2/src/components/BaseMenu/BaseMenu.jsx M web-jspack/org.openbravo.core2/src/components/BasePopover/BasePopover.jsx M web-jspack/org.openbravo.core2/src/components/BaseTooltip/BaseTooltip.jsx M web-jspack/org.openbravo.core2/src/components/ComboBox/ComboBox.jsx M web-jspack/org.openbravo.core2/src/components/CompanyLogo/CompanyLogo.jsx M web-jspack/org.openbravo.core2/src/components/CompanyLogo/__test__/CompanyLogo.test.jsx M web-jspack/org.openbravo.core2/src/components/CompanyLogo/stories/CompanyLogo.stories.jsx M web-jspack/org.openbravo.core2/src/components/ErrorFallback/ErrorFallback.jsx M web-jspack/org.openbravo.core2/src/components/ErrorFallback/__test__/ErrorFallback.test.jsx M web-jspack/org.openbravo.core2/src/components/ErrorFallback/stories/ErrorFallback.stories.jsx M web-jspack/org.openbravo.core2/src/components/ErrorScreen/ErrorScreen.jsx M web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingsContent.jsx M web-jspack/org.openbravo.core2/src/components/ThemeProvider/ThemeProvider.jsx M web-jspack/org.openbravo.core2/src/components/ThemeProvider/__test__/ThemeProvider.test.jsx M web-jspack/org.openbravo.core2/src/components/ThemeProvider/stories/ThemeProvider.stories.jsx M web-jspack/org.openbravo.core2/src/index.jsx M web-jspack/org.openbravo.core2/src/model/setting/Setting.js M web-jspack/org.openbravo.core2/src/ob-init.js --- |
|
(0153790) hgbot (developer) 2023-08-22 13:35 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1191 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-08-07 15:59 | AugustoMauch | New Issue | |
| 2023-08-07 15:59 | AugustoMauch | Assigned To | => AugustoMauch |
| 2023-08-07 15:59 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2023-08-08 09:28 | AugustoMauch | Status | new => scheduled |
| 2023-08-08 14:04 | AugustoMauch | Summary | Create ButtonGroupSettingItem => Support themeMode as a Setting |
| 2023-08-08 14:04 | AugustoMauch | Description Updated | View Revisions |
| 2023-08-08 14:04 | AugustoMauch | File Added: themeModeSetting.png | |
| 2023-08-08 14:07 | AugustoMauch | Description Updated | View Revisions |
| 2023-08-08 17:16 | hgbot | Note Added: 0153351 | |
| 2023-08-22 09:58 | hgbot | Note Added: 0153764 | |
| 2023-08-22 10:01 | hgbot | Note Added: 0153765 | |
| 2023-08-22 13:15 | hgbot | Note Added: 0153783 | |
| 2023-08-22 13:15 | hgbot | Note Added: 0153784 | |
| 2023-08-22 13:15 | hgbot | Note Added: 0153785 | |
| 2023-08-22 13:15 | hgbot | Note Added: 0153786 | |
| 2023-08-22 13:26 | hgbot | Resolution | open => fixed |
| 2023-08-22 13:26 | hgbot | Status | scheduled => closed |
| 2023-08-22 13:26 | hgbot | Fixed in Version | => 23Q4 |
| 2023-08-22 13:26 | hgbot | Note Added: 0153787 | |
| 2023-08-22 13:35 | hgbot | Note Added: 0153789 | |
| 2023-08-22 13:35 | hgbot | Note Added: 0153790 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |