Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0053162 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Discounts and Promotions | major | always | 2023-08-04 10:05 | 2023-09-01 06:19 | |||
Reporter | ngarcia | View Status | public | |||||
Assigned To | ranjith_qualiantech_com | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | RR23Q4 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0053162: Discounts stop being applied before finishing the ending date if the customer time converted to GMT gives the following day | |||||||
Description | Discounts stop being applied before finishing the ending date if the customer time converted to GMT gives the following day | |||||||
Steps To Reproduce | Set the computer time to GMT-1 and 23:00 Create a Price Adjustment with an ending date of today Log in into the POS and check the discount is not applied The following piece of code returns false if ( discountImpl.endingDate && new Date(discountImpl.endingDate.split('T')[0]) < currentDate ) { return false; } | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0153286) hgbot (developer) 2023-08-07 12:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2002 [^] |
(0153287) hgbot (developer) 2023-08-07 12:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1304 [^] |
(0153288) hgbot (developer) 2023-08-07 12:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/595 [^] |
(0153289) hgbot (developer) 2023-08-07 12:15 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/38 [^] |
(0153290) hgbot (developer) 2023-08-07 12:16 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/116 [^] |
(0153485) sofidossant (developer) 2023-08-14 13:05 |
Any news? |
(0154268) hgbot (developer) 2023-09-01 06:19 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 08f307e008627a691c4a7d74edabee5663db4e8f Author: Ranjith S R <ranjith@qualiantech.com> Date: 30-08-2023 07:03:17 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/08f307e008627a691c4a7d74edabee5663db4e8f [^] Related to ISSUE-53162: Added Date util function for getting date without time * Added Util function to get date without time. --- M web-test/util/I18N.test.js M web/org.openbravo.mobile.core/source/utils/ob-i18n.js --- |
(0154269) hgbot (developer) 2023-09-01 06:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/595 [^] |
(0154270) hgbot (developer) 2023-09-01 06:19 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: c4703f632b424100711334187f55f5bf1f5fb9fd Author: Ranjith S R <ranjith@qualiantech.com> Date: 31-08-2023 10:07:49 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c4703f632b424100711334187f55f5bf1f5fb9fd [^] Related to ISSUE-53162: Time should not be included in Discount Date validation --- M web-test/model/business-logic/pack/Pack.test.js M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/ProductPack.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
(0154271) hgbot (developer) 2023-09-01 06:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1304 [^] |
(0154272) hgbot (developer) 2023-09-01 06:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/38 [^] |
(0154273) hgbot (developer) 2023-09-01 06:19 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^] Changeset: 99ed588db06e778117a9a3189d4db882fc66487b Author: Ranjith S R <ranjith@qualiantech.com> Date: 30-08-2023 06:44:22 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/99ed588db06e778117a9a3189d4db882fc66487b [^] Related to ISSUE-53162: Time should not be included in Discount Date validation --- M web-test/model/business-logic/pack/Combo.test.js --- |
(0154274) hgbot (developer) 2023-09-01 06:19 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 202705a37f63b55947d847e9c5df6c4294f154aa Author: Ranjith S R <ranjith@qualiantech.com> Date: 01-09-2023 03:56:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/202705a37f63b55947d847e9c5df6c4294f154aa [^] Related to ISSUE-53162: Time should not be included in Discount Date validation --- M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/__test__/getGiftReminderNotificationList.test.js M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/getGiftReminderNotificationList.js M web-jspack/org.openbravo.pos2/src/core/discount/__test__/initDiscountsCache.test.js M web-jspack/org.openbravo.pos2/src/core/discount/initDiscountsCache.js --- |
(0154275) hgbot (developer) 2023-09-01 06:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2002 [^] |
(0154276) hgbot (developer) 2023-09-01 06:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/116 [^] |
(0154277) hgbot (developer) 2023-09-01 06:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 057b9ff9106f835e23473fe6fb776da934aa6029 Author: Ranjith S R <ranjith@qualiantech.com> Date: 30-08-2023 12:07:37 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/057b9ff9106f835e23473fe6fb776da934aa6029 [^] Fixed ISSUE-53162: Time should not be included in Discount Date validation --- M web-test/model/business-logic/discounts-engine/engine/discount-is-applicable.test.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js --- |
Issue History | |||
Date Modified | Username | Field | Change |
2023-08-04 10:05 | ngarcia | New Issue | |
2023-08-04 10:05 | ngarcia | Assigned To | => Retail |
2023-08-04 10:05 | ngarcia | Triggers an Emergency Pack | => No |
2023-08-04 10:59 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
2023-08-04 13:09 | Practics | Issue Monitored: Practics | |
2023-08-04 15:24 | ranjith_qualiantech_com | Status | new => scheduled |
2023-08-07 12:15 | hgbot | Note Added: 0153286 | |
2023-08-07 12:15 | hgbot | Note Added: 0153287 | |
2023-08-07 12:15 | hgbot | Note Added: 0153288 | |
2023-08-07 12:15 | hgbot | Note Added: 0153289 | |
2023-08-07 12:16 | hgbot | Note Added: 0153290 | |
2023-08-14 13:05 | sofidossant | Note Added: 0153485 | |
2023-09-01 06:19 | hgbot | Note Added: 0154268 | |
2023-09-01 06:19 | hgbot | Note Added: 0154269 | |
2023-09-01 06:19 | hgbot | Note Added: 0154270 | |
2023-09-01 06:19 | hgbot | Note Added: 0154271 | |
2023-09-01 06:19 | hgbot | Note Added: 0154272 | |
2023-09-01 06:19 | hgbot | Note Added: 0154273 | |
2023-09-01 06:19 | hgbot | Note Added: 0154274 | |
2023-09-01 06:19 | hgbot | Note Added: 0154275 | |
2023-09-01 06:19 | hgbot | Resolution | open => fixed |
2023-09-01 06:19 | hgbot | Status | scheduled => closed |
2023-09-01 06:19 | hgbot | Note Added: 0154276 | |
2023-09-01 06:19 | hgbot | Fixed in Version | => RR23Q4 |
2023-09-01 06:19 | hgbot | Note Added: 0154277 |
Copyright © 2000 - 2009 MantisBT Group |