Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0053162Retail ModulesDiscounts and Promotionspublic2023-08-04 10:052023-09-01 06:19
Reporterngarcia 
Assigned Toranjith_qualiantech_com 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR23Q4 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0053162: Discounts stop being applied before finishing the ending date if the customer time converted to GMT gives the following day
DescriptionDiscounts stop being applied before finishing the ending date if the customer time converted to GMT gives the following day
Steps To ReproduceSet the computer time to GMT-1 and 23:00

Create a Price Adjustment with an ending date of today

Log in into the POS and check the discount is not applied

The following piece of code returns false

    if (
      discountImpl.endingDate &&
      new Date(discountImpl.endingDate.split('T')[0]) < currentDate
    ) {
      return false;
    }
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2023-08-04 10:05ngarciaNew Issue
2023-08-04 10:05ngarciaAssigned To => Retail
2023-08-04 10:05ngarciaTriggers an Emergency Pack => No
2023-08-04 10:59ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2023-08-04 13:09PracticsIssue Monitored: Practics
2023-08-04 15:24ranjith_qualiantech_comStatusnew => scheduled
2023-08-07 12:15hgbotNote Added: 0153286
2023-08-07 12:15hgbotNote Added: 0153287
2023-08-07 12:15hgbotNote Added: 0153288
2023-08-07 12:15hgbotNote Added: 0153289
2023-08-07 12:16hgbotNote Added: 0153290
2023-08-14 13:05sofidossantNote Added: 0153485
2023-09-01 06:19hgbotNote Added: 0154268
2023-09-01 06:19hgbotNote Added: 0154269
2023-09-01 06:19hgbotNote Added: 0154270
2023-09-01 06:19hgbotNote Added: 0154271
2023-09-01 06:19hgbotNote Added: 0154272
2023-09-01 06:19hgbotNote Added: 0154273
2023-09-01 06:19hgbotNote Added: 0154274
2023-09-01 06:19hgbotNote Added: 0154275
2023-09-01 06:19hgbotResolutionopen => fixed
2023-09-01 06:19hgbotStatusscheduled => closed
2023-09-01 06:19hgbotNote Added: 0154276
2023-09-01 06:19hgbotFixed in Version => RR23Q4
2023-09-01 06:19hgbotNote Added: 0154277

Notes
(0153286)
hgbot   
2023-08-07 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2002 [^]
(0153287)
hgbot   
2023-08-07 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1304 [^]
(0153288)
hgbot   
2023-08-07 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/595 [^]
(0153289)
hgbot   
2023-08-07 12:15   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/38 [^]
(0153290)
hgbot   
2023-08-07 12:16   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/116 [^]
(0153485)
sofidossant   
2023-08-14 13:05   
Any news?
(0154268)
hgbot   
2023-09-01 06:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 08f307e008627a691c4a7d74edabee5663db4e8f
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 30-08-2023 07:03:17
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/08f307e008627a691c4a7d74edabee5663db4e8f [^]

Related to ISSUE-53162: Added Date util function for getting date without time
* Added Util function to get date without time.

---
M web-test/util/I18N.test.js
M web/org.openbravo.mobile.core/source/utils/ob-i18n.js
---
(0154269)
hgbot   
2023-09-01 06:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/595 [^]
(0154270)
hgbot   
2023-09-01 06:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: c4703f632b424100711334187f55f5bf1f5fb9fd
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 31-08-2023 10:07:49
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c4703f632b424100711334187f55f5bf1f5fb9fd [^]

Related to ISSUE-53162: Time should not be included in Discount Date validation

---
M web-test/model/business-logic/pack/Pack.test.js
M web/org.openbravo.retail.posterminal/app/model/business-logic/pack/ProductPack.js
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0154271)
hgbot   
2023-09-01 06:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1304 [^]
(0154272)
hgbot   
2023-09-01 06:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/merge_requests/38 [^]
(0154273)
hgbot   
2023-09-01 06:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo [^]
Changeset: 99ed588db06e778117a9a3189d4db882fc66487b
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 30-08-2023 06:44:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.combo/-/commit/99ed588db06e778117a9a3189d4db882fc66487b [^]

Related to ISSUE-53162: Time should not be included in Discount Date validation

---
M web-test/model/business-logic/pack/Combo.test.js
---
(0154274)
hgbot   
2023-09-01 06:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 202705a37f63b55947d847e9c5df6c4294f154aa
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 01-09-2023 03:56:44
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/202705a37f63b55947d847e9c5df6c4294f154aa [^]

Related to ISSUE-53162: Time should not be included in Discount Date validation

---
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/__test__/getGiftReminderNotificationList.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/GiftReminderNotification/getGiftReminderNotificationList.js
M web-jspack/org.openbravo.pos2/src/core/discount/__test__/initDiscountsCache.test.js
M web-jspack/org.openbravo.pos2/src/core/discount/initDiscountsCache.js
---
(0154275)
hgbot   
2023-09-01 06:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2002 [^]
(0154276)
hgbot   
2023-09-01 06:19   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/116 [^]
(0154277)
hgbot   
2023-09-01 06:19   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 057b9ff9106f835e23473fe6fb776da934aa6029
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 30-08-2023 12:07:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/057b9ff9106f835e23473fe6fb776da934aa6029 [^]

Fixed ISSUE-53162: Time should not be included in Discount Date validation

---
M web-test/model/business-logic/discounts-engine/engine/discount-is-applicable.test.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/interface/discount-posinterface.js
---