Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0053098 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [POS2] POS | major | have not tried | 2023-07-28 12:10 | 2023-09-08 13:18 | |||
| Reporter | justin_patterson | View Status | public | |||||
| Assigned To | Retail | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0053098: Minimum amount is configurable with Credit Sales | |||||||
| Description | Includes the ability to define a minimum amount to be paid on credit. | |||||||
| Steps To Reproduce | . | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||
|
|||||||||
 Relationships |
|
Notes |
|
|
(0154114) hgbot (developer) 2023-08-29 11:50 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/983 [^] |
|
(0154115) hgbot (developer) 2023-08-29 11:51 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2048 [^] |
|
(0154131) hgbot (developer) 2023-08-29 13:37 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/598 [^] |
|
(0154419) hgbot (developer) 2023-09-04 15:10 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/187 [^] |
|
(0154420) hgbot (developer) 2023-09-04 15:11 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1327 [^] |
|
(0154438) hgbot (developer) 2023-09-05 09:21 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/52 [^] |
|
(0154594) hgbot (developer) 2023-09-07 15:52 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/72 [^] |
|
(0154607) hgbot (developer) 2023-09-08 09:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 96809bd10cb1f6ebd1e913366ddfd7f761afc182 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 07-09-2023 16:09:45 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/96809bd10cb1f6ebd1e913366ddfd7f761afc182 [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 -Added definition for new column on c_bpartner, so_creditminamt -Added ref list entry for transaction minumim amount for CRM Semantic Property list -Added field to display Transaction minimum amount in Customer tab of Business Partner window --- M src-db/database/model/tables/C_BPARTNER.xml M src-db/database/sourcedata/AD_COLUMN.xml M src-db/database/sourcedata/AD_ELEMENT.xml M src-db/database/sourcedata/AD_FIELD.xml M src-db/database/sourcedata/AD_REF_LIST.xml --- |
|
(0154608) hgbot (developer) 2023-09-08 09:18 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/983 [^] |
|
(0154609) hgbot (developer) 2023-09-08 09:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.api [^] Changeset: 0d21f90bbda15cc6d019d00db6132a1a20525d3d Author: Justin Patterson <justin.patterson@openbravo.com> Date: 07-09-2023 16:10:41 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/commit/0d21f90bbda15cc6d019d00db6132a1a20525d3d [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 -Added new Entity Mapping for property creditminamt which maps to transactionMinimumAmt for Credit Sales --- M src-db/database/sourcedata/OBEI_PROP_MAP_INSTANCE.xml --- |
|
(0154610) hgbot (developer) 2023-09-08 09:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.api/-/merge_requests/187 [^] |
|
(0154611) hgbot (developer) 2023-09-08 09:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: c5fbd4bbbc596f2d0addb0acc8c3d8766f4b975a Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 09:11:56 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/c5fbd4bbbc596f2d0addb0acc8c3d8766f4b975a [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 -In class ExternalBusinessPartner: -Added getCreditLimitProperty(), getCreditLimit(), getCreditUsedProperty(), getCreditUsed() methods, which get respective properties from a mixedBP object --- M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js --- |
|
(0154612) hgbot (developer) 2023-09-08 09:20 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 9d4e31988db35942de727a9f49a8abadb2771b21 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 09:20:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9d4e31988db35942de727a9f49a8abadb2771b21 [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 -In PaymentPanelButtons.jsx: -Added logic to find the current BP's getTransactionMinimumAmount and passed as prop to CreditButton component -In CreditButton.jsx: -Added new variable, approvalNeeded, which compares pending transaction amount with the transaction minimum amount to find if a credit sale will require approval -Used new variable to change the labels and content of the confirmation dialog that shows when the Credit Button is clicked based on whether approval is needed -Now if approval is needed the approvalNeeded object will be passed to the SellOnCredit user action and activate the approval flow -Added new field, TransactionMinimumField, to the confirmation dialog that shows if there is a transaction Minimum Amount -Added logic to SellOnCredit.js user action which activates the approvals flow if the threshold approvalNeeded:true is met -Added AD_MESSAGE entries for minimum credit flow -Exported CRM dataset for new minimum credit field -Adjusted CSS to emphasize new fields in Credit Sales confirmation popup -Added Jest test -Added Cypress tests --- A web-jspack/org.openbravo.pos2/src-test/cypress/e2e/Features/creditSales.spec.js A web-jspack/org.openbravo.pos2/src-test/cypress/fixtures/e2eFixtures/CreditSales.json A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/TransactionMinimumField/TransactionMinimumField.jsx A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/TransactionMinimumField/TransactionMinimumField.scss A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/TransactionMinimumField/index.js A web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/__test__/CreditButton.test.jsx M referencedata/standard/CRM_Connector_for_Openbravo_Customers.xml M src-db/database/sourcedata/AD_DATASET.xml M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButton.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/AmountField/AmountField.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/AmountField/AmountField.scss M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/CreditButtonConfirmationDialogContent.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/PaymentTypeField/PaymentTypeField.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/CreditButton/CreditButtonConfirmationDialogContent/PaymentTypeField/PaymentTypeField.scss M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/PaymentPanelButtons.jsx M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanelButtons/__test__/PaymentPanelButtons.test.jsx M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/SellOnCredit.js --- |
|
(0154613) hgbot (developer) 2023-09-08 09:22 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata [^] Changeset: e16cd4df3689bbe4626d497382afb76238bc5d1e Author: Justin Patterson <justin.patterson@openbravo.com> Date: 05-09-2023 09:11:29 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/commit/e16cd4df3689bbe4626d497382afb76238bc5d1e [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 --- M referencedata/sampledata/The_White_Valley_Group/C_EXTBP_CONFIG_PROPERTY.xml --- |
|
(0154614) hgbot (developer) 2023-09-08 09:22 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.sampledata/-/merge_requests/52 [^] |
|
(0154615) hgbot (developer) 2023-09-08 09:22 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: c58f8be202608193a29843d3c3ae65cef0395751 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 09:22:33 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/c58f8be202608193a29843d3c3ae65cef0395751 [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 -Exposed new BusinessPartner property: transactionMinAmt --- M src/org/openbravo/retail/posterminal/master/BusinessPartnerProperties.java --- |
|
(0154616) hgbot (developer) 2023-09-08 09:23 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata [^] Changeset: 206e78f791aa948467cc1476619810b8ea5eae1b Author: Justin Patterson <justin.patterson@openbravo.com> Date: 07-09-2023 16:04:06 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/commit/206e78f791aa948467cc1476619810b8ea5eae1b [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 --- M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER.xml --- |
|
(0154617) hgbot (developer) 2023-09-08 09:23 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.sampledata/-/merge_requests/72 [^] |
|
(0154618) hgbot (developer) 2023-09-08 09:28 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/598 [^] |
|
(0154619) hgbot (developer) 2023-09-08 09:28 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/2048 [^] |
|
(0154620) hgbot (developer) 2023-09-08 09:29 |
Merge request closed: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1327 [^] |
|
(0154623) hgbot (developer) 2023-09-08 09:49 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: e64f2276d43923b43dfd4b4a2def7edc8aa6ac0b Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 09:47:56 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/e64f2276d43923b43dfd4b4a2def7edc8aa6ac0b [^] Related to FR-53098: Minimum amount is configurable with Credit Sales -Refactored new getters for CRM properties so they don't fail on undefined property values --- M web/org.openbravo.mobile.core/app/integration/external-business-partner/ExternalBusinessPartner.js --- |
|
(0154635) hgbot (developer) 2023-09-08 13:15 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata [^] Changeset: 1885af6ba5f9faa28abf92e33905d1ada651247a Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 13:14:38 URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.test.mobile.sampledata/-/commit/1885af6ba5f9faa28abf92e33905d1ada651247a [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 --- M referencedata/sampledata/The_White_Valley_Group/C_BPARTNER.xml --- |
|
(0154637) hgbot (developer) 2023-09-08 13:18 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata [^] Changeset: 747361a25d7792684616b23db649197571496fb4 Author: Justin Patterson <justin.patterson@openbravo.com> Date: 08-09-2023 13:17:28 URL: https://gitlab.com/openbravo/ci/modules/org.openbravo.retail.testsampledata/-/commit/747361a25d7792684616b23db649197571496fb4 [^] Fixes FR-53098: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 --- M referencedata/sampledata/Retail_Test/C_BPARTNER.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-07-28 12:10 | justin_patterson | New Issue | |
| 2023-07-28 12:10 | justin_patterson | Assigned To | => Retail |
| 2023-07-28 12:10 | justin_patterson | Triggers an Emergency Pack | => No |
| 2023-08-29 11:50 | hgbot | Note Added: 0154114 | |
| 2023-08-29 11:51 | hgbot | Note Added: 0154115 | |
| 2023-08-29 13:37 | hgbot | Note Added: 0154131 | |
| 2023-09-04 14:26 | marvintm | Description Updated | View Revisions |
| 2023-09-04 14:26 | marvintm | Summary | RM-6907: Migrate the Credit Sales functionality to WebPOS REACT - Phase 2 => Minimum amount is configurable with Credit Sales |
| 2023-09-04 14:26 | marvintm | Description Updated | View Revisions |
| 2023-09-04 15:10 | hgbot | Note Added: 0154419 | |
| 2023-09-04 15:11 | hgbot | Note Added: 0154420 | |
| 2023-09-05 09:21 | hgbot | Note Added: 0154438 | |
| 2023-09-07 15:52 | hgbot | Note Added: 0154594 | |
| 2023-09-08 09:18 | hgbot | Resolution | open => fixed |
| 2023-09-08 09:18 | hgbot | Status | new => closed |
| 2023-09-08 09:18 | hgbot | Fixed in Version | => PR23Q4 |
| 2023-09-08 09:18 | hgbot | Note Added: 0154607 | |
| 2023-09-08 09:18 | hgbot | Note Added: 0154608 | |
| 2023-09-08 09:19 | hgbot | Note Added: 0154609 | |
| 2023-09-08 09:19 | hgbot | Note Added: 0154610 | |
| 2023-09-08 09:19 | hgbot | Fixed in Version | PR23Q4 => RR23Q4 |
| 2023-09-08 09:19 | hgbot | Note Added: 0154611 | |
| 2023-09-08 09:20 | hgbot | Fixed in Version | RR23Q4 => 23Q4 |
| 2023-09-08 09:20 | hgbot | Note Added: 0154612 | |
| 2023-09-08 09:22 | hgbot | Note Added: 0154613 | |
| 2023-09-08 09:22 | hgbot | Note Added: 0154614 | |
| 2023-09-08 09:22 | hgbot | Fixed in Version | 23Q4 => RR23Q4 |
| 2023-09-08 09:22 | hgbot | Note Added: 0154615 | |
| 2023-09-08 09:23 | hgbot | Note Added: 0154616 | |
| 2023-09-08 09:23 | hgbot | Note Added: 0154617 | |
| 2023-09-08 09:28 | hgbot | Note Added: 0154618 | |
| 2023-09-08 09:28 | hgbot | Note Added: 0154619 | |
| 2023-09-08 09:29 | hgbot | Note Added: 0154620 | |
| 2023-09-08 09:49 | hgbot | Note Added: 0154623 | |
| 2023-09-08 13:15 | hgbot | Note Added: 0154635 | |
| 2023-09-08 13:18 | hgbot | Note Added: 0154637 | |
| 2023-09-12 07:38 | alostale | Relationship added | causes 0053435 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |