Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0052885 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Core | major | have not tried | 2023-06-26 16:55 | 2023-06-29 09:35 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 23Q1.4 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0052885: e.permissions is not iterable error when trying to log in | |||||||
| Description | Under some circumstances, not clear yet, a "e.permissions is not iterable" error is displayed when trying to log in. The problem seems to be caused by the application not being consistent when checking if a user has already logged in. Here [1] it checks if the session is active by checking if the logged user is not System, while here [2] it does it by checking if the user has a valid session. There are time where [2] evalues to true by [1] evaluates to false, resulting in the "e.permissions is not iterable" error. To address the problem we will make sure the same condition (a combination of [1] and [2]) is checked in both places. [1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/src/org/openbravo/core2/login/Core2LoginUtilsServlet.java#L61 [^] [2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java#L88 [^] | |||||||
| Steps To Reproduce | No steps to reproduce where found. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0151798) hgbot (developer) 2023-06-29 09:33 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1158 [^] |
|
(0151799) hgbot (developer) 2023-06-29 09:35 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/559 [^] |
|
(0151800) hgbot (developer) 2023-06-29 09:35 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1158 [^] |
|
(0151801) hgbot (developer) 2023-06-29 09:35 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: a447006f42b7263c52814b5f210003922a25fbc2 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 29-06-2023 09:33:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/a447006f42b7263c52814b5f210003922a25fbc2 [^] Fixes ISSUE-52885: Be consistent when checking if the user is authenticated Now both in MobileCoreLoginUtilsServlet and in Core2LoginUtilsServlet, the same condition will be check to determine if the current user is authenticated. The isSessionActive has been moved from the latter to the former --- M src/org/openbravo/core2/login/Core2LoginUtilsServlet.java --- |
|
(0151802) hgbot (developer) 2023-06-29 09:35 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: b4f74fcc8c0c10bb762b58ddecb6ec68e904bf84 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 29-06-2023 09:34:36 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/b4f74fcc8c0c10bb762b58ddecb6ec68e904bf84 [^] Fixes ISSUE-52885: Be consistent when checking if the user is authenticatedd Now both in MobileCoreLoginUtilsServlet and in Core2LoginUtilsServlet, the same condition will be check to determine if the current user is authenticated. The isSessionActive has been moved from the latter to the former --- M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java --- |
|
(0151803) hgbot (developer) 2023-06-29 09:35 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/559 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-06-29 09:31 | AugustoMauch | Type | defect => backport |
| 2023-06-29 09:31 | AugustoMauch | Target Version | => 23Q1.4 |
| 2023-06-29 09:33 | hgbot | Note Added: 0151798 | |
| 2023-06-29 09:35 | hgbot | Note Added: 0151799 | |
| 2023-06-29 09:35 | hgbot | Resolution | open => fixed |
| 2023-06-29 09:35 | hgbot | Status | scheduled => closed |
| 2023-06-29 09:35 | hgbot | Note Added: 0151800 | |
| 2023-06-29 09:35 | hgbot | Fixed in Version | => 23Q1.4 |
| 2023-06-29 09:35 | hgbot | Note Added: 0151801 | |
| 2023-06-29 09:35 | hgbot | Fixed in Version | 23Q1.4 => RR23Q1.4 |
| 2023-06-29 09:35 | hgbot | Note Added: 0151802 | |
| 2023-06-29 09:35 | hgbot | Note Added: 0151803 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |