Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052852
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajorhave not tried2023-06-26 16:552023-06-29 09:31
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052852: e.permissions is not iterable error when trying to log in

DescriptionUnder some circumstances, not clear yet, a "e.permissions is not iterable" error is displayed when trying to log in.

The problem seems to be caused by the application not being consistent when checking if a user has already logged in. Here [1] it checks if the session is active by checking if the logged user is not System, while here [2] it does it by checking if the user has a valid session. There are time where [2] evalues to true by [1] evaluates to false, resulting in the "e.permissions is not iterable" error.

To address the problem we will make sure the same condition (a combination of [1] and [2]) is checked in both places.

[1] https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/blob/master/src/org/openbravo/core2/login/Core2LoginUtilsServlet.java#L61 [^]
[2] https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/blob/master/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java#L88 [^]
Steps To ReproduceNo steps to reproduce where found.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 005288323Q3 closedAugustoMauch e.permissions is not iterable error when trying to log in 
depends on backport 005288423Q2.2 closedAugustoMauch e.permissions is not iterable error when trying to log in 
depends on backport 005288523Q1.4 closedAugustoMauch e.permissions is not iterable error when trying to log in 

-  Notes
(0151655)
hgbot (developer)
2023-06-26 16:57

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1156 [^]
(0151656)
hgbot (developer)
2023-06-26 16:57

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/558 [^]
(0151793)
hgbot (developer)
2023-06-29 09:17

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1156 [^]
(0151794)
hgbot (developer)
2023-06-29 09:17

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 49b566908ef0588cd2defe909aa7540ba79853ba
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 29-06-2023 07:14:05
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/49b566908ef0588cd2defe909aa7540ba79853ba [^]

Fixes ISSUE-52852: Be consistent when checking if the user is authenticated

Now both in MobileCoreLoginUtilsServlet and in Core2LoginUtilsServlet, the same condition will be check to
determine if the current user is authenticated. The isSessionActive has been moved from the latter to the
former

---
M src/org/openbravo/core2/login/Core2LoginUtilsServlet.java
---
(0151795)
hgbot (developer)
2023-06-29 09:17

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 4c892f2da013da558eb9084358d52e2a61ff4b24
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 28-06-2023 15:53:52
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/4c892f2da013da558eb9084358d52e2a61ff4b24 [^]

Fixes ISSUE-52852: Be consistent when checking if the user is authenticatedd

Now both in MobileCoreLoginUtilsServlet and in Core2LoginUtilsServlet, the same condition will be check to
determine if the current user is authenticated. The isSessionActive has been moved from the latter to the
former

---
M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
---
(0151796)
hgbot (developer)
2023-06-29 09:17

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/558 [^]
(0151797)
AugustoMauch (manager)
2023-06-29 09:31

 Reopened to create backports

- Issue History
Date Modified Username Field Change
2023-06-26 16:55 AugustoMauch New Issue
2023-06-26 16:55 AugustoMauch Assigned To => Triage Platform Base
2023-06-26 16:55 AugustoMauch Triggers an Emergency Pack => No
2023-06-26 16:55 AugustoMauch Assigned To Triage Platform Base => AugustoMauch
2023-06-26 16:55 AugustoMauch Status new => scheduled
2023-06-26 16:57 hgbot Note Added: 0151655
2023-06-26 16:57 hgbot Note Added: 0151656
2023-06-29 09:17 hgbot Resolution open => fixed
2023-06-29 09:17 hgbot Note Added: 0151793
2023-06-29 09:17 hgbot Status scheduled => closed
2023-06-29 09:17 hgbot Fixed in Version => 23Q4
2023-06-29 09:17 hgbot Note Added: 0151794
2023-06-29 09:17 hgbot Fixed in Version 23Q4 => RR23Q4
2023-06-29 09:17 hgbot Note Added: 0151795
2023-06-29 09:17 hgbot Note Added: 0151796
2023-06-29 09:31 AugustoMauch Note Added: 0151797
2023-06-29 09:31 AugustoMauch Status closed => new
2023-06-29 09:31 AugustoMauch Resolution fixed => open
2023-06-29 09:31 AugustoMauch Fixed in Version RR23Q4 =>
2023-06-29 09:31 AugustoMauch Status new => scheduled
2023-06-29 09:31 AugustoMauch Status scheduled => resolved
2023-06-29 09:31 AugustoMauch Resolution open => fixed
2023-06-29 09:31 AugustoMauch Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker