Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052764
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Coreminorhave not tried2023-06-16 08:422023-06-16 08:58
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version22Q3.3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052764: Popup should not be displayed when the application is refreshed programatically

DescriptionWhen the user tries to refresh the browser manually, a popup is displayed to ensure the state is persisted before refreshing the browser.

But that popup is not needed when the application is refreshed programatically, we could automatically force the persistence of the state as part of that programatical refresh.
Steps To Reproduce- Open POS2
- Log in
- In the back office, do a change in a terminal property (i.e. change the default business partner and address)
- In POS2, refresh the master data. A refresh will be tried because there were changes in the terminal, and the intrusive popup will be displayed that will allow the user to skip the refresh resulting in inconsistencies
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0052314 closedAugustoMauch Popup should not be displayed when the application is refreshed programatically 

-  Notes
(0151253)
hgbot (developer)
2023-06-16 08:45

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/553 [^]
(0151254)
hgbot (developer)
2023-06-16 08:46

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1137 [^]
(0151255)
hgbot (developer)
2023-06-16 08:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/553 [^]
(0151256)
hgbot (developer)
2023-06-16 08:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^]
Changeset: 82f5e171f0638a4cc07436fd68f372789571db9a
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-06-2023 08:44:46
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/82f5e171f0638a4cc07436fd68f372789571db9a [^]

Fixes ISSUE-52764: Adds a function to reload the properly reload the application programatically

The new function OB.App.reload will ensure the state is flushed before the reload, and will also unregister the
onbeforeunload listener to prevent the reload popup from appearing

---
M web/org.openbravo.mobile.core/app/model/application-state/StatePersistence.js
---
(0151257)
hgbot (developer)
2023-06-16 08:58

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1137 [^]
(0151258)
hgbot (developer)
2023-06-16 08:58

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: c1df693530ebbddfb4ee0c54424caf480311be29
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-06-2023 08:46:08
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/c1df693530ebbddfb4ee0c54424caf480311be29 [^]

Fixes ISSUE-52764: Uses OB.App.reload instead of window.location.reload

The OB.App.reload function will ensure that the state is persisted before reload and also that the
popup that is open when the user refreshes manually to have time to persist the state is not rendered

---
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/ProfileSelector.jsx
M web-jspack/org.openbravo.core2/src/components/AppBar/ProfileSelector/__test__/ProfileSelector.test.jsx
M web-jspack/org.openbravo.core2/src/components/ErrorFallback/ErrorFallback.jsx
M web-jspack/org.openbravo.core2/src/core/authentication/LoginProcess.js
M web-jspack/org.openbravo.core2/src/core/authentication/__test__/LoginProcess.test.js
M web-jspack/org.openbravo.core2/src/core/masterdata/MasterdataRefresh.js
M web-jspack/org.openbravo.core2/src/model/user-interface/user-actions/RefreshMasterdata.js
M web-jspack/org.openbravo.core2/src/registerServiceWorker.js
M web-jspack/org.openbravo.core2/src/serviceWorkerRegistration.js
---

- Issue History
Date Modified Username Field Change
2023-06-16 08:42 AugustoMauch New Issue
2023-06-16 08:42 AugustoMauch Assigned To => AugustoMauch
2023-06-16 08:42 AugustoMauch Triggers an Emergency Pack => No
2023-06-16 08:42 AugustoMauch Issue generated from 0052314
2023-06-16 08:43 AugustoMauch Issue cloned 0052765
2023-06-16 08:43 AugustoMauch Target Version 22Q4 => 22Q3.2
2023-06-16 08:45 hgbot Note Added: 0151253
2023-06-16 08:46 hgbot Note Added: 0151254
2023-06-16 08:58 hgbot Resolution open => fixed
2023-06-16 08:58 hgbot Status new => closed
2023-06-16 08:58 hgbot Note Added: 0151255
2023-06-16 08:58 hgbot Fixed in Version => RR22Q3.3
2023-06-16 08:58 hgbot Note Added: 0151256
2023-06-16 08:58 hgbot Note Added: 0151257
2023-06-16 08:58 hgbot Fixed in Version RR22Q3.3 => 22Q3.3
2023-06-16 08:58 hgbot Note Added: 0151258
2023-06-21 09:26 AugustoMauch Relationship added blocks 0052314

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker