Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0052701 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2023-06-08 13:42 | 2023-06-22 09:25 | |||
Reporter | ludmila_ursu | View Status | public | |||||
Assigned To | sreehari | |||||||
Priority | high | Resolution | fixed | Fixed in Version | RR23Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | approved | |||||||
Review Assigned To | ||||||||
OBNetwork customer | OBPS | |||||||
Support ticket | 65194 | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0052701: totalDeleteTickets incorrectly incremented on cash up.mp4 | |||||||
Description | Hello team, When we connect to a POS, do a cash up without creating any tickets, the variable totalDeleteTickets is incremented by 1. In code: newCashup.totalDeleteTickets += 1; File: web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js The code deletes the default (empty) ticket from the Web POS. This variable (totalDeleteTickets) is used in reports that are printed for customers. The deletion of the default empty ticket in the begining will make report incorrect. | |||||||
Steps To Reproduce | 1. Connect to Web POS 2. Set a breakpoint on the line newCashup.totalDeleteTickets += 1; 3. Do the cash up. You will see that the execution stops at the line with the breakpoint. Variable is icremented by 1, even if no ticket was deleted by the cashier. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
|
![]() |
|
(0151371) hgbot (developer) 2023-06-20 13:35 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1251 [^] |
(0151475) hgbot (developer) 2023-06-22 09:25 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 787da3077e0cb6d9edafec688d4a9a7baeea0b03 Author: Sreehari Venkataraman <sreehari@qualiantech.com> Date: 22-06-2023 06:31:43 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/787da3077e0cb6d9edafec688d4a9a7baeea0b03 [^] Fixes ISSUE-52701: Added additional checks before incrementing totalDeleteTickets *When deleting ticket if ticket has no lines or payments, then totalDeleteTickets should not be incremented --- M web-test/model/business-object/ticket/actions/CloseTicket.test.js M web-test/model/business-object/ticket/actions/DeleteTicket.test.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteTicket.js --- |
(0151476) hgbot (developer) 2023-06-22 09:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1251 [^] |
![]() |
|||
Date Modified | Username | Field | Change |
2023-06-08 13:42 | ludmila_ursu | New Issue | |
2023-06-08 13:42 | ludmila_ursu | Assigned To | => Retail |
2023-06-08 13:42 | ludmila_ursu | File Added: Bug livebuilds - totalDeleteTickets incorrectly incremented on cash up.mp4 | |
2023-06-08 13:42 | ludmila_ursu | OBNetwork customer | => No |
2023-06-08 13:42 | ludmila_ursu | Support ticket | => 65194 |
2023-06-08 13:42 | ludmila_ursu | Triggers an Emergency Pack | => No |
2023-06-09 07:46 | sreehari | Assigned To | Retail => sreehari |
2023-06-12 08:02 | marvintm | OBNetwork customer | No => OBPS |
2023-06-15 14:44 | sreehari | Status | new => scheduled |
2023-06-20 13:35 | hgbot | Merge Request Status | => open |
2023-06-20 13:35 | hgbot | Note Added: 0151371 | |
2023-06-22 09:25 | hgbot | Merge Request Status | open => approved |
2023-06-22 09:25 | hgbot | Resolution | open => fixed |
2023-06-22 09:25 | hgbot | Status | scheduled => closed |
2023-06-22 09:25 | hgbot | Fixed in Version | => RR23Q3 |
2023-06-22 09:25 | hgbot | Note Added: 0151475 | |
2023-06-22 09:25 | hgbot | Note Added: 0151476 |
Copyright © 2000 - 2009 MantisBT Group |