Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052539
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2023-05-23 17:482023-06-19 16:00
ReporterrafarodaView Statuspublic 
Assigned Tosreehari 
PrioritynormalResolutionfixedFixed in Version23Q3
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052539: RM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products

DescriptionRM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products

See video with sound https://drive.google.com/file/d/1iNjvsFyr0HuJeBgXbP4S61iGd3EPYy5U/view?usp=share_link [^]
Steps To ReproduceIn Live Builds, in touchpoints VBS-2

1) First make sure that the payment method CARD you indicate Overpayment = 0 (see image attached) https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=4D9F5E9CC0014A96861CEFB64BBF013B&recordId=DA57972154C04D0B9A399A06237C64AC [^]

2) In POS do a new ticket with user vallblanca https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]

3) Add 2 lines to the ticket with products:
* Balaclava Cap
* Hiking boots
* Total of the ticket 338€

4) Add payment method CARD for Amount = 500€: you get a message saying that you can't do overpayments for that payment method, this is correct OK

5) Enter now 338€ on CARD payment method

6) Before finalizing the ticket, remove the product Balaclava Cap

7) You are able to finalise DONE the ticket with an Overpayment in CARD payment method, which should not be allowed, this is the error KO


See video with sound https://drive.google.com/file/d/1iNjvsFyr0HuJeBgXbP4S61iGd3EPYy5U/view?usp=share_link [^]
Proposed SolutionIn step 7 the re-evaluation of Overpayment Not Allowed should happen to avoid to do an overpayment in a payment method which does not allow overpayment
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2023-05-23 17-36-19.png [^] (99,471 bytes) 2023-05-23 17:48

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0052737 closedranjith_qualiantech_com Cashup is possible even with ticket with payments (without ticket lines) 
causes defect 0052756 closedsreehari [SALES] [VERIFIED RETURN] Cannot complete a verified return after selecting payment method for refund 

-  Notes
(0150364)
hgbot (developer)
2023-05-29 09:01

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1848 [^]
(0151186)
hgbot (developer)
2023-06-15 08:46

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1848 [^]
(0151187)
hgbot (developer)
2023-06-15 08:46

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 7777e864d20f2ddcfe0711bcaed46bf57521ce66
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 15-06-2023 06:46:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/7777e864d20f2ddcfe0711bcaed46bf57521ce66 [^]

Fixes ISSUE-52539: Added overpayment checks for payment button enabled
*Updated Sample jest test related to overpayment checks
*Changed Number.MAX_VALUE to Number.MAX_SAFE_INTEGER
*Created isOverPaymentExceeds function and exported it, so can use it as a common function

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/stories/PaymentKeypad.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsHighVolumePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__test__/PaymentPanel.test.jsx
---
(0151312)
hgbot (developer)
2023-06-19 16:00

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 3ab4fdba8bf8b63af0623e06dc7d2ab71d2c3484
Author: Sreehari Venkataraman <sreehari@qualiantech.com>
Date: 19-06-2023 13:16:37
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/3ab4fdba8bf8b63af0623e06dc7d2ab71d2c3484 [^]

Revert "Fixes ISSUE-52539: Added overpayment checks for payment button enabled"

This reverts commit e633bb18290a48141491ee44dd211fb0b5ad5873.

---
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentIntegration/processPayment.js
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/PaymentKeypad.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/__test__/PaymentKeypad.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentKeypad/stories/PaymentKeypad.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/__test__/PaymentMethodsHighVolumePanel.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentPanel/__test__/PaymentPanel.test.jsx
---

- Issue History
Date Modified Username Field Change
2023-05-23 17:48 rafaroda New Issue
2023-05-23 17:48 rafaroda Assigned To => Retail
2023-05-23 17:48 rafaroda File Added: Screenshot from 2023-05-23 17-36-19.png
2023-05-23 17:48 rafaroda OBNetwork customer => Gold
2023-05-23 17:48 rafaroda Triggers an Emergency Pack => No
2023-05-24 07:37 ranjith_qualiantech_com Assigned To Retail => sreehari
2023-05-24 09:39 sreehari Status new => scheduled
2023-05-29 09:01 hgbot Merge Request Status => open
2023-05-29 09:01 hgbot Note Added: 0150364
2023-06-13 17:49 rafaroda Relationship added related to 0052737
2023-06-15 08:46 hgbot Merge Request Status open => approved
2023-06-15 08:46 hgbot Resolution open => fixed
2023-06-15 08:46 hgbot Status scheduled => closed
2023-06-15 08:46 hgbot Note Added: 0151186
2023-06-15 08:46 hgbot Fixed in Version => 23Q3
2023-06-15 08:46 hgbot Note Added: 0151187
2023-06-15 16:50 marvintm Relationship added causes 0052756
2023-06-19 16:00 hgbot Note Added: 0151312

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker