0052539: RM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products

Openbravo Issue Tracking System - POS2

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0052539

POS2

POS

public

2023-05-23 17:48

2023-06-19 16:00

Reporter

rafaroda

Assigned To

sreehari

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

23Q3

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0052539: RM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products

Description

RM-6309 Overpayment Not Allowed: this condition is not properly evaluated in the case of removing products

See video with sound https://drive.google.com/file/d/1iNjvsFyr0HuJeBgXbP4S61iGd3EPYy5U/view?usp=share_link [^]

Steps To Reproduce

In Live Builds, in touchpoints VBS-2

1) First make sure that the payment method CARD you indicate Overpayment = 0 (see image attached) https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/?tabId=4D9F5E9CC0014A96861CEFB64BBF013B&recordId=DA57972154C04D0B9A399A06237C64AC [^]

2) In POS do a new ticket with user vallblanca https://livebuilds.openbravo.com/context/retail_pos2_modules_pgsql/web/pos/?terminal=VBS-2 [^]

3) Add 2 lines to the ticket with products:
* Balaclava Cap
* Hiking boots
* Total of the ticket 338€

4) Add payment method CARD for Amount = 500€: you get a message saying that you can't do overpayments for that payment method, this is correct OK

5) Enter now 338€ on CARD payment method

6) Before finalizing the ticket, remove the product Balaclava Cap

7) You are able to finalise DONE the ticket with an Overpayment in CARD payment method, which should not be allowed, this is the error KO

See video with sound https://drive.google.com/file/d/1iNjvsFyr0HuJeBgXbP4S61iGd3EPYy5U/view?usp=share_link [^]

Proposed Solution

In step 7 the re-evaluation of Overpayment Not Allowed should happen to avoid to do an overpayment in a payment method which does not allow overpayment

Additional Information

Tags

No tags attached.

Relationships

related to	defect	0052737		closed	ranjith_qualiantech_com	Cashup is possible even with ticket with payments (without ticket lines)
causes	defect	0052756		closed	sreehari	[SALES] [VERIFIED RETURN] Cannot complete a verified return after selecting payment method for refund