Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0052441
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformmajorhave not tried2023-05-12 20:512023-07-07 11:16
ReporteraxelmercadoView Statuspublic 
Assigned Tojarmendariz 
PriorityurgentResolutionfixedFixed in VersionPR20Q4.5
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR20Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052441: install.source fails with "DROP DATABASE cannot be executed within a pipeline" with postgres latest minor releases

DescriptionLatest minor releases for PostgreSQL for major versions 11,12,13,14,15 include a change causing install.source to always fail.

Specific PG versions including this change: 15.2, 14.7, 13.10, 12.14, and 11.19

Error message shown is:
<workspace>/src-db/database/build-create.xml:104: org.postgresql.util.PSQLException: ERROR: DROP DATABASE cannot be executed within a pipeline

Cause:
In issue 45385 we added code to workaround an incompatibility of Amazon RDS (compared to standard PostgreSQL).
Specifically adding an (optional) alter database owner change, just before the drop database.

Postgres change https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f48aa5df4e030ab75bdc2ca5fc480c4a830cf5f3 [^] [^]
now rejects some commands when being run in an already open transaction (and instead require an explicit commit)

This bug-report from another project is hit by the same change:
https://www.postgresql.org/message-id/4139340.1676050723%40sss.pgh.pa.us [^] [^]
discussion in there shows that is an intended behavior change (as that was just unsupported before, just not detected).

So looks like we need to workaround this on our side.

Note:
This issue is triggered even when database does not exist (so nothing to drop).
Just having the alter+drop in 1 transaction to be executed is enough to trigger the issue.
Steps To ReproduceBasline: postgresql 11 or higher in latest minor version (at least the ones specified above)
ant install.source

Observe it failing with error message specified above.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0051718 closedshuehner install.source fails with "DROP DATABASE cannot be executed within a pipeline" with postgres latest minor releases 

-  Notes
(0152117)
hgbot (developer)
2023-07-05 08:44

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/931 [^]
(0152189)
hgbot (developer)
2023-07-07 11:16

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 5fb0d3c86f023362b546a27744872d0bd5b17591
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 05-07-2023 08:43:57
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/5fb0d3c86f023362b546a27744872d0bd5b17591 [^]

Fixed ISSUE-52441: Fix create.database with latest PG minor releases

---
M src-db/database/build-create.xml
---
(0152190)
hgbot (developer)
2023-07-07 11:16

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/931 [^]

- Issue History
Date Modified Username Field Change
2023-05-12 20:51 axelmercado New Issue
2023-05-12 20:51 axelmercado Assigned To => Triage Platform Base
2023-05-12 20:51 axelmercado Modules => Core
2023-05-12 20:51 axelmercado Triggers an Emergency Pack => No
2023-05-12 20:52 axelmercado Relationship added blocks 0051718
2023-07-05 08:44 hgbot Note Added: 0152117
2023-07-05 08:46 jarmendariz Assigned To Triage Platform Base => jarmendariz
2023-07-05 08:46 jarmendariz Status new => scheduled
2023-07-07 11:16 hgbot Resolution open => fixed
2023-07-07 11:16 hgbot Status scheduled => closed
2023-07-07 11:16 hgbot Fixed in Version => PR20Q4.5
2023-07-07 11:16 hgbot Note Added: 0152189
2023-07-07 11:16 hgbot Note Added: 0152190


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker