Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052370
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajorhave not tried2023-05-06 11:002023-08-02 08:41
ReporterAugustoMauchView Statuspublic 
Assigned Toablasco 
PrioritynormalResolutionfixedFixed in Version23Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052370: Performance: Keymap buttons are rerendered on scroll

DescriptionWhen using the scroll on a keymap, all its buttons are being continually, unnecessarily re-rendered.

Steps To ReproduceSee the attached images. One shows a profile log that shows how much cpu-consuming is to scroll a keymap (in the product keymap most of the time is spent on ProductButton.preparePayload).

The other image shows a log that is rendered each time the BaseKeymap or a ProductButton is rerendered. Note that log was also added to ProductKeymap, but that component is not being rerendered on scroll.
TagsNo tags attached.
Attached Filesgif file icon KeymapRerender.gif [^] (878,151 bytes) 2023-05-06 11:02
png file icon KeymapProfile.png [^] (215,339 bytes) 2023-05-06 11:04

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0152793)
hgbot (developer)
2023-07-21 11:46

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1181 [^]
(0153084)
hgbot (developer)
2023-08-02 08:41

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/1181 [^]
(0153085)
hgbot (developer)
2023-08-02 08:41

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^]
Changeset: 4d90e236f10f570af164658525451f76141ccd2e
Author: adrian.blasco <adrian.blasco@openbravo.com>
Date: 01-08-2023 15:05:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/4d90e236f10f570af164658525451f76141ccd2e [^]

Fixes ISSUE-52370 usePagination memoized and check disable dependency which causes rendering

usePagination should be memoized to avoid rerendering component with its children ( in this case, ProductKeymap which is using BaseKeymap )

Also, the content of the BaseKeymap has been memoized to avoid being rerendered when a BaseKeymap property that is not relevant to it (i.e.
disable, that affects the Carousel subcomponent but not the main BaseKeymap content).

---
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/BaseKeymap.jsx
M web-jspack/org.openbravo.core2/src/components/BaseKeymap/hooks/usePagination.js
---

- Issue History
Date Modified Username Field Change
2023-05-06 11:00 AugustoMauch New Issue
2023-05-06 11:00 AugustoMauch Assigned To => Triage Platform Base
2023-05-06 11:00 AugustoMauch Triggers an Emergency Pack => No
2023-05-06 11:02 AugustoMauch File Added: KeymapRerender.gif
2023-05-06 11:04 AugustoMauch File Added: KeymapProfile.png
2023-06-22 14:04 AugustoMauch Assigned To Triage Platform Base => ablasco
2023-07-21 11:46 hgbot Note Added: 0152793
2023-07-26 14:33 AugustoMauch Status new => scheduled
2023-08-02 08:41 hgbot Resolution open => fixed
2023-08-02 08:41 hgbot Status scheduled => closed
2023-08-02 08:41 hgbot Note Added: 0153084
2023-08-02 08:41 hgbot Fixed in Version => 23Q4
2023-08-02 08:41 hgbot Note Added: 0153085

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker