Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0052361 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Web POS | minor | have not tried | 2023-04-27 18:20 | 2023-05-05 11:08 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR23Q1.2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | RR23Q1.3 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0052361: SimpleQueryBuilder improvements | |||||||
| Description | See https://docs.google.com/document/d/1D6fbsv4Ulx0j6VrVKnoSmhX5VW10tbk9yn3AsjA75Z4/edit [^] | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0149327) hgbot (developer) 2023-05-05 09:29 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/513 [^] |
|
(0149339) hgbot (developer) 2023-05-05 11:08 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core [^] Changeset: 613ccf810d337a9e4aea7bd6cbfaede27c0fb773 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 05-05-2023 09:28:41 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/commit/613ccf810d337a9e4aea7bd6cbfaede27c0fb773 [^] Fixes ISSUE-52361: Validates attributes of OrderByCriteria to prevent HQL injection The OrderByCriteria criteria class accepts two different ways of defining the order by clause: a string and a JSONArray that contains pairs of properties-sorting directions. Both were vulnerable to HQL injection attacks. To prevent them, now we are: - transforming the string param to a JSONArray, checking that the format is the expected one - validating the JSONArray to check that both properties and sorting directions have the format expected --- A src-test/org/openbravo/mobile/core/process/OrderByCriteriaValidatorTest.java A src/org/openbravo/mobile/core/process/OrderByCriteriaValidator.java M src/org/openbravo/mobile/core/process/SimpleQueryBuilder.java --- |
|
(0149340) hgbot (developer) 2023-05-05 11:08 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.mobile.core/-/merge_requests/513 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-05-05 09:08 | AugustoMauch | Type | defect => backport |
| 2023-05-05 09:08 | AugustoMauch | Target Version | => RR23Q1.3 |
| 2023-05-05 09:29 | hgbot | Note Added: 0149327 | |
| 2023-05-05 11:08 | hgbot | Resolution | open => fixed |
| 2023-05-05 11:08 | hgbot | Status | scheduled => closed |
| 2023-05-05 11:08 | hgbot | Fixed in Version | => RR23Q1.2 |
| 2023-05-05 11:08 | hgbot | Note Added: 0149339 | |
| 2023-05-05 11:08 | hgbot | Note Added: 0149340 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |