Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0052346
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSminorhave not tried2023-05-04 11:292023-05-16 09:25
ReporterAugustoMauchView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in Version23Q2.1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version23Q2.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052346: Some keymap editor errors could be mitigated

DescriptionSome of the keymap editor errors that result from making changes from a terminal that does not contain the latest terminal info can be mitigated so that an Error while importing is not created.

In particular, for all entities that do not have child tabs, instead of creating an EWI when we find that a unique constraint is going to be broken, we could instead overwrite the value of the existing entry
Steps To ReproduceTO BE DONE
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0052345 closedmeriem_azaf Some keymap editor errors could be mitigated 

-  Notes
(0149652)
hgbot (developer)
2023-05-12 09:13

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1786 [^]
(0149769)
hgbot (developer)
2023-05-16 09:25

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1786 [^]
(0149770)
hgbot (developer)
2023-05-16 09:25

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 57fbe1a57423cc0271f9b6fca1f2bce4131fbb5c
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 16-05-2023 07:25:30
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/57fbe1a57423cc0271f9b6fca1f2bce4131fbb5c [^]

Fixes ISSUE-52346: When saving keymap editor changes, update existing row if possible

The KeymapLoader was already trying to update an existing row instead of creating a new one that would result in a database
contraint not being met, and an Error While Importing being generated. This worked fine when the id of the existing record
was the same as the id of the record being saved from the frontend. That is the most common case, but if the terminal did
not have the latest keymap information data, it could be that a equivalent record to an another one in the backend was created
(different ID, but same unique properties).

For those entities that do not have subtabs (that is, no other entities reference them), instead of creating the duplicated record
we can apply the new changes coming from the frontend to the existing record in the frontend, even if they have different IDs

---
M src/org/openbravo/pos2/KeymapLoader.java
---

- Issue History
Date Modified Username Field Change
2023-05-04 11:29 AugustoMauch Type defect => backport
2023-05-04 11:29 AugustoMauch Target Version => 23Q2.1
2023-05-12 09:13 hgbot Merge Request Status => open
2023-05-12 09:13 hgbot Note Added: 0149652
2023-05-16 09:25 hgbot Merge Request Status open => approved
2023-05-16 09:25 hgbot Resolution open => fixed
2023-05-16 09:25 hgbot Status scheduled => closed
2023-05-16 09:25 hgbot Note Added: 0149769
2023-05-16 09:25 hgbot Fixed in Version => 23Q2.1
2023-05-16 09:25 hgbot Note Added: 0149770

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker