Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0052070
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2023-04-05 12:552023-04-26 09:48
Reportermeriem_azafView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version23Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

DescriptionIn the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0056263 closedranjith_qualiantech_com Retail Modules Mitigation https://issues.openbravo.com/view.php?id=52070 [^] should not create a new cashup in POS 
blocks defect 0052067 closedmeriem_azaf POS2 Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed 

-  Notes
(0148328)
hgbot (developer)
2023-04-06 13:55

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1130 [^]
(0148690)
hgbot (developer)
2023-04-21 09:16

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1130 [^]
(0148691)
hgbot (developer)
2023-04-21 09:16

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 44dd8fba1f4b9c14245935b866e296281e59db16
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:16:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/44dd8fba1f4b9c14245935b866e296281e59db16 [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148693)
hgbot (developer)
2023-04-21 09:17

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 29b4b3d1c0d6868fe5f5be4d59de20e00e16ccaa
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:16:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/29b4b3d1c0d6868fe5f5be4d59de20e00e16ccaa [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148695)
hgbot (developer)
2023-04-21 09:20

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d8c645d73a30c9472fc1817e8c4f6fea08dd2aea
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:20:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d8c645d73a30c9472fc1817e8c4f6fea08dd2aea [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148729)
hgbot (developer)
2023-04-21 13:19

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3b1407d02924cd3f862b066e764d5fd2c68fdf7b
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 21-04-2023 13:19:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3b1407d02924cd3f862b066e764d5fd2c68fdf7b [^]

Related to ISSUE-ISSUE-52070: Fixes tests

Updates test so that they do not detect the current cashup as already processed in the backup

---
M web-test/model/business-object/cashup/Cashup-InitCashup-ActionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148907)
hgbot (developer)
2023-04-26 09:48

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1162 [^]
(0148908)
hgbot (developer)
2023-04-26 09:48

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1162 [^]
(0148909)
hgbot (developer)
2023-04-26 09:48

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6d326b15a564ab435f64a371c225736384e9d677
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 26-04-2023 09:47:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6d326b15a564ab435f64a371c225736384e9d677 [^]

Related to ISSUE-52070: Fixes tests

Updates test so that they do not detect the current cashup as already processed in the backup

---
M web-test/model/business-object/cashup/Cashup-InitCashup-ActionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---

- Issue History
Date Modified Username Field Change
2023-04-05 13:42 meriem_azaf Type defect => backport
2023-04-05 13:42 meriem_azaf Target Version => 23Q2
2023-04-06 13:55 hgbot Note Added: 0148328
2023-04-21 09:16 hgbot Resolution open => fixed
2023-04-21 09:16 hgbot Status scheduled => closed
2023-04-21 09:16 hgbot Fixed in Version => RR23Q2
2023-04-21 09:16 hgbot Note Added: 0148690
2023-04-21 09:16 hgbot Note Added: 0148691
2023-04-21 09:17 hgbot Fixed in Version RR23Q2 => RR23Q1.2
2023-04-21 09:17 hgbot Note Added: 0148693
2023-04-21 09:20 hgbot Fixed in Version RR23Q1.2 => RR23Q3
2023-04-21 09:20 hgbot Note Added: 0148695
2023-04-21 13:19 hgbot Note Added: 0148729
2023-04-26 09:48 hgbot Note Added: 0148907
2023-04-26 09:48 hgbot Note Added: 0148908
2023-04-26 09:48 hgbot Note Added: 0148909
2024-08-14 11:41 malsasua Relationship added related to 0056263


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker