Openbravo Issue Tracking System - POS2
View Issue Details
0052070POS2POSpublic2023-04-05 12:552023-04-26 09:48
meriem_azaf 
meriem_azaf 
normalmajorhave not tried
closedfixed 
5
 
23Q2 
No
0052070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed
In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.
-
No tags attached.
related to defect 0056263 closed ranjith_qualiantech_com Retail Modules Mitigation https://issues.openbravo.com/view.php?id=52070 [^] should not create a new cashup in POS 
blocks defect 0052067 closed meriem_azaf POS2 Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed 
Issue History
2023-04-05 13:42meriem_azafTypedefect => backport
2023-04-05 13:42meriem_azafTarget Version => 23Q2
2023-04-06 13:55hgbotNote Added: 0148328
2023-04-21 09:16hgbotResolutionopen => fixed
2023-04-21 09:16hgbotStatusscheduled => closed
2023-04-21 09:16hgbotFixed in Version => RR23Q2
2023-04-21 09:16hgbotNote Added: 0148690
2023-04-21 09:16hgbotNote Added: 0148691
2023-04-21 09:17hgbotFixed in VersionRR23Q2 => RR23Q1.2
2023-04-21 09:17hgbotNote Added: 0148693
2023-04-21 09:20hgbotFixed in VersionRR23Q1.2 => RR23Q3
2023-04-21 09:20hgbotNote Added: 0148695
2023-04-21 13:19hgbotNote Added: 0148729
2023-04-26 09:48hgbotNote Added: 0148907
2023-04-26 09:48hgbotNote Added: 0148908
2023-04-26 09:48hgbotNote Added: 0148909
2024-08-14 11:41malsasuaRelationship addedrelated to 0056263

Notes
(0148328)
hgbot   
2023-04-06 13:55   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1130 [^]
(0148690)
hgbot   
2023-04-21 09:16   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1130 [^]
(0148691)
hgbot   
2023-04-21 09:16   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 44dd8fba1f4b9c14245935b866e296281e59db16
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:16:22
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/44dd8fba1f4b9c14245935b866e296281e59db16 [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148693)
hgbot   
2023-04-21 09:17   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 29b4b3d1c0d6868fe5f5be4d59de20e00e16ccaa
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:16:59
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/29b4b3d1c0d6868fe5f5be4d59de20e00e16ccaa [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148695)
hgbot   
2023-04-21 09:20   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: d8c645d73a30c9472fc1817e8c4f6fea08dd2aea
Author: meriem azaf <meriem.azaf@openbravo.com>
Date: 21-04-2023 07:20:00
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/d8c645d73a30c9472fc1817e8c4f6fea08dd2aea [^]

Fixes ISSUE-52070: Cashup mitigation: do not check if current cashup is the last one processed, just check if it is processed

In the cashup mitigation we do to automatically create a new cashup if the current one is already processed in the backend, we are just checking that the current cashup was the latest one processed for this terminal. But there are some use cases not being covered so we should just check if the current cashup is processed in the backend, regardless if it being the latest one processed.

---
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148729)
hgbot   
2023-04-21 13:19   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 3b1407d02924cd3f862b066e764d5fd2c68fdf7b
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 21-04-2023 13:19:38
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/3b1407d02924cd3f862b066e764d5fd2c68fdf7b [^]

Related to ISSUE-ISSUE-52070: Fixes tests

Updates test so that they do not detect the current cashup as already processed in the backup

---
M web-test/model/business-object/cashup/Cashup-InitCashup-ActionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---
(0148907)
hgbot   
2023-04-26 09:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1162 [^]
(0148908)
hgbot   
2023-04-26 09:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1162 [^]
(0148909)
hgbot   
2023-04-26 09:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 6d326b15a564ab435f64a371c225736384e9d677
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 26-04-2023 09:47:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/6d326b15a564ab435f64a371c225736384e9d677 [^]

Related to ISSUE-52070: Fixes tests

Updates test so that they do not detect the current cashup as already processed in the backup

---
M web-test/model/business-object/cashup/Cashup-InitCashup-ActionPreparation.test.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/CashupUtils.js
M web/org.openbravo.retail.posterminal/app/model/business-object/cashup/actions/InitCashup.js
---