Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0052038
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] POSmajorhave not tried2023-03-29 10:052023-04-17 13:54
Reportermeriem_azafView Statuspublic 
Assigned Tomeriem_azaf 
PrioritynormalResolutionfixedFixed in Version23Q1.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version23Q1.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0052038: Keymap Editor - product from differents sales area on keymap configurator

DescriptionIn the configuration of the products and categories of the keymaps via the editor available on the cashier, we can see that all the products are displayed, and when we select a product that is not available/visible from one sales area to another and well this one simply does not appear
ex : I choose a ruby leffe that belongs to the restaurant sales area and decide to put this product on my take away keymap and well the item will simply not be visible
Steps To Reproduce1- Login in POS2.
2- Go to keymap editor.
3- Choose the keymap Main Terrace Keymap.
4- Click on view versions and after view categories.
5- Choose the keymap category Appetizers and click on view products.
6- Click on link product.
7- Add this product: All mountain ski board Cham.

-> this product should not be added because is not belong to the price list of the Appetizers category.
Proposed SolutionWe should be able to do the check when a product in that grid is clicked to be added to the keymap category. in that case we want to cancel the click and show a notification to the user
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0052004 closedmeriem_azaf Keymap Editor - product from differents sales area on keymap configurator 

-  Notes
(0148189)
hgbot (developer)
2023-04-03 11:48

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1662 [^]
(0148484)
hgbot (developer)
2023-04-17 13:54

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1662 [^]
(0148485)
hgbot (developer)
2023-04-17 13:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: f06c169d5d1356b6451592941c4bce64a0e0d0a3
Author: Meriem Azaf <meriem.azaf@openbravo.com>
Date: 17-04-2023 11:54:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f06c169d5d1356b6451592941c4bce64a0e0d0a3 [^]

Fixes ISSUE-52038: Keymap Editor - product from differents sales area on keymap configurator

In the configuration of the products and categories of the keymaps via the editor available on the cashier, we can see that all the products are displayed, and when we select a product that is not available/visible from one sales area to another and well this one simply does not appear.

The problem here that we displayed all the products that we have in different price lists so for that we cannot do the filtration using the schema selected because of IndexedDB limitations.

So what we did is when we add the product first we check if the product is belong to the price list of the selected schema and if not we cancel the click and show a notification to the user.

Note: for the schema that not has a price list we can add any product.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/KeymapEditorLinkedDialog.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/__test__/KeymapEditorLinkedDialog.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorLinkedDialog/stories/KeymapEditorLinkedDialog.stories.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/KeyMapEditorKeymapsGrid.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/SchemaTags/SchemaTags.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/SchemaTags/__test__/SchemaTags.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorKeymapsGrid/__test__/KeyMapEditorKeymapsGrid.test.jsx
M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeymapEditorLinkedProduct/__test__/KeymapEditorLinkedProduct.test.jsx
---

- Issue History
Date Modified Username Field Change
2023-04-03 11:37 meriem_azaf Type defect => backport
2023-04-03 11:37 meriem_azaf Target Version => 23Q1.2
2023-04-03 11:48 hgbot Note Added: 0148189
2023-04-17 13:54 hgbot Resolution open => fixed
2023-04-17 13:54 hgbot Status scheduled => closed
2023-04-17 13:54 hgbot Note Added: 0148484
2023-04-17 13:54 hgbot Fixed in Version => 23Q1.2
2023-04-17 13:54 hgbot Note Added: 0148485


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker