0051987: Incorrect commission calculation

Description

When we try to calculate the commission due to a sales rep, if the sales rep has 2 rules to comply with, the calculation is incorrect.

Steps To Reproduce

1-In Livebuilds, with the F&B administrator role, go to the "Commissions" window and create a commission with the following configuration and lines (see attached images).

2- In the "Sales Order" window, filter by "Luna Llena Restaurant", business partner used in one of the commission lines. To the last invoice generated with date in the month of June, in the section "More information", place as sales representative the person for whom we created the commission, in our example, Javier Martin.

3- In the "Commissions" window, we are going to click on the "Generate commission" button for the commission previously configured with date "01-06-2021" in order to consider the previously modified invoice.

4- In the "Commission payment" window, there should be a record of the commission generated for Javier, if we go to the details of the lines, we can see that the amount is wrongly calculated and above all, that they duplicate the values of the amounts of the lines of the invoices.

Video with the example: https://www.awesomescreenshot.com/video/15873830?key=8b2f201cdb523f56556a36f97a1ab244. [^]

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0148487) hgbot (developer) 2023-04-17 14:27	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/857 [^]

(0148600) hgbot (developer) 2023-04-19 15:50	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 6d9b7e68242c4f04a34bf8c28c5757acedf9ca15 Author: Francisco Javier Deler O'Farril <francisco.ofarril@openbravo.com> Date: 19-04-2023 13:50:28 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6d9b7e68242c4f04a34bf8c28c5757acedf9ca15 [^] Fixed ISSUE-51987: Incorrect commission calculation. --- M src-db/database/model/functions/C_COMMISSION_PROCESS.xml ---

(0148601) hgbot (developer) 2023-04-19 15:50	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/857 [^]

Issue History
Date Modified	Username	Field	Change
2023-03-27 15:57	axelmercado	New Issue
2023-03-27 15:57	axelmercado	Assigned To	=> Triage Omni OMS
2023-03-27 15:57	axelmercado	Modules	=> Core
2023-03-27 15:57	axelmercado	Triggers an Emergency Pack	=> No
2023-03-27 16:06	Practics	Issue Monitored: Practics
2023-04-10 14:11	francisco_ofarril	Assigned To	Triage Omni OMS => francisco_ofarril
2023-04-10 14:11	francisco_ofarril	Status	new => scheduled
2023-04-17 14:27	hgbot	Note Added: 0148487
2023-04-19 15:50	hgbot	Resolution	open => fixed
2023-04-19 15:50	hgbot	Status	scheduled => closed
2023-04-19 15:50	hgbot	Fixed in Version	=> PR23Q3
2023-04-19 15:50	hgbot	Note Added: 0148600
2023-04-19 15:50	hgbot	Note Added: 0148601