Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0051833

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2023-03-13 06:25

2023-03-22 07:45

Reporter

ranjith_qualiantech_com

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR23Q2

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

No

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0051833: Discount API throws error if manualPromotions presents

Description

When discount api is called with manualPromotions, then error occurs.

Steps To Reproduce

1) Open https://livebuilds.openbravo.com/retail_modules_pgsql_pi/api [^]
2) Choose "discounts" from dropdown
3) Click Tryit out
4) Paste the attached body "DiscountAPI_body.txt"
5) Click Execute

Response:
{
"error": "TypeError: Cannot read property 'some' of undefined"
}

Tags

No tags attached.

DiscountAPI_body.txt [^] (1,237 bytes) 2023-03-13 08:34 [Show Content] [Hide Content]

{
  "ticket": {
    "id": "F54FA593DBCC48B3AFFA2FF4298FE411",
    "organization": {
      "id": "D270A5AC50874F8BA67A88EE977F8E3B",
      "_identifier": "Vall Blanca Store"
    },
    "businessPartner": {
      "id": "ABD91C9D3BC94175B876FBBE9CACA008",
      "_identifier": "VBS Customer"
    },
    "orderDate": "2023-03-10T11:54:21",
    "priceIncludesTax": true,
    "discountsFromUser": {
      "manualPromotions": [
        {
          "id": "E95B84F4D46E407EBC0C57507DFB8C70",
          "name": "disc_5_var_euro",
          "discountType": "D1D193305A6443B09B299259493B272A",
          "obdiscAmt": 10,
          "linesToApply": [
            "6A1F97519F1C45BB9538C8F38C914D11"
          ]
        }
      ]
    },
    "lines": [
      {
        "id": "60BE74DA6C424ED388A3F6306A55FAB2",
        "product": {
          "id": "3BD414F7A8024D108AF4759F240A966C",
          "_identifier": "Bottle 1 L"
        },
        "qty": 3,
        "baseGrossUnitPrice": 9
      },
      {
        "id": "6A1F97519F1C45BB9538C8F38C914D11",
        "product": {
          "id": "934E7D7587EC4C7A9E9FF58F0382D450",
          "_identifier": "Avalanche transceiver"
        },
        "qty": 4,
        "baseGrossUnitPrice": 150
      }
    ]
  }
}

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0147510) hgbot (developer) 2023-03-14 08:04	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/94 [^]

(0147797) hgbot (developer) 2023-03-22 07:45	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/94 [^]

(0147798) hgbot (developer) 2023-03-22 07:45	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 708e28dca6224665e503fb2bef2fc48b588ad325 Author: Ranjith S R <ranjith@qualiantech.com> Date: 22-03-2023 06:45:24 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/708e28dca6224665e503fb2bef2fc48b588ad325 [^] Fixed ISSUE-51833: Discounts filters should be validated when applying discounts * If discount filters are not present, then discount calculation should be continued --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/discount-rules.js ---

Issue History
Date Modified	Username	Field	Change
2023-03-13 06:25	ranjith_qualiantech_com	New Issue
2023-03-13 06:25	ranjith_qualiantech_com	Assigned To	=> ranjith_qualiantech_com
2023-03-13 06:25	ranjith_qualiantech_com	OBNetwork customer	=> No
2023-03-13 06:25	ranjith_qualiantech_com	Triggers an Emergency Pack	=> No
2023-03-13 08:28	ranjith_qualiantech_com	Status	new => scheduled
2023-03-13 08:34	ranjith_qualiantech_com	File Added: DiscountAPI_body.txt
2023-03-14 08:04	hgbot	Merge Request Status	=> open
2023-03-14 08:04	hgbot	Note Added: 0147510
2023-03-22 07:45	hgbot	Merge Request Status	open => approved
2023-03-22 07:45	hgbot	Resolution	open => fixed
2023-03-22 07:45	hgbot	Status	scheduled => closed
2023-03-22 07:45	hgbot	Note Added: 0147797
2023-03-22 07:45	hgbot	Fixed in Version	=> RR23Q2
2023-03-22 07:45	hgbot	Note Added: 0147798

Copyright © 2000 - 2009 MantisBT Group