Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051736
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2023-03-01 09:412023-03-01 12:57
ReporternoemierousselView Statuspublic 
Assigned Toalostale 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051736: The flag "Approval required" should be disponible for "discretionary" and "optional" promotions

DescriptionOn the WebPOS, it is possible to set an approval option. Currently, it has been developed only for manual discounts applied to a product line, for instance those discounts types:
-User Defined Percentage
-Discretionary Fixed Amount
-Discretionary Fixed Percentage
-User Defined Amount
-User Defined Line Amount

The requirement is to be able to have the approval option for all the discretionary and optional application methods.
Steps To Reproduce1. Go to the backoffice

2. Go to the "Role" window.

3. Go to the store responsible role, and define in the subtab "User Actions Acess" "Apply Discretionary Discount" -> Can use and approve.


4. Go to the store seller role, and define in the subtab "User Actions Access" "Apply Discretionary Discount" -> Approval required.

5. Go to the discounts and promotions and select the discount type "User Defined Percentage". See that the checkbox "Approval Required" appears in the Definition section. Set the configuration of the promotion and tick the approval checkbox.

6. In the POS, use the User defined percentage discounts previously created by adding a product in the ticket and click on the "Discounts" option on the product line. See that an approval pop-up is displayed.

7. Go to the discounts and promotions and select the discount type "Fixed Discount per Total Amount". See that the checkbox "Approval Required" do not appears in the Definition section. Then, the approval pop-up is not displayed.
Proposed SolutionAdd the Approval required checkbox in all the "discretionary" and "optional" promotions
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0050620 closedRetail POS2 Approvals/reasons for manual discounts 

-  Notes
(0147153)
hgbot (developer)
2023-03-01 10:32

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1561 [^]
(0147154)
hgbot (developer)
2023-03-01 10:33

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/90 [^]
(0147162)
hgbot (developer)
2023-03-01 12:40

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 702d3a5981b952c4c8a12a21ee0c1d3e61a1b93c
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 01-03-2023 11:40:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/702d3a5981b952c4c8a12a21ee0c1d3e61a1b93c [^]

related to ISSUE-51736: missing approval required for some discounts

---
M src-db/database/sourcedata/AD_FIELD.xml
---
(0147163)
hgbot (developer)
2023-03-01 12:40

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/90 [^]
(0147164)
hgbot (developer)
2023-03-01 12:42

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 51bf1c496e9d198374f731f5c6c37f2b3e5d7c27
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 01-03-2023 11:40:57
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/51bf1c496e9d198374f731f5c6c37f2b3e5d7c27 [^]

fixes ISSUE-51736: By total discounts don't shown approval dialog

---
M src-db/database/sourcedata/OBC2_USER_ACTION.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/AddByTotalPromotionIntoTicket.js
M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/discounts/SetLineDiscounts.js
---
(0147165)
hgbot (developer)
2023-03-01 12:42

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1561 [^]

- Issue History
Date Modified Username Field Change
2023-03-01 09:41 noemieroussel New Issue
2023-03-01 09:41 noemieroussel Assigned To => Retail
2023-03-01 09:41 noemieroussel Triggers an Emergency Pack => No
2023-03-01 10:32 hgbot Note Added: 0147153
2023-03-01 10:33 hgbot Note Added: 0147154
2023-03-01 10:35 alostale Assigned To Retail => alostale
2023-03-01 12:40 hgbot Note Added: 0147162
2023-03-01 12:40 hgbot Note Added: 0147163
2023-03-01 12:42 hgbot Resolution open => fixed
2023-03-01 12:42 hgbot Status new => closed
2023-03-01 12:42 hgbot Fixed in Version => 23Q2
2023-03-01 12:42 hgbot Note Added: 0147164
2023-03-01 12:42 hgbot Note Added: 0147165
2023-03-01 12:57 alostale Relationship added related to 0050620

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker