Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0051718 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] A. Platform | critical | have not tried | 2023-02-28 12:26 | 2023-05-23 12:59 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | PR23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0051718: install.source fails with "DROP DATABASE cannot be executed within a pipeline" with postgres latest minor releases | |||||||
| Description | Latest minor releases for PostgreSQL for major versions 11,12,13,14,15 include a change causing install.source to always fail. Specific PG versions including this change: 15.2, 14.7, 13.10, 12.14, and 11.19 Error message shown is: <workspace>/src-db/database/build-create.xml:104: org.postgresql.util.PSQLException: ERROR: DROP DATABASE cannot be executed within a pipeline Cause: In issue 45385 we added code to workaround an incompatibility of Amazon RDS (compared to standard PostgreSQL). Specifically adding an (optional) alter database owner change, just before the drop database. Postgres change https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f48aa5df4e030ab75bdc2ca5fc480c4a830cf5f3 [^] now rejects some commands when being run in an already open transaction (and instead require an explicit commit) This bug-report from another project is hit by the same change: https://www.postgresql.org/message-id/4139340.1676050723%40sss.pgh.pa.us [^] discussion in there shows that is an intended behavior change (as that was just unsupported before, just not detected). So looks like we need to workaround this on our side. Note: This issue is triggered even when database does not exist (so nothing to drop). Just having the alter+drop in 1 transaction to be executed is enough to trigger the issue. | |||||||
| Steps To Reproduce | Basline: postgresql 11 or higher in latest minor version (at least the ones specified above) ant install.source Observe it failing with error message specified above. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||||||||||||||||
|
||||||||||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0147241) hgbot (developer) 2023-03-02 15:24 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/832 [^] |
|
(0147748) hgbot (developer) 2023-03-21 11:52 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/832 [^] |
|
(0147749) hgbot (developer) 2023-03-21 11:52 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: a78c697368b6a3ea2556ea7bdd3d6a0306730bfc Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 20-03-2023 11:31:52 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/a78c697368b6a3ea2556ea7bdd3d6a0306730bfc [^] Fixes ISSUE-51718: Fix create.database with latest PG minor releases PostgreSQL latest minor versions (15.2, 14.7, 13.10, 12.14, 11.19) include a change to prohibit certain SQL to run in a pipeline without an explicit commit done just before. Note: 10.x is not affected as it just went End Of Life before this change. One case where this affect us is ant create.database task. Specifically the DROP database run before (re-)creating the database: ERROR: DROP DATABASE cannot be executed within a pipeline Earlier issue 45385 had to add an ALTER DATABASE just before the DROP DATABASE to work about an incompatibility of Amazon RDS (managed postgres). As this intentionally ran ALTER and DROP database in a single transaction it now triggers that new restriction. Given that we need to have both that RDS workaround + also work with the new PostgreSQL restriction run those two statements in two separate transactions. That allows side-effect: - Owner of database changes to superuser 'postgres' - Only in case the "drop database" part fails --- M src-db/database/build-create.xml --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2023-02-28 12:26 | shuehner | New Issue | |
| 2023-02-28 12:26 | shuehner | Assigned To | => shuehner |
| 2023-02-28 12:26 | shuehner | Modules | => Core |
| 2023-02-28 12:26 | shuehner | Triggers an Emergency Pack | => No |
| 2023-02-28 12:27 | shuehner | Relationship added | caused by 0045385 |
| 2023-03-02 15:24 | hgbot | Note Added: 0147241 | |
| 2023-03-16 09:46 | shuehner | Priority | urgent => immediate |
| 2023-03-16 09:46 | shuehner | Severity | major => critical |
| 2023-03-20 12:18 | shuehner | Status | new => scheduled |
| 2023-03-21 11:52 | hgbot | Note Added: 0147748 | |
| 2023-03-21 11:52 | hgbot | Resolution | open => fixed |
| 2023-03-21 11:52 | hgbot | Status | scheduled => closed |
| 2023-03-21 11:52 | hgbot | Fixed in Version | => PR23Q2 |
| 2023-03-21 11:52 | hgbot | Note Added: 0147749 | |
| 2023-05-10 10:52 | shuehner | Issue cloned | 0052405 |
| 2023-05-10 10:52 | shuehner | Relationship added | depends on 0052405 |
| 2023-05-12 20:52 | axelmercado | Relationship added | depends on 0052441 |
| 2023-05-23 12:59 | eugeni | Issue Monitored: eugeni | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |