Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0051684
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Discounts and Promotionsmajoralways2023-02-23 15:582023-03-20 09:36
ReporterLcazauxView Statuspublic 
Assigned ToRetail 
PriorityhighResolutionfixedFixed in VersionRR23Q2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051684: Accumulating several filters for Promo type Buy X Get Y

DescriptionPromo type : Buy X Get Y

Currently, the configuration doesn't allow to accumulate the filters “Product categories”, “Characteristics” and “Product”. Only 1 can be selected in the filter section.

For the cases ‘Any X’ it should be possible to to allow combining criterias, for example ‘Product Categories’ and ‘Product characteristics’ as customer requests.

However, for ‘All X’ it cannot be allowed because the quantities are defined at level ‘Product’, ‘Product Category’ or ‘Product Characteristics’.

Steps To ReproduceBackoffice
- Go to Discount and Promo window
- Create a promotion type Buy X Get Y
- Choose definition "Buy any X get any Y" or "Buy any X get all Y"

--> For these 2 cases it is not possible to cumulate the filters
Proposed SolutionFilters should be cumulated for these 2 cases "All X"
TagsNo tags attached.
Attached Filespng file icon 2023-02-23_15h58_05.png [^] (158,199 bytes) 2023-02-23 15:58

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0050706 closedprakashmurugesan88 [PROMO] - Product category and Characteristics KO in "Buy X and get Y as a gift" promotion 
related to defect 0051897 closedRetail [Promo] - Buy X Get Y - Promotion KO when product categories and / or product characteristics selected in the filters 

-  Notes
(0147273)
hgbot (developer)
2023-03-06 07:16

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/91 [^]
(0147321)
hgbot (developer)
2023-03-07 13:24

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/91 [^]
(0147322)
hgbot (developer)
2023-03-07 13:24

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 4a58e75e844ff8f92e471cdec2dde57939221b80
Author: Prakash M <prakash@qualiantech.com>
Date: 02-03-2023 16:11:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4a58e75e844ff8f92e471cdec2dde57939221b80 [^]

Related to ISSUE-51684: Fixed BO validation to allow combination of filter for Any X

---
M src/org/openbravo/retail/discounts/event/MOfferEventHandler.java
M src/org/openbravo/retail/discounts/event/MOfferProductEventHandler.java
---
(0147323)
hgbot (developer)
2023-03-07 13:24

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: af05857daf1d0e34dcf6046f01f33f8955dac5a0
Author: Prakash M <prakash@qualiantech.com>
Date: 03-03-2023 11:05:21
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/af05857daf1d0e34dcf6046f01f33f8955dac5a0 [^]

Fixes ISSUE-51684: Changed BuyXGiftY discount engine to validate combination of filter when Buy Any X subtype

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---
(0147324)
hgbot (developer)
2023-03-07 13:24

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 5df5731a3467f741ad12d0f2c8e6e3e8367afad5
Author: Prakash M <prakash@qualiantech.com>
Date: 05-03-2023 17:12:47
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5df5731a3467f741ad12d0f2c8e6e3e8367afad5 [^]

Related to ISSUE-51684: Included combination of filter when Buy Any X subtype in Gift Reminder Notification

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---
(0147325)
hgbot (developer)
2023-03-07 13:24

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: f77b01eca69e6b7bd29cfc7fd634ff71ca26fc55
Author: Prakash M <prakash@qualiantech.com>
Date: 06-03-2023 11:31:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f77b01eca69e6b7bd29cfc7fd634ff71ca26fc55 [^]

Related to ISSUE-51684: Added test for combination of filter when Buy Any X subtype

---
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAllYTest.java
M src-test/org/openbravo/retail/discounts/test/unittests/DiscountBuyAnyXGiftAnyYTest.java
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---
(0147460)
hgbot (developer)
2023-03-13 08:33

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/93 [^]
(0147649)
hgbot (developer)
2023-03-17 13:02

 Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 1b06390ba6ab2e967ca346fd757d7161cf1342e5
Author: Prakash M <prakash@qualiantech.com>
Date: 10-03-2023 20:05:40
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/1b06390ba6ab2e967ca346fd757d7161cf1342e5 [^]

Related to ISSUE-51684: Fixed Gift Reminder Notification error for Any X Any Y discount

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/buy-x-gift-y-discount.js
---
(0147650)
hgbot (developer)
2023-03-17 13:02

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/93 [^]

- Issue History
Date Modified Username Field Change
2023-02-23 15:58 Lcazaux New Issue
2023-02-23 15:58 Lcazaux Assigned To => Retail
2023-02-23 15:58 Lcazaux File Added: 2023-02-23_15h58_05.png
2023-02-23 15:58 Lcazaux OBNetwork customer => Gold
2023-02-23 15:58 Lcazaux Triggers an Emergency Pack => No
2023-02-23 17:17 rafaroda Relationship added related to 0050706
2023-03-06 07:16 hgbot Merge Request Status => open
2023-03-06 07:16 hgbot Note Added: 0147273
2023-03-07 13:21 hgbot Merge Request Status open => approved
2023-03-07 13:24 hgbot Note Added: 0147321
2023-03-07 13:24 hgbot Note Added: 0147322
2023-03-07 13:24 hgbot Resolution open => fixed
2023-03-07 13:24 hgbot Status new => closed
2023-03-07 13:24 hgbot Fixed in Version => RR23Q2
2023-03-07 13:24 hgbot Note Added: 0147323
2023-03-07 13:24 hgbot Note Added: 0147324
2023-03-07 13:24 hgbot Note Added: 0147325
2023-03-13 08:33 hgbot Note Added: 0147460
2023-03-17 13:02 hgbot Note Added: 0147649
2023-03-17 13:02 hgbot Note Added: 0147650
2023-03-20 09:36 rafaroda Relationship added related to 0005187
2023-03-20 09:36 rafaroda Relationship deleted related to 0005187
2023-03-20 09:36 rafaroda Relationship added related to 0051897

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker