Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051290
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Coupons OTFmajoralways2023-01-05 12:102023-01-27 08:11
ReporterkchoperenaView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051290: JSONObject["mOfferId"] not found error, when doing a Cancel this order of a Layaway with OTF Coupons Generation Rules configured

DescriptionHaving configured "OTF Coupons Generation Rules" configured in back-end, an "Errors While Importing POS Data" happens when doing a Cancel this Order of a paid Layaway
Steps To Reproduce1.- In the back-end, create the configuration of a discount (see attached screenshot)
2.- In the back-end, create the configuration of an "OTF Coupons Generation Rules" (see attached screenshot)
3.- Login into the webpos and create a Layaway and pay it completely
4.- Reopen the Layaway using the "Open receipt" functionality and cancel it using "Cancel this Order"

Steps to reproduce in livebuilds
Backoffice
1) Enable discount "OTF Coupons - Coupon 5 EUR in "Backpacks & Travel"
POS
1) Add product "Bivy bag gore-tex" and complete the ticket T1
2) Make sure, Coupon is generated for the discount "OTF Coupons - Coupon 5 EUR in "Backpacks & Travel" (In Coupon tab)
3) Reopen last completed ticket T1
4) Click "Done" on ticket T1 without any changed
5) EWI occurs like below


RESULT:
An Errors While Importing POS Data happens when synchronizing the cancelation

org.codehaus.jettison.json.JSONException: JSONObject["mOfferId"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360)
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487)
    at org.openbravo.retail.discounts.coupons.otf.OrderLoaderHookOTFCoupons.exec(OrderLoaderHookOTFCoupons.java:42)
    at org.openbravo.retail.discounts.coupons.otf.OrderLoaderHookOTFCoupons$Proxy$_$$_WeldClientProxy.exec(Unknown Source)
    at org.openbravo.retail.posterminal.OrderLoader.executeHooks(OrderLoader.java:830)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:620)
    at org.openbravo.retail.posterminal.CancelLayawayLoader.saveRecord(CancelLayawayLoader.java:19)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:214)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:165)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:97)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.retail.posterminal.importprocess.CancelLayawayImportEntryProcessor$CancelLayawayRunnable.processEntry(CancelLayawayImportEntryProcessor.java:62)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:430)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:347)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2023-01-05 12-08-05.png [^] (100,980 bytes) 2023-01-05 12:10


png file icon Screenshot from 2023-01-05 12-08-31.png [^] (98,452 bytes) 2023-01-05 12:11


png file icon Screenshot from 2023-01-05 12-11-41.png [^] (113,230 bytes) 2023-01-05 12:11


png file icon Screenshot from 2023-01-05 12-12-02.png [^] (335,069 bytes) 2023-01-05 12:12

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0145811)
hgbot (developer)
2023-01-25 06:04

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/20 [^]
(0145899)
hgbot (developer)
2023-01-27 08:11

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf [^]
Changeset: f2e9e9dec3ab44b30affaa5f9ef63cafd40b5845
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 24-01-2023 12:43:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/commit/f2e9e9dec3ab44b30affaa5f9ef63cafd40b5845 [^]

Fixed ISSUE-51290: Coupon should not be created when completing the paid ticket

---
M src/org/openbravo/retail/discounts/coupons/otf/OrderLoaderHookOTFCoupons.java
M src/org/openbravo/retail/discounts/coupons/otf/hook/LoadCoupons.java
---
(0145900)
hgbot (developer)
2023-01-27 08:11

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts.coupons.otf/-/merge_requests/20 [^]

- Issue History
Date Modified Username Field Change
2023-01-05 12:10 kchoperena New Issue
2023-01-05 12:10 kchoperena Assigned To => Retail
2023-01-05 12:10 kchoperena Triggers an Emergency Pack => No
2023-01-05 12:10 kchoperena File Added: Screenshot from 2023-01-05 12-08-05.png
2023-01-05 12:11 kchoperena File Added: Screenshot from 2023-01-05 12-08-31.png
2023-01-05 12:11 kchoperena File Added: Screenshot from 2023-01-05 12-11-41.png
2023-01-05 12:12 kchoperena File Added: Screenshot from 2023-01-05 12-12-02.png
2023-01-05 12:13 kchoperena version => pi
2023-01-20 08:00 marvintm Severity critical => major
2023-01-23 13:59 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2023-01-23 13:59 ranjith_qualiantech_com Status new => scheduled
2023-01-24 08:10 ranjith_qualiantech_com Steps to Reproduce Updated View Revisions
2023-01-25 06:04 hgbot Note Added: 0145811
2023-01-27 08:11 hgbot Resolution open => fixed
2023-01-27 08:11 hgbot Status scheduled => closed
2023-01-27 08:11 hgbot Note Added: 0145899
2023-01-27 08:11 hgbot Note Added: 0145900


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker