Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0051153 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] Z. Others | minor | have not tried | 2022-12-14 14:40 | 2023-07-21 16:13 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | shuehner | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | PR23Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0051153: Review and remove modulescripts only required for updates from <16Q1 - omni | |||||||
Description | Issue 51068 blocks upgrades from versions older than 16Q1. Any modulescript running on upgrades from <16Q1 is no longer needed and can be removed if it is marked as NOT running also during install.source Many (very) old modulescripts when created before being able to declare executeOnInstall=false. Those old ones need be reviewed one-by-one if they can be safely skipped during install and then be removed as obsolete | |||||||
Steps To Reproduce | 51068 change ensures that old version (before update) is at least 16Q1 (x.x.28207) Any buildvalidation defined with ExecutionLimits end-version before that (and moduleId of a module contained in backoffice repo) => is candidated to be removed. Directly possible to remove it is also has executeOnInstall=false already. If not it must be reviewed first is that flag applies to them also. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||||||||||||||||
|
Notes | |
(0144682) hgbot (developer) 2022-12-14 14:44 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/792 [^] |
(0144888) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 68f40ce9011fc3f3996293b13d1c165b501a58e3 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/68f40ce9011fc3f3996293b13d1c165b501a58e3 [^] Related to ISSUE-51153: Delete obsolete modulescript UpdateFinancialAccountAccounts That script only ran on updates before 3.0 Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It search for fin_financial_account_acct rows with either fin_in_intransit_acct or fin_out_intransit_acct being null - Several sampeldata ship rows in that table however all of them have both field filled for every row in their xml Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFinancialAccountAccounts.class R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFinancialAccountAccountsData.class R src-util/modulescript/src/org/openbravo/modulescript/UpdateFinancialAccountAccounts.java R src-util/modulescript/src/org/openbravo/modulescript/UpdateFinancialAccountAccounts_data.xsql --- |
(0144889) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 1129b1ca324f54abad8b69091eda1ddcd43aa2e4 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/1129b1ca324f54abad8b69091eda1ddcd43aa2e4 [^] Related to ISSUE-51153: Delete obsolete modulescript UpdateReconciliationProcessButtonValue That script only ran on updates before MP16. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It updates rows in the fin_reconciliation table 4 sampledata ship rows in that table - two are covered by CI SampledataDBConsistency check which does not shows any pending changes (so script not modifying table on install) - org.openbravo.retail.sampledata - org.openbravo.test.mobile.sampledata - F_B_International_Group and QA_Testing when being exported in git master do not show any changes in this specific table. So again script is not modifying those on install. Remove it as obsolete. --- R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue.class R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValueData.class R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue.java R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue_data.xsql R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValueData.java --- |
(0144890) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 8eccf37cb8fa0cda4ad859883f5d1cb6d18aa25b Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/8eccf37cb8fa0cda4ad859883f5d1cb6d18aa25b [^] Related to ISSUE-51153: Delete obsolete modulescript CreateLineForSequenceProduct That script only ran on updates before MP16. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It searches for ma_sequenceproduct rows - No sampledata ships rows for that table Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLineForSequenceProduct.class R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLineForSequenceProductData.class R src-util/modulescript/src/org/openbravo/modulescript/CreateLineForSequenceProduct.java R src-util/modulescript/src/org/openbravo/modulescript/CreateLineForSequenceProduct_Data.xsql --- |
(0144891) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 91d9998acc33f48e7d1cf0fabf30992c543d031e Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/91d9998acc33f48e7d1cf0fabf30992c543d031e [^] Related to ISSUE-51153: Delete obsolete modulescript UpdateCostingRulesWhenNotCalculatedCosts That script only ran on updates before MP16. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It modifies entries in M_COSTING_RULE table - 4 sampledata ship m_costing_rule entries - 2 are covered by retail SampleDataConsistency check not showing any modifications - org.openbravo.retail.sampledata - org.openbravo.test.mobile.sampledata - 2 in backoffice F_B_International_Group and QA_Testing do not show any changes to this tables when exporting now The modulescript is not modifying data anymore during install.source Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateCostingRulesWhenNotCalculatedCosts.class R src-util/modulescript/src/org/openbravo/modulescript/UpdateCostingRulesWhenNotCalculatedCosts.java --- |
(0144892) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 0a22d57a5405f0fca66317a4084ae94f233b92a3 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/0a22d57a5405f0fca66317a4084ae94f233b92a3 [^] Related to ISSUE-51153: Delete obsolete modulescript UpdatePaymentProcessedValue That script only ran on updates before MP16. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It search for fin_payment entries with EM_APRM_PROCESS_PAYMENT='R' - Many sampledata repo ship fin_payment entries but none of them have the value 'R' for that column anymore Remove it as obsolete. --- R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue.class R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValueData.class R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue.java R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue_data.xsql R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValueData.java --- |
(0144893) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 32bc67a4c85767b30fd44f43c7b8bd84c9baea23 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/32bc67a4c85767b30fd44f43c7b8bd84c9baea23 [^] Related to ISSUE-51153: Delete obsolete modulescript DeleteDuplicateMatchInvoice That script only ran on updates before MP19. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It deleted rows from m_matchinv table - 4 sampledata ship rows in that table - 2 are covered by retail SampledataConsistency check (not showing any changes) - org.openbravo.retail.sampledata - org.openbravo.test.mobile.sampledata - 2 in backoffice repo F_B_International_Group & QA_Testing do not show modifications of that table when exporting sampledata now So the script is not doing any changes anymore during install.source Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateMatchInvoice.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateMatchInvoiceData.class R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateMatchInvoice.java R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateMatchInvoice_data.xsql --- |
(0144894) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: f0b7158e07be09941d2ad9d37607b034788b6754 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/f0b7158e07be09941d2ad9d37607b034788b6754 [^] Related to ISSUE-51153: Delete obsolete modulescript AlertMASequenceProduct That script only ran on updates before MP19. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It search for rows in MA_SEQUENCEPRODUCT table - But no sampledata ships rows in that table Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/AlertMASequenceProduct.class R src-util/modulescript/build/classes/org/openbravo/modulescript/AlertMASequenceProductData.class R src-util/modulescript/src/org/openbravo/modulescript/AlertMASequenceProduct.java R src-util/modulescript/src/org/openbravo/modulescript/AlertMASequenceProduct_data.xsql --- |
(0144895) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: db09ddcd5542c02e30e9d3dc1e3a87a0a71f4471 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/db09ddcd5542c02e30e9d3dc1e3a87a0a71f4471 [^] Related to ISSUE-51153: Delete obsolete modulescript InitializeAcctDimensionsInClient That script only ran on updates before MP22. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It search for ad_client entries for which no entry exists in ad_client_acctdimension table - 6 sampledata repos ship ad_client entries - However all 6 repos also ship rows in AD_CLIENT_ACCTDIMENSION table Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClient.class R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.class R src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.java R src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient.java R src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient_data.xsql --- |
(0144896) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 3f193f616e266c744b2dfe3aa11a9d7bd985eb6a Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3f193f616e266c744b2dfe3aa11a9d7bd985eb6a [^] Related to ISSUE-51153: Delete obsolete modulescript FixLedgerInMultiJournal That script only ran on updates before 15Q1. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It modifies rows in the GL_JOURNAL table - 4 sampledata ship rows in that table - 2 are covered by retail SampledataConsistency test (now showing any changes) - org.openbravo.retail.sampledata - org.openbravo.test.mobile.sampledata - 2 are in backoffice F_B_International_Group, QA_Testing and neither show changes when being exported now So the modulescript does not do any changes to sampledata during install.source Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/FixLedgerInMultiJournal.class R src-util/modulescript/build/classes/org/openbravo/modulescript/FixLedgerInMultiJournalData.class R src-util/modulescript/src/org/openbravo/modulescript/FixLedgerInMultiJournal.java R src-util/modulescript/src/org/openbravo/modulescript/FixLedgerInMultiJournal_data.xsql --- |
(0144897) hgbot (developer) 2022-12-21 13:30 |
Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 6c566a4acf93789734437a101504ea67d2c4224a Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 12:22:58 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/6c566a4acf93789734437a101504ea67d2c4224a [^] Related to ISSUE-51153: Delete obsolete modulescript DeleteDuplicateCommissionDetail That script only ran on updates before 15Q1. Issue 51068 blocks updates from <16Q1 causing it to never run on updates anymore. It did run during install.source but that is not needed: - It searches for and updates various C_COMISSION* tables - No sampledata is shipping any rows in C_COMMISSION Tables No sampledata is updated during install.source by it Remove it as obsolete. --- R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateCommissionDetail.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateCommissionDetailData.class R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateCommissionDetail.java R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateCommissionDetail_data.xsql --- |
(0144898) hgbot (developer) 2022-12-21 13:30 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/792 [^] |
(0144899) hgbot (developer) 2022-12-21 13:30 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 4a3ebb9382d7cdac0068b389ebefdfd73b9f59e8 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 21-12-2022 13:27:35 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/4a3ebb9382d7cdac0068b389ebefdfd73b9f59e8 [^] Fixes ISSUE-51153 Merge branch 'fix/51153-remove-obsolete-modulescripts-omni' --- R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue.class R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValueData.class R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue.class R modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValueData.class R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue.java R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValue_data.xsql R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue.java R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValue_data.xsql R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdatePaymentProcessedValueData.java R modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/src/org/openbravo/advpaymentmngt/modulescript/UpdateReconciliationProcessButtonValueData.java R src-util/modulescript/build/classes/org/openbravo/modulescript/AlertMASequenceProduct.class R src-util/modulescript/build/classes/org/openbravo/modulescript/AlertMASequenceProductData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLineForSequenceProduct.class R src-util/modulescript/build/classes/org/openbravo/modulescript/CreateLineForSequenceProductData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateCommissionDetail.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateCommissionDetailData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateMatchInvoice.class R src-util/modulescript/build/classes/org/openbravo/modulescript/DeleteDuplicateMatchInvoiceData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/FixLedgerInMultiJournal.class R src-util/modulescript/build/classes/org/openbravo/modulescript/FixLedgerInMultiJournalData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClient.class R src-util/modulescript/build/classes/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.class R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateCostingRulesWhenNotCalculatedCosts.class R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFinancialAccountAccounts.class R src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateFinancialAccountAccountsData.class R src-util/modulescript/build/javasqlc/src/org/openbravo/modulescript/InitializeAcctDimensionsInClientData.java R src-util/modulescript/src/org/openbravo/modulescript/AlertMASequenceProduct.java R src-util/modulescript/src/org/openbravo/modulescript/AlertMASequenceProduct_data.xsql R src-util/modulescript/src/org/openbravo/modulescript/CreateLineForSequenceProduct.java R src-util/modulescript/src/org/openbravo/modulescript/CreateLineForSequenceProduct_Data.xsql R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateCommissionDetail.java R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateCommissionDetail_data.xsql R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateMatchInvoice.java R src-util/modulescript/src/org/openbravo/modulescript/DeleteDuplicateMatchInvoice_data.xsql R src-util/modulescript/src/org/openbravo/modulescript/FixLedgerInMultiJournal.java R src-util/modulescript/src/org/openbravo/modulescript/FixLedgerInMultiJournal_data.xsql R src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient.java R src-util/modulescript/src/org/openbravo/modulescript/InitializeAcctDimensionsInClient_data.xsql R src-util/modulescript/src/org/openbravo/modulescript/UpdateCostingRulesWhenNotCalculatedCosts.java R src-util/modulescript/src/org/openbravo/modulescript/UpdateFinancialAccountAccounts.java R src-util/modulescript/src/org/openbravo/modulescript/UpdateFinancialAccountAccounts_data.xsql --- |
Issue History | |||
Date Modified | Username | Field | Change |
2022-12-14 14:40 | shuehner | New Issue | |
2022-12-14 14:40 | shuehner | Assigned To | => shuehner |
2022-12-14 14:40 | shuehner | Modules | => Core |
2022-12-14 14:40 | shuehner | Triggers an Emergency Pack | => No |
2022-12-14 14:40 | shuehner | Issue generated from | 0051152 |
2022-12-14 14:40 | shuehner | Relationship added | related to 0051152 |
2022-12-14 14:44 | hgbot | Note Added: 0144682 | |
2022-12-15 11:26 | shuehner | Relationship added | depends on 0051068 |
2022-12-21 13:30 | hgbot | Note Added: 0144888 | |
2022-12-21 13:30 | hgbot | Note Added: 0144889 | |
2022-12-21 13:30 | hgbot | Note Added: 0144890 | |
2022-12-21 13:30 | hgbot | Note Added: 0144891 | |
2022-12-21 13:30 | hgbot | Note Added: 0144892 | |
2022-12-21 13:30 | hgbot | Note Added: 0144893 | |
2022-12-21 13:30 | hgbot | Note Added: 0144894 | |
2022-12-21 13:30 | hgbot | Note Added: 0144895 | |
2022-12-21 13:30 | hgbot | Note Added: 0144896 | |
2022-12-21 13:30 | hgbot | Note Added: 0144897 | |
2022-12-21 13:30 | hgbot | Resolution | open => fixed |
2022-12-21 13:30 | hgbot | Status | new => closed |
2022-12-21 13:30 | hgbot | Fixed in Version | => PR23Q1 |
2022-12-21 13:30 | hgbot | Note Added: 0144899 | |
2022-12-21 13:30 | hgbot | Note Added: 0144898 | |
2023-07-21 16:13 | shuehner | Issue cloned | 0053029 |
2023-07-21 16:13 | shuehner | Relationship added | related to 0053029 |
Copyright © 2000 - 2009 MantisBT Group |