Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051142
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2022-12-13 15:532022-12-13 15:53
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051142: Remove 3 (nearly) unused pl's related to old-flow: c_debt_payment_status0, c_db_percentage_paid, c_invoice_percentage_paid

DescriptionThose 3 pl-functions are nearly unused.
- No references to any of the 3 are found in obx download from forge
- No reference except 1 case below is present in git master
- They have dependencies between each other (on issue if removed together)
- all three function only work with old-flow/pre-aprm

One file:
ReportProjectProfitabilityJR.jrxml has 2 references to C_invoice_percentage_paid inside the sql query present inside the jrxml file.
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.jrxml#L148 [^]

However the matching java servlet has its own query for data[] here
https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitabilityJR.java#L165 [^]

the xsql query here does NOT show any reference to c_invoice_percentage paid

https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/erpCommon/ad_reports/ReportProjectProfitability_data.xsql#L152 [^]

That looks like the jrxml select query is only useful for running inside iReport editor and is outdated compared to the version in the xsql being used.
Steps To Reproduce-
Proposed Solution- Review ReportProjectProfitabilityJR
- Update/fix or remove query inside jrxml to remove that last reference to c_invoice_percentage_paid function
- After that remove all 3 pl-function as obsolete
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks design defect 0050984 newshuehner Tracking issue: Remove obsolete old-flow / pre-aprm related code 

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2022-12-13 15:53 shuehner New Issue
2022-12-13 15:53 shuehner Assigned To => shuehner
2022-12-13 15:53 shuehner Modules => Core
2022-12-13 15:53 shuehner Triggers an Emergency Pack => No
2022-12-20 20:19 shuehner Relationship added blocks 0050984


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker