Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0051057
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Corecriticalhave not tried2022-11-30 14:302022-12-16 11:05
ReporterjarmendarizView Statuspublic 
Assigned Tojarmendariz 
PriorityhighResolutionfixedFixed in Version22Q4.1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0051057: Ticket should not be completed if businessPartner is missing

DescriptionIn normal circumstances, businessPartner info is always present but sometimes it is not and this causes the ticket is not removed from the ticket list, even if the payment is completed and the ticket is synchronized with the backoffice, leading to have multiple tickets with the same ID.
Steps To Reproduce- Apply the attached diff to force this error to happen.
- Once logged in to POS2, execute the following in the Chrome developer tools console:

# OB.App.TerminalProperty.get('context').forceFailure = true

- Refresh masterdata
- Add a product to the ticket and complete it. Notice that the ticket is saved in backoffice, but it is still available in the Terminal
TagsNo tags attached.
Attached Filesdiff file icon reproducer-51057.diff [^] (640 bytes) 2022-12-16 11:05 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0051041 closedjarmendariz Ticket should not be completed if businessPartner is missing 

-  Notes
(0144368)
hgbot (developer)
2022-12-02 13:44

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1402 [^]
(0144374)
hgbot (developer)
2022-12-02 14:31

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1005 [^]
(0144404)
hgbot (developer)
2022-12-05 10:42

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: e5404c7fd72c7edd7b3e0002bbf127bb34ba38ea
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 14:29:41
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/e5404c7fd72c7edd7b3e0002bbf127bb34ba38ea [^]

Related to ISSUE-51057: Throwing an error when attempting to create a new ticket with no business partner

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.posterminal/app/model/business-object/ticket-list/TicketListUtils.js
---
(0144405)
hgbot (developer)
2022-12-05 10:42

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1005 [^]
(0144406)
hgbot (developer)
2022-12-05 10:42

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1402 [^]
(0144407)
hgbot (developer)
2022-12-05 10:42

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 56ecf62a51dbee7c107307913d0a5af958e229c4
Author: Javier Armendáriz <javier.armendariz@openbravo.com>
Date: 02-12-2022 13:43:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/56ecf62a51dbee7c107307913d0a5af958e229c4 [^]

Fixed ISSUE-51057: Adding action preparation to ensure ticket is not completed if BP is missing

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketUtils.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/CompleteTicketActionPreparation.js
M web-jspack/org.openbravo.pos2/src/ob-init.js
---
(0144560)
hgbot (developer)
2022-12-13 07:41

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1014 [^]
(0144625)
hgbot (developer)
2022-12-14 09:07

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^]
Changeset: 43d2a977bf05387d55aa98f4067b518efd34b781
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 13-12-2022 11:37:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/43d2a977bf05387d55aa98f4067b518efd34b781 [^]

Related to ISSUE-51057: BP Info should be updated before window is loaded
* BP Info should be updated in OBPOS_LoadPOSWindow hook
  before loading window

---
A web/org.openbravo.retail.posterminal/js/hook/loadPOSWindow.js
M src/org/openbravo/retail/posterminal/OBPOSComponentProvider.java
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
M web/org.openbravo.retail.posterminal/js/utils/ticketListUtils.js
---
(0144626)
hgbot (developer)
2022-12-14 09:07

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/1014 [^]

- Issue History
Date Modified Username Field Change
2022-12-02 12:20 jarmendariz Type defect => backport
2022-12-02 12:20 jarmendariz Target Version => 22Q4.1
2022-12-02 13:44 hgbot Note Added: 0144368
2022-12-02 14:31 hgbot Note Added: 0144374
2022-12-05 10:42 hgbot Note Added: 0144404
2022-12-05 10:42 hgbot Note Added: 0144405
2022-12-05 10:42 hgbot Resolution open => fixed
2022-12-05 10:42 hgbot Status scheduled => closed
2022-12-05 10:42 hgbot Note Added: 0144406
2022-12-05 10:42 hgbot Fixed in Version => 22Q4.1
2022-12-05 10:42 hgbot Note Added: 0144407
2022-12-13 07:41 hgbot Note Added: 0144560
2022-12-14 09:07 hgbot Note Added: 0144625
2022-12-14 09:07 hgbot Note Added: 0144626
2022-12-16 11:05 jarmendariz File Added: reproducer-51057.diff


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker