Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050922 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Openbravo ERP] A. Platform | critical | have not tried | 2022-11-16 16:27 | 2022-11-18 09:23 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | AugustoMauch | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | PR22Q4.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | PR22Q4.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | 2022-10-31 | |||||||
| Regression introduced in release | PR22Q3.2 | |||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050922: Filter in valid tree structure results in message related to cycles in the hierarchy | |||||||
| Description | In this issue [1] we tried to handle properly the filter behaviour when there are cycles in the hierarchy of the data being fetched. That fix has a bug that results in cycles being detected if the filtered text is present in a child node and one of its ancestors [1] https://issues.openbravo.com/view.php?id=50549 [^] | |||||||
| Steps To Reproduce | - Log in in the openbravo backoffice - Change to a System Administrator role - Open the Menu window - Click the Tree button to show the tree grid view - In the Name column enter the text "User" (without the quotes). An error related to data cycles is displayed, but there are no cycles in the hierarchy | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0143805) hgbot (developer) 2022-11-17 20:13 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/770 [^] |
|
(0143811) hgbot (developer) 2022-11-18 09:23 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/770 [^] |
|
(0143812) hgbot (developer) 2022-11-18 09:23 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: d05adc75f38ccbba39aeb343bf6f0df3527ffdc2 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 17-11-2022 20:13:12 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/d05adc75f38ccbba39aeb343bf6f0df3527ffdc2 [^] Fixes ISSUE-50922: Data cycles are now properly detected in TreeDatasourceService The problem was that we were not properly checking the presence of data cycles. When filtering a node, we want to include also all its ancestors. When looking for cycles, instead of looking for repeated nodes in the ancestor list, we were looking for repeated nodes in the list of nodes that were going to be returned, that contains all the nodes that match the filter plus its ancestors. --- M modules/org.openbravo.service.datasource/src/org/openbravo/service/datasource/TreeDatasourceService.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-11-16 16:32 | AugustoMauch | Type | defect => backport |
| 2022-11-16 16:32 | AugustoMauch | Target Version | => PR22Q4.1 |
| 2022-11-17 20:13 | hgbot | Note Added: 0143805 | |
| 2022-11-18 09:23 | hgbot | Resolution | open => fixed |
| 2022-11-18 09:23 | hgbot | Status | scheduled => closed |
| 2022-11-18 09:23 | hgbot | Note Added: 0143811 | |
| 2022-11-18 09:23 | hgbot | Fixed in Version | => PR22Q4.1 |
| 2022-11-18 09:23 | hgbot | Note Added: 0143812 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |