Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050873
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformcriticalhave not tried2022-11-14 10:002022-11-14 15:43
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in VersionPR22Q4.1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget VersionPR22Q4.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050873: Timeout of Openbravo standard session is set to very low value if a request to a webservice is done using that session

DescriptionIn Openbravo there are at least two different session timeout configurations:
- For standard session the value defined in the session-timeout context parameter is used (default: 60 minutes) [1]
- For webservice sessions the timeout is defined to a much smaller value (default: 60 seconds) [2]

The problem is that within a standard Openbravo session a request is done to a webservice endpoint, the timeout of the standard session will be set to the timeout of webservice sessions (60 seconds). We should only do that if the session was created as a result of the the webservice request.


[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-db/database/sourcedata/AD_MODEL_OBJECT_PARA.xml#L255 [^]
[2] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src/org/openbravo/service/web/BaseWebServiceServlet.java#L133 [^]
Steps To Reproduce- Login in the Openbravo backoffice, i.e. https://livebuilds.openbravo.com/erp_pi_pgsql [^]
- Do not interact with the backoffice for two minutes and then try to open any window (i.e. Sales Order). This will work as expected because the timeout for standard sessions is longere
- Within that session make a request to a webservice (i.e. by entering this in the browser url input: https://livebuilds.openbravo.com/erp_pi_pgsql/org.openbravo.service.json.jsonrest/Country [^])
- Wait for a couple of minutes and try to open any window. You will not be able because the session will have expired
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0050872 closedAugustoMauch Timeout of Openbravo standard session is set to very low value if a request to a webservice is done using that session 

-  Notes
(0143511)
hgbot (developer)
2022-11-14 11:41

Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/760 [^]
(0143576)
hgbot (developer)
2022-11-14 15:43

Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/760 [^]
(0143577)
hgbot (developer)
2022-11-14 15:43

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 706dc417555373acf7af7d6100167ea554a3f247
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 14-11-2022 11:40:48
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/706dc417555373acf7af7d6100167ea554a3f247 [^]

Fixes ISSUE-50873: ws request should not update inactive interval in standard sessions

Sessions created as a result of webservice requests are supposed to expire before standard sessions (1 minute vs 60 minutes by default). To force the shorter
expiration date of webservice sessions, the max inactive timeout was set to the smaller value each time a request to a webservice is received.

The problem is that if the request to the webservice was done as part of a standard session, we were making the standard session short lived as well, and that
was not supposed to happen.

To fix this, now the max inactive timeout is given a small value only if the session was created as a result of the webservice request

---
M src/org/openbravo/service/web/BaseWebServiceServlet.java
---

- Issue History
Date Modified Username Field Change
2022-11-14 10:01 AugustoMauch Type defect => backport
2022-11-14 10:01 AugustoMauch Target Version => PR22Q4.1
2022-11-14 11:41 hgbot Note Added: 0143511
2022-11-14 15:43 hgbot Note Added: 0143576
2022-11-14 15:43 hgbot Resolution open => fixed
2022-11-14 15:43 hgbot Status scheduled => closed
2022-11-14 15:43 hgbot Fixed in Version => PR22Q4.1
2022-11-14 15:43 hgbot Note Added: 0143577


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker