Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050856
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementminoralways2022-11-11 12:162023-02-21 09:43
ReporterXABIER_AGUADOView Statuspublic 
Assigned ToAtulOpenbravo 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050856: The scan behaviour for DO is not very clear, should behave like IC

DescriptionWhen the scan is not successful for a DO(product not in the product repository for instance):

A pop-up notification appears in green at top right of the screen

The “Scan” icon is in red but we can not access it (by clicking on it) to have details (like in the “Count”).

This is confusing for the user, the notification should be readable and shown in red when the scan is not successful + the scan icon should be clickable and showing details about the scan failure, like it currently behaves for IC.
Steps To ReproduceLog in on AWO
On the menu select distribution order
Select a warehouse and a BIN
Once on the DO main screen scan a real EAN. I.E: 36071716318107
A pop-up notification appears in green at top right of the screen
Scan a fake EAN: 360X7171631810
A pop-up notification appears in green at top right of the screen
Proposed SolutionThe notification should appear clearly to user in order to inform that there was a problem in the scan (product not existing for instance) The notification should be in Red warning the user about the scan failure.
The scan icon should be in red and Clickable showing the details about the scan failure like in the Count window
TagsFASH
Attached Filespng file icon Screenshot 2022-11-11 121628.png [^] (10,492 bytes) 2022-11-11 12:16

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0146304)
mtaal (manager)
2023-02-09 12:11

 Point 1:

In obawo-utils.js, every time we scan a code, a success message is shown along with the scanned code irrespective of the whether it is a success or failure.

OBAWO.Utils.globalKeypressHandler = function(inSender, inEvent) {
  var which = inEvent.keyboardEvent.which;
  var keeper = document.getElementById('_focusKeeper');
  var scanedCode;
  OB.debug('[mgscan] globalKeyPressHandler which is ' + which);
  if (OB.MobileApp.view.scanMode && OB.MobileApp.model.get('useBarcode')) {
    // scanning using focusKeeper, take the value in the focusKeeper
    // some scanners do not send events for each character, that's why
    // the whole contents of focusKeeper are taken
    if (keeper && which === 13) {
      OB.info(
        '[mgscan] globalKeyPressHandler enter key registered, keeper value is: ' +
          keeper.value
      );
      if (keeper.value && keeper.value.length > 0) {
        scanedCode = keeper.value;
        OB.UTIL.showSuccess(OB.I18N.getLabel('OBAWO_Scanned', [scanedCode]));
        keeper.value = '';
        if (inEvent && inEvent.callback) {
          inEvent.callback(scanedCode);
        }
      }
    }
  }
};

If we remove this line then we are able to see properly the red and green colour for scan button in case of invalid or valid scan code respectively.
Attached are the videos from Inventory Count and Distribution Order screens. [50586_DistributionOrder.webm, 50586_InventoryCount.webm] Problem was that red icon code gets hide behind the success notification in the above code hence it is not visible to user. If we remove the line then the icon is visible properly as shown in the attached videos. [After50586_InventoryCount.webm, After50586_DistributionOrder.webm]

I am not sure about this solution whether this would be correct way to fix this or adjust some UI to move the scan icon in DO screen so it is visible clearly.
Please suggest.

Point 2: The scan button was disabled in obawo-distributionorder-view.js i.e
this.$.scanButton.setDisabled(true);
mentioning FIXME: Disable till Create Box, Confirm Box and Scan functionality are developed

If we remove the above line, scan history is properly shown in a popup as in the Inventory Count screen.
(0146429)
AtulOpenbravo (developer)
2023-02-13 11:26

 Test Plan

- Log in on AWO Front End
- Navigate to the menu: Distribution Order
- Select a warehouse and a bin
- In DO main screen scan product with valid EAN. For eg: 1234
- A pop-up notification appears in green at top right of the screen
- Scan a invalid EAN: For eg: 9876
- A pop-up notification appears in green at top right of the screen and scan button is highlighted with red color.
- Realize that scan button is clickable and opens up a pop up with scan history.
(0146430)
hgbot (developer)
2023-02-13 11:30

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/44 [^]
(0146804)
hgbot (developer)
2023-02-21 09:43

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders [^]
Changeset: 6fe64f2da306ebbb884d3b3f7f22172ba4be4cf7
Author: Atul Gaware <atul.gaware@openbravo.com>
Date: 21-02-2023 08:42:54
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/commit/6fe64f2da306ebbb884d3b3f7f22172ba4be4cf7 [^]

Fixes BUG-0050856: The scan behaviour for DO is not very clear,
should behave like IC

**Scan button is enabled in DO screen to show the scan history in
popup

---
M web/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/source/obawo-distributionorder-view.js
---
(0146805)
hgbot (developer)
2023-02-21 09:43

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.warehouse.advancedwarehouseoperations.distributionorders/-/merge_requests/44 [^]

- Issue History
Date Modified Username Field Change
2022-11-11 12:16 XABIER_AGUADO New Issue
2022-11-11 12:16 XABIER_AGUADO Assigned To => Triage Omni WMS
2022-11-11 12:16 XABIER_AGUADO File Added: Screenshot 2022-11-11 121628.png
2022-11-11 12:16 XABIER_AGUADO Modules => Core
2022-11-11 12:16 XABIER_AGUADO Triggers an Emergency Pack => No
2022-11-11 12:16 XABIER_AGUADO Tag Attached: FASH
2022-11-11 12:31 XABIER_AGUADO Type feature request => defect
2022-11-11 12:32 XABIER_AGUADO Summary The scan failure notification is not very clear => The scan behaviour is not very clear
2022-11-11 12:32 XABIER_AGUADO Proposed Solution updated
2022-11-14 13:09 XABIER_AGUADO Summary The scan behaviour is not very clear => The scan behaviour for DO is not very clear, should behave like IC
2022-11-14 13:09 XABIER_AGUADO Description Updated View Revisions
2022-11-14 13:09 XABIER_AGUADO Proposed Solution updated
2023-02-09 12:11 mtaal Assigned To Triage Omni WMS => AtulOpenbravo
2023-02-09 12:11 mtaal Note Added: 0146304
2023-02-13 11:16 AtulOpenbravo Status new => scheduled
2023-02-13 11:26 AtulOpenbravo Note Added: 0146429
2023-02-13 11:30 hgbot Note Added: 0146430
2023-02-21 09:43 hgbot Resolution open => fixed
2023-02-21 09:43 hgbot Status scheduled => closed
2023-02-21 09:43 hgbot Note Added: 0146804
2023-02-21 09:43 hgbot Note Added: 0146805

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker