Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050765 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [POS2] Restaurants | minor | have not tried | 2022-11-07 17:55 | 2022-11-14 12:44 | |||
| Reporter | guilleaer | View Status | public | |||||
| Assigned To | Retail | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 22Q4.1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | 22Q4.1 | |||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050765: Abort Product Configuration confirmation popup does not allow do do a correct translation | |||||||
| Description | Abort Product Configuration confirmation popup does not allow do do a correct translation The problem is the following: Translating to french cancel is translated to Annuler <row id="32360CCD780547EB9E2610F3D38BE46E" trl="Y"> <value column="MsgText" isTrl="Y" original="Cancel">Annuler</value> <value column="MsgTip" isTrl="N" original=""/> </row> abort → Annuler <row id="E9A9F7E825AB4025805763BE7616CA4D" trl="Y"> <value column="MsgText" isTrl="Y" original="Abort">Annuler</value> <value column="MsgTip" isTrl="N" original=""/> </row> In this specific context it leads in a dialog with 2 buttons with same text To properly define an specific text for this flow I suggest to use an specific label for cancel instead of use the generic one by adding a new parameter to the dialog (https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/a5f744b3b228691ad1daa2c97d52788fe8b84c8e/web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js#L37 [^]) cancelLabel: '$OBPOS2_StopCancellationOfProductConfiguration' This Message in english will remain as “cancel” but we allow to change it for other languages. in french someone should find the proper word to describe the action to “cancel” the “abort” | |||||||
| Steps To Reproduce | Assign a modifier to a product in POS2 and try to "Abort" it | |||||||
| Proposed Solution | Cancel button in this dialog should not be the generic label. A new one should be created to allow to create a custom translation | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0143371) hgbot (developer) 2022-11-10 11:41 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1352 [^] |
|
(0143559) hgbot (developer) 2022-11-14 12:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1352 [^] |
|
(0143560) hgbot (developer) 2022-11-14 12:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 4db8462b00cc4185c9e1cb8278622d812b773a9e Author: Eduardo Becerra (OB) <eduardo.becerra@openbravo.com> Date: 14-11-2022 11:44:44 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/4db8462b00cc4185c9e1cb8278622d812b773a9e [^] Fixes ISSUE-50765: Abort Product Configuration confirmation popup does not... --- M src-db/database/sourcedata/AD_MESSAGE.xml M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/FinishProductConfigurationStep.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-11-07 17:57 | guilleaer | Type | defect => backport |
| 2022-11-07 17:57 | guilleaer | Target Version | => 22Q4.1 |
| 2022-11-10 11:41 | hgbot | Merge Request Status | => open |
| 2022-11-10 11:41 | hgbot | Note Added: 0143371 | |
| 2022-11-13 08:52 | hgbot | Merge Request Status | open => approved |
| 2022-11-13 08:56 | hgbot | Merge Request Status | approved => open |
| 2022-11-14 12:44 | hgbot | Merge Request Status | open => approved |
| 2022-11-14 12:44 | hgbot | Resolution | open => fixed |
| 2022-11-14 12:44 | hgbot | Status | scheduled => closed |
| 2022-11-14 12:44 | hgbot | Note Added: 0143559 | |
| 2022-11-14 12:44 | hgbot | Fixed in Version | => 22Q4.1 |
| 2022-11-14 12:44 | hgbot | Note Added: 0143560 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |