Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050721
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2022-11-03 12:552022-11-08 08:02
ReportercaristuView Statuspublic 
Assigned Toalostale 
PriorityhighResolutionfixedFixed in VersionPR23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050721: Compilation should fail if a merged module is present in the modules source folder

DescriptionCompilation should fail if a merged module is present in the modules source folder
Steps To Reproduce1) Install the following module in a clean pi environment[1]. Note that this module is already merged in org.openbravo.v3 module.
2) Run ant smartbuild -Dlocal=no. The compilation finishes successfully.

[1] https://gitlab.com/openbravo/product/unsupported/modules/org.openbravo.financial.cashflowforecast [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 0035130 closedrqueralta Openbravo ERP Integrate module Cashflow Forecast into Openbravo 3 distribution 
related to feature request 00350893.0PR17Q2 closednonofrancisco Openbravo ERP Integrate module Aging Balance Report into Openbravo 3 distribution 
related to design defect 0049908 closedranjith_qualiantech_com POS2 Remove incorrect implicit dependency on bytotal module 

-  Notes
(0142885)
alostale (manager)
2022-11-03 13:23

 Note there is already some build validation [1] that is partially implementing it. It checks a (outdated?) list of modules merged in OB3 distro, but it does not take into account any other.

Could we change this so it checks any merged module?

---
[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java [^]
(0143128)
hgbot (developer)
2022-11-07 09:08

 Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/750 [^]
(0143202)
hgbot (developer)
2022-11-08 07:55

 Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/750 [^]
(0143203)
hgbot (developer)
2022-11-08 07:55

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: cec5c25a21149c67cfd918f00ee32858008e1d16
Author: Asier Lostalé <asier.lostale@openbravo.com>
Date: 08-11-2022 06:55:54
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/cec5c25a21149c67cfd918f00ee32858008e1d16 [^]

fixes ISSUE-50721: can update database having merged modules

When updating database, it was not checked merged modules are not present as
sources. If a module is merged in another one, a validation should prevent
updating database until the merged module is uninstalled.

There was a buildvalidation to perform this, but it was partial. It has been
changed to:

  * Be generic, before only a set of "known" merges was checked.
  * Execute always, before only when updaing from <=17Q1 was executed

---
A src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$Module.class
M src-util/buildvalidation/build.xml
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$1.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck$MergedModule.class
M src-util/buildvalidation/build/classes/org/openbravo/buildvalidation/MergeDependenciesCheck.class
M src-util/buildvalidation/src/org/openbravo/buildvalidation/MergeDependenciesCheck.java
---

- Issue History
Date Modified Username Field Change
2022-11-03 12:55 caristu New Issue
2022-11-03 12:55 caristu Assigned To => Triage Platform Base
2022-11-03 12:55 caristu Modules => Core
2022-11-03 12:55 caristu Triggers an Emergency Pack => No
2022-11-03 13:23 alostale Note Added: 0142885
2022-11-07 09:08 hgbot Note Added: 0143128
2022-11-07 15:48 alostale Relationship added related to 0049908
2022-11-08 07:55 hgbot Note Added: 0143202
2022-11-08 07:55 hgbot Resolution open => fixed
2022-11-08 07:55 hgbot Status new => closed
2022-11-08 07:55 hgbot Fixed in Version => PR23Q1
2022-11-08 07:55 hgbot Note Added: 0143203
2022-11-08 07:56 alostale Assigned To Triage Platform Base => alostale
2022-11-08 08:02 caristu Relationship added related to 0035130
2022-11-08 08:02 caristu Relationship added related to 0035089

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker