Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050634
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] Coremajoralways2022-10-25 16:272022-11-30 07:36
ReporterhbrasmeView Statuspublic 
Assigned Toranjith_qualiantech_com 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product Version22Q3SCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerGold
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050634: [PROMO] The price adjustment discount has different behavior if a % or an amount is defined

DescriptionThe price adjustment discount type has a different behavior depend on if the defined discount is a % or an amount. See image 'User Cases Comparation'.
 
User Case 1 (% + isMul=No) and User Case 3 (Amt + isMul=No) → same behaviour where there are several lines in the ticket, the discount is splitted by line.

User Case 2 (% + isMul=Yes) and User Case 4 (Amt + isMul=Yes) → different behaviour where there are several lines in the ticket

- For User Case 2 → The double of the defined discount is applied per each line. KO

- For User Case 4 → The discount is splitted by line. OK
Steps To ReproduceCreate two PriceAdjustment Promotions:
*User Case 2 (% + isMul=Yes)
*User Case 4 (Amt + isMul=Yes)


On the POS2
*Create a ticket for which the User Case 2 applies in several lines --> The double of the defined discount is applied per each line.
*Create a ticket for which the User Case 4 applies in several lines --> the discount is spplited by line.


Steps to reproduce in livebuilds
Backoffice
1) Create discount with type "Price Adjustment", Discount % as "10", Is Multiple as "checked", Units per package as "2"
POS
1) Add 4 Products.
2) Discount is correct applied - OK
3) Split receipt line into 4 lines
4) Discount is not correct applied - KO
Same problem will occur for ungrouped products
Proposed SolutionThe price adjustment discount type must work in the same way regardless a % discount or an amount discount will be defined in both cases:
*Is Multiple=Yes
*Is Multiple=No
TagsFASH
Attached Filespng file icon User Cases Comparation.png [^] (214,697 bytes) 2022-10-27 16:20

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0143304)
hgbot (developer)
2022-11-09 13:52

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/71 [^]
(0144236)
hgbot (developer)
2022-11-30 07:36

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/71 [^]
(0144237)
hgbot (developer)
2022-11-30 07:36

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^]
Changeset: 750022ee8483de1dec962153413fa92e5079a084
Author: Ranjith S R <ranjith@qualiantech.com>
Date: 30-11-2022 06:36:19
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/750022ee8483de1dec962153413fa92e5079a084 [^]

Fixed ISSUE-50634: Discount Amount should be updated based on chunks of discount
* If discount is configured with multiple unit per package,
  then discount amount should be updated with number of packages applied

---
M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/rules/price-adjustment-discount.js
---

- Issue History
Date Modified Username Field Change
2022-10-25 16:27 hbrasme New Issue
2022-10-25 16:27 hbrasme Assigned To => Triage Platform Base
2022-10-25 16:27 hbrasme File Added: 2141 - Result Grouped Product.png
2022-10-25 16:27 hbrasme Triggers an Emergency Pack => No
2022-10-25 16:27 hbrasme File Added: 2141 - Result Split Product.png
2022-10-25 16:34 rafaroda Tag Attached: FASH
2022-10-25 16:39 rafaroda OBNetwork customer => Gold
2022-10-25 17:29 avicente Priority normal => high
2022-10-25 17:36 avicente Issue Monitored: avicente
2022-10-26 08:43 hbrasme Note Added: 0142586
2022-10-27 15:42 avicente Summary [PROMO] - Advantages - No split of the discount amount if several quantities of the same item => [PROMO] The price adjustment discount has different behavior if a % or an amount is defined
2022-10-27 15:42 avicente Description Updated View Revisions
2022-10-27 15:42 avicente Steps to Reproduce Updated View Revisions
2022-10-27 15:42 avicente Proposed Solution updated
2022-10-27 16:20 avicente Description Updated View Revisions
2022-10-27 16:20 avicente Steps to Reproduce Updated View Revisions
2022-10-27 16:20 avicente File Added: User Cases Comparation.png
2022-10-27 16:35 marvintm Assigned To Triage Platform Base => Triage Omni OMS
2022-10-31 10:24 avicente Note Deleted: 0142586
2022-10-31 10:24 avicente File Deleted: 2141 - Result Split Product.png
2022-10-31 10:24 avicente File Deleted: 2141 - Result Grouped Product.png
2022-11-02 09:46 marvintm Assigned To Triage Omni OMS => Retail
2022-11-02 11:03 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2022-11-02 11:03 ranjith_qualiantech_com Status new => scheduled
2022-11-09 13:50 ranjith_qualiantech_com Steps to Reproduce Updated View Revisions
2022-11-09 13:52 hgbot Merge Request Status => open
2022-11-09 13:52 hgbot Note Added: 0143304
2022-11-30 07:36 hgbot Merge Request Status open => approved
2022-11-30 07:36 hgbot Resolution open => fixed
2022-11-30 07:36 hgbot Status scheduled => closed
2022-11-30 07:36 hgbot Note Added: 0144236
2022-11-30 07:36 hgbot Fixed in Version => RR23Q1
2022-11-30 07:36 hgbot Note Added: 0144237

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker