Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050554
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[POS2] Corecriticalsometimes2022-10-17 11:302022-11-07 13:55
ReporterAugustoMauchView Statuspublic 
Assigned Tocberner 
PrioritynormalResolutionfixedFixed in Version22Q3.2
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version22Q3.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050554: Unexpected management of error leads to state inconsistency

DescriptionWe have noticed that if there is an error during the execution of a state action, sometimes that error is not properly managed.

For instance, both the DeleteTicket and the CompleteTicket action execute the newTicket function to create a new ticket after deleting/completing the current one. Note that both action will send a synchronization message to the backend to create an order (with qty 0 if the order was deleted).

If we force an error on the newTicket function (i.e. by executing null.x) one of these two secuences of events will take place:
- The error will be logged in in the console, in the terminal log and in a notification to the user. The state remains as it was before the action was executed, the ticket is still displayed to the user. No synchronization message is sent to the backend, no order is created.
- The error is not logged anywhere (console, terminal log, notification). The state remains as it was before the action was executed, the ticket is still displayed to the user. A synchronization message is sent to the backend, an order will be created.

The second case only happens rarely, but when it does it will result on duplicated tickets being sent to the backend, because if the user is still working in the frontend with a ticket that has already been processed in the backend.
Steps To ReproduceTO BE DONE
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0050552 closedcberner Cashup is not properly persisted between a day and the next 

-  Notes
(0142657)
hgbot (developer)
2022-10-27 13:34

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1321 [^]
(0142661)
hgbot (developer)
2022-10-27 13:59

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 0394e3ac2430e8032ddbfe07aec14768da9f3566
Author: Cristian Berner <cristian.berner@openbravo.com>
Date: 27-10-2022 13:33:33
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0394e3ac2430e8032ddbfe07aec14768da9f3566 [^]

Fixes ISSUE-50554: Add missing awaits for cashup posthooks and some extra log

Adds useful log on entering the logout user-action and when finishing it, the current state
cashup id and the previously persisted one are logged.

---
M web-jspack/org.openbravo.pos2/src/model/session/Session.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/__test__/FinishCashupUserAction.test.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/CashupUtils.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/cashup/FinishCashup.js
M web-jspack/org.openbravo.pos2/src/model/user-interface/user-actions/initialCount/ClearInitialCountInProgress.js
---
(0142662)
hgbot (developer)
2022-10-27 13:59

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1321 [^]

- Issue History
Date Modified Username Field Change
2022-10-17 11:30 AugustoMauch Type defect => backport
2022-10-17 11:30 AugustoMauch Target Version => 22Q3.2
2022-10-27 13:34 hgbot Merge Request Status => open
2022-10-27 13:34 hgbot Note Added: 0142657
2022-10-27 13:58 hgbot Merge Request Status open => approved
2022-10-27 13:59 hgbot Resolution open => fixed
2022-10-27 13:59 hgbot Status scheduled => closed
2022-10-27 13:59 hgbot Fixed in Version => 22Q3.2
2022-10-27 13:59 hgbot Note Added: 0142661
2022-10-27 13:59 hgbot Note Added: 0142662
2022-11-07 13:55 cberner Assigned To Triage Platform Base => cberner

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker