Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050542 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | critical | have not tried | 2022-10-17 09:56 | 2022-10-24 17:33 | |||
| Reporter | AugustoMauch | View Status | public | |||||
| Assigned To | jarmendariz | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050542: Memory leak in the Keymap Editor | |||||||
| Description | There is a memory leak in the keymap editor, specifically in the window that allows to define the layout of a given keymap. Each time a different vale is chosen from the screen resolution combo, the keymap is recomputed but the previos one does not seem to be removed from memory | |||||||
| Steps To Reproduce | - Create a big keymap with lots of products - Open the chrome Task Manager (shift+esc) to monitor the memory usage - Open the Keymap Editor, select the big keymap and go to the step that allows to update the layout. - Modify the selected screen resolution several times and notice how the memory usage keeps increasing | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0142339) hgbot (developer) 2022-10-20 12:20 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1298 [^] |
|
(0142493) hgbot (developer) 2022-10-24 17:33 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1298 [^] |
|
(0142494) hgbot (developer) 2022-10-24 17:33 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 0b574746f93649ec474b6ec986ced795f8f3bf68 Author: Javier Armendáriz <javier.armendariz@openbravo.com> Date: 24-10-2022 17:15:31 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/0b574746f93649ec474b6ec986ced795f8f3bf68 [^] Fixed ISSUE-50542: Memory leaks in the Keymap Editor This changeset fixes two types of memory leaks: 1- When cloning the editableLayoutRefs object in KeyMapCategoriesGrid, we copied the whole ref instead of the current property, creating a nested structure like { current: { current: { current: ... }}} 2- If we add an event listener on an useEffect hook of a component, we should create a cleanup function that removes that listener when the component unloads --- M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapCategoriesGrid/KeyMapCategoriesGrid.jsx M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapProductsGrid/KeyMapProductsGrid.jsx M web-jspack/org.openbravo.pos2/src/components/ProductCategoryButton/ProductCategoryButton.jsx M web-jspack/org.openbravo.pos2/src/components/ProductSearch/AvailableProductFilterButtonContent/AvailableProductFilterButtonContent.jsx --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-17 09:56 | AugustoMauch | New Issue | |
| 2022-10-17 09:56 | AugustoMauch | Assigned To | => jarmendariz |
| 2022-10-17 09:56 | AugustoMauch | OBNetwork customer | => No |
| 2022-10-17 09:56 | AugustoMauch | Triggers an Emergency Pack | => No |
| 2022-10-17 09:56 | AugustoMauch | Status | new => scheduled |
| 2022-10-20 12:20 | hgbot | Merge Request Status | => open |
| 2022-10-20 12:20 | hgbot | Note Added: 0142339 | |
| 2022-10-24 17:30 | hgbot | Merge Request Status | open => approved |
| 2022-10-24 17:33 | hgbot | Resolution | open => fixed |
| 2022-10-24 17:33 | hgbot | Status | scheduled => closed |
| 2022-10-24 17:33 | hgbot | Note Added: 0142493 | |
| 2022-10-24 17:33 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-24 17:33 | hgbot | Note Added: 0142494 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |