Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050471 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-10-10 14:51 | 2022-10-24 11:55 | |||
| Reporter | cberner | View Status | public | |||||
| Assigned To | cberner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050471: Service products marked as grouped are incorrectly separated into new lines when added to the ticket | |||||||
| Description | Service products should keep their grouping rules when added to the ticket, except if they have modifiers or beeper configuration, that's the only case when we need to force them to be non-grouped, when not in this case it should follow normal ruling and be grouped if configured as so. To allow this, ProductConfiguration should be extended to accept some info regarding if the checked rule is or not a valid one to force non-grouped lines on applicable products. | |||||||
| Steps To Reproduce | 1. Open WebPOS and login 2. Search product Basecamp Lamp, try to add several of them to the ticket Check that each one is on one line. They should be together, as they are marked as a grouped product. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0141917) hgbot (developer) 2022-10-10 15:00 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1266 [^] |
|
(0142451) hgbot (developer) 2022-10-24 11:55 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1266 [^] |
|
(0142452) hgbot (developer) 2022-10-24 11:55 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: f292ded45dae4fb0be78093784f7d99ea3e52065 Author: Cristian Berner <cristian.berner@openbravo.com> Date: 24-10-2022 09:54:59 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/f292ded45dae4fb0be78093784f7d99ea3e52065 [^] Fixes ISSUE-50471: Service products marked as grouped are incorrectly separated into new lines ProductConfiguration rules have been extended by adding a new options key. Under this key, it is possible to add an object with different properties. forceNewLine is one of this properties, when set to false(by default true) it will not separate each new order-line into its own line if not configured as so. As part of this fix, all hooks from AddProduct have been extracted from the AddProduct.js file and moved to AddProductHooks.js file, with the goal to test them in AddProductHooks.test.js. --- A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProductHooks.js A web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/__test__/AddProductHooks.test.js M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ProductConfiguration.js M web-jspack/org.openbravo.pos2/src/configurations/product-configuration/ServiceConfiguration.js M web-jspack/org.openbravo.pos2/src/model/ticket/user-actions/AddProduct.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-10 14:51 | cberner | New Issue | |
| 2022-10-10 14:51 | cberner | Assigned To | => cberner |
| 2022-10-10 14:51 | cberner | OBNetwork customer | => No |
| 2022-10-10 14:51 | cberner | Triggers an Emergency Pack | => No |
| 2022-10-10 15:00 | hgbot | Merge Request Status | => open |
| 2022-10-10 15:00 | hgbot | Note Added: 0141917 | |
| 2022-10-24 10:35 | hgbot | Merge Request Status | open => approved |
| 2022-10-24 11:55 | hgbot | Resolution | open => fixed |
| 2022-10-24 11:55 | hgbot | Status | new => closed |
| 2022-10-24 11:55 | hgbot | Note Added: 0142451 | |
| 2022-10-24 11:55 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-24 11:55 | hgbot | Note Added: 0142452 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |