Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050461
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2022-10-10 10:532022-10-18 00:45
Reporterasier_perezView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression levelAutomated tests
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050461: Marking a product to be returned and then adding the same product does not work

DescriptionWhen a product in a ticket is marked as to be returned, it should have its price in negative. Then, when adding a unit of the same product to that ticket, the negative price and the new positive one should add together, making the total to equal 0, and both products should appear in the ticket. Instead, there is an error (see the attached screenshot), and the positive product does not appear in the ticket.
Steps To Reproduce1) Log in POS2
2) In the Initial Count screen, click Finish
3) Click on Avalanche Transceiver to add it to the ticket
4) Click on the Avalanche Transceiver line that has been added to the ticket
5) In the pop up, select Return Line
6) Click anywhere out of the pop up to close it
7) Repeat the 3rd step
TagsNo tags attached.
Attached Filespng file icon returnOrderError.png [^] (139,756 bytes) 2022-10-10 10:53

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0141929)
dbaz (developer)
2022-10-10 17:31

The proper behavior is neither the one it was before this issue. It should be the one in old POS, so, if we have a return order-line, when adding a new product, same as the orderline, it will add the product on a separate positive order line.
(0141973)
hgbot (developer)
2022-10-11 15:17

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1268 [^]
(0142145)
hgbot (developer)
2022-10-17 12:54

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1268 [^]
(0142146)
hgbot (developer)
2022-10-17 12:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ad818c3c8fbc5f2a7fd740ed1938a7985dbedd82
Author: Martin Taal <martin.taal@openbravo.com>
Date: 17-10-2022 10:54:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ad818c3c8fbc5f2a7fd740ed1938a7985dbedd82 [^]

Fixed ISSUE-50461: prevent js error in print options, use more criteria to find current line to add to

---
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddPrintOptions.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0142147)
hgbot (developer)
2022-10-17 12:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 184b06d9dd196f1c8ff4c6b45dc808fe70ce94e0
Author: Martin Taal <martin.taal@openbravo.com>
Date: 17-10-2022 10:54:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/184b06d9dd196f1c8ff4c6b45dc808fe70ce94e0 [^]

Fixed ISSUE-50461: use full getlinetoedit logic in pos2, do schema preparation late in the preparation flow

---
M web-jspack/org.openbravo.pos2/src/model/ticket/TicketExtension.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0142148)
hgbot (developer)
2022-10-17 12:54

Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1ce9da9c2c78a07076eb6407bbc5f13b1f93d4e1
Author: Martin Taal <martin.taal@openbravo.com>
Date: 17-10-2022 10:54:03
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1ce9da9c2c78a07076eb6407bbc5f13b1f93d4e1 [^]

Fixed ISSUE-50461: solved failing test cases

---
M web-jspack/org.openbravo.pos2/src/model/ticket/__test__/AddProductActionPreparation.test.js
M web-jspack/org.openbravo.pos2/src/model/ticket/actions/AddProductActionPreparation.js
---
(0142197)
hgbot (developer)
2022-10-18 00:44

Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1284 [^]
(0142198)
hgbot (developer)
2022-10-18 00:45

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ad9c91b5ba1318becbb8fc96a39e712867dd6350
Author: Martin Taal <martin.taal@openbravo.com>
Date: 18-10-2022 00:43:25
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ad9c91b5ba1318becbb8fc96a39e712867dd6350 [^]

Related to ISSUE-50461: adapt test to cover the case a line gets added next to the return line

---
M web-jspack/org.openbravo.pos2/src-test/cypress/integration/Components/returnOrder.spec.js
---
(0142199)
hgbot (developer)
2022-10-18 00:45

Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1284 [^]

- Issue History
Date Modified Username Field Change
2022-10-10 10:53 asier_perez New Issue
2022-10-10 10:53 asier_perez Assigned To => Retail
2022-10-10 10:53 asier_perez File Added: returnOrderError.png
2022-10-10 10:53 asier_perez Regression level => Automated tests
2022-10-10 10:53 asier_perez Triggers an Emergency Pack => No
2022-10-10 17:00 mtaal Assigned To Retail => mtaal
2022-10-10 17:31 dbaz Note Added: 0141929
2022-10-11 09:35 asier_perez Description Updated View Revisions
2022-10-11 15:17 hgbot Note Added: 0141973
2022-10-17 12:54 hgbot Resolution open => fixed
2022-10-17 12:54 hgbot Status new => closed
2022-10-17 12:54 hgbot Note Added: 0142145
2022-10-17 12:54 hgbot Fixed in Version => 23Q1
2022-10-17 12:54 hgbot Note Added: 0142146
2022-10-17 12:54 hgbot Note Added: 0142147
2022-10-17 12:54 hgbot Note Added: 0142148
2022-10-18 00:44 hgbot Note Added: 0142197
2022-10-18 00:45 hgbot Note Added: 0142198
2022-10-18 00:45 hgbot Note Added: 0142199


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker