Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050439
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajoralways2022-10-06 15:312023-02-16 08:26
ReporterjorgewederagoView Statuspublic 
Assigned Toradhakrishnan 
PriorityhighResolutionfixedFixed in Version23Q1
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050439: It should not be possible to edit the external business partner on closed ticket

DescriptionWhen loading a ticket from the backend that contains an external business partner it is possible to remove and edit it.
Steps To Reproduce1.- Do a transaction in the POS using an external BP
2.- Load the ticket from the backend
3.- Click on the BP/Address info of it
4.- Check that you can do whatever you want with it
Proposed SolutionThe call to the external system should be kept, but the buttons should not be clickable.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0051623 closedRetail Business partner button contains logic that should not be there, should be refactored as a User Action instead 
depends on backport 005149723Q1 closedradhakrishnan It should not be possible to edit the external business partner on closed ticket 
has duplicate defect 0049712 closedRetail [CRM] - Change a known client posteriori should not be possible 

-  Notes
(0144591)
hgbot (developer)
2022-12-13 13:15

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1416 [^]
(0145974)
hgbot (developer)
2023-01-29 19:05

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 1f9bf7d208e398f9a91f19bd9880d7743a7887b2
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 29-01-2023 18:05:11
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/1f9bf7d208e398f9a91f19bd9880d7743a7887b2 [^]

Fixed ISSUE-50439: Don't allow to change BP under some circumstances

* If a ticket is completed and a Verified Return (VR) was created -> not allowed
* If a ticket is completed and a VR was created having the "change business partner" preference enabled -> allowed
* If working with a completed quotation -> not allowed
* if working with a completed quotation that was reactivated -> allowed
* If it is a "canceled and replacement ticket" -> allowed
* If it is not paid and not loaded from BO -> allowed

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocTypeTestUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/__test__/TicketPropertiesPopover.test.jsx
---
(0145975)
hgbot (developer)
2023-01-29 19:05

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1416 [^]
(0145976)
guilleaer (manager)
2023-01-29 19:09

 Backport needed for 23Q1
(0146032)
hgbot (developer)
2023-01-30 13:52

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: d352ec7a1f345c784af90b8958660fe0e97bda54
Author: Guillermo Alvarez de Eulate <guillermo.alvarez@openbravo.com>
Date: 30-01-2023 12:52:32
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/d352ec7a1f345c784af90b8958660fe0e97bda54 [^]

Revert "Fixed ISSUE-50439: Don't allow to change BP under some circumstances"

This reverts commit 1f9bf7d208e398f9a91f19bd9880d7743a7887b2
---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocTypeTestUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/__test__/TicketPropertiesPopover.test.jsx
---
(0146033)
guilleaer (manager)
2023-01-30 13:53

 Commit reverted and issue reopened
(0146593)
hgbot (developer)
2023-02-16 06:07

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1526 [^]
(0146597)
hgbot (developer)
2023-02-16 07:50

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: ffa68292f1bdfe1be98ea529e5baf1bb70be688b
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 15-02-2023 18:39:20
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/ffa68292f1bdfe1be98ea529e5baf1bb70be688b [^]

Fixed ISSUE-50439: Don't allow to change BP under some circumstances
* If a ticket is completed and a Verified Return (VR) was created -> not allowed
* If a ticket is completed and a VR was created having the "change business partner" preference enabled ->
  allowed
* If working with a completed quotation -> not allowed
* if working with a completed quotation that was reactivated -> allowed
* If it is a "canceled and replacement ticket" -> allowed
* If it is not paid and not loaded from BO -> allowed

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocTypeTestUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/__test__/TicketPropertiesPopover.test.jsx
---
(0146598)
hgbot (developer)
2023-02-16 07:50

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1526 [^]
(0146608)
hgbot (developer)
2023-02-16 08:26

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: dcc1b428e971a685eefd5b98ae4477ef62009672
Author: Radhakrishnan Seeman <radhakrishnan@qualiantech.com>
Date: 16-02-2023 11:37:15
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/dcc1b428e971a685eefd5b98ae4477ef62009672 [^]

Fixed ISSUE-50439: Don't allow to change BP under some circumstances
* If a ticket is completed and a Verified Return (VR) was created -> not allowed
* If a ticket is completed and a VR was created having the "change business partner" preference enabled ->
  allowed
* If working with a completed quotation -> not allowed
* if working with a completed quotation that was reactivated -> allowed
* If it is a "canceled and replacement ticket" -> allowed
* If it is not paid and not loaded from BO -> allowed

---
M web-jspack/org.openbravo.pos2/src/components/ButtonBar1/__test__/ButtonBar1.test.jsx
M web-jspack/org.openbravo.pos2/src/components/ButtonBar4/__test__/ButtonBar4.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButton.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/__test__/TicketBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPButton/__test__/TicketHeaderBPButton.test.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderBPWithDocType/__test__/TicketHeaderBPWithDocTypeTestUtils.jsx
M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPropertiesPopover/__test__/TicketPropertiesPopover.test.jsx
---

- Issue History
Date Modified Username Field Change
2022-10-06 15:31 jorgewederago New Issue
2022-10-06 15:31 jorgewederago Assigned To => Retail
2022-10-06 15:31 jorgewederago Triggers an Emergency Pack => No
2022-10-18 15:32 radhakrishnan Assigned To Retail => radhakrishnan
2022-10-18 15:32 radhakrishnan Status new => scheduled
2022-10-19 14:01 hgbot Note Added: 0142283
2022-12-09 08:04 hgbot Note Added: 0144491
2022-12-13 13:15 hgbot Note Added: 0144591
2023-01-11 18:03 marvintm Relationship added has duplicate 0049712
2023-01-11 18:04 guilleaer Note Deleted: 0144491
2023-01-11 18:04 guilleaer Note Deleted: 0142283
2023-01-29 19:05 hgbot Resolution open => fixed
2023-01-29 19:05 hgbot Status scheduled => closed
2023-01-29 19:05 hgbot Fixed in Version => 23Q2
2023-01-29 19:05 hgbot Note Added: 0145974
2023-01-29 19:05 hgbot Note Added: 0145975
2023-01-29 19:07 guilleaer Status closed => new
2023-01-29 19:07 guilleaer Resolution fixed => open
2023-01-29 19:07 guilleaer Fixed in Version 23Q2 =>
2023-01-29 19:08 guilleaer Status new => scheduled
2023-01-29 19:08 guilleaer Status scheduled => resolved
2023-01-29 19:08 guilleaer Resolution open => fixed
2023-01-29 19:08 guilleaer Status resolved => closed
2023-01-29 19:09 guilleaer Note Added: 0145976
2023-01-30 11:11 guilleaer Status closed => new
2023-01-30 11:11 guilleaer Resolution fixed => open
2023-01-30 11:11 guilleaer Status new => scheduled
2023-01-30 13:52 hgbot Resolution open => fixed
2023-01-30 13:52 hgbot Status scheduled => closed
2023-01-30 13:52 hgbot Fixed in Version => 23Q2
2023-01-30 13:52 hgbot Note Added: 0146032
2023-01-30 13:53 guilleaer Status closed => new
2023-01-30 13:53 guilleaer Resolution fixed => open
2023-01-30 13:53 guilleaer Fixed in Version 23Q2 =>
2023-01-30 13:53 guilleaer Note Added: 0146033
2023-02-16 06:07 hgbot Note Added: 0146593
2023-02-16 07:50 hgbot Resolution open => fixed
2023-02-16 07:50 hgbot Status new => closed
2023-02-16 07:50 hgbot Fixed in Version => 23Q2
2023-02-16 07:50 hgbot Note Added: 0146597
2023-02-16 07:50 hgbot Note Added: 0146598
2023-02-16 07:54 marvintm Relationship added related to 0051623
2023-02-16 08:26 hgbot Fixed in Version 23Q2 => 23Q1
2023-02-16 08:26 hgbot Note Added: 0146608

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker