0050414: Payment Methods for Refunds: changes in payments/lines not controlled correctly

Description

There are some situations where the PM for refunds validation is triggered incorrectly, or it is not triggered when it should.
Both situations involve playing around with verified returns and blind returns lines and adding/removing payments.

Steps To Reproduce

Preparation:
Log in backoffice, go to the Channel - Touchpoint Type window and configure the Payment Method for Refunds functionality:
* Add Cash as the PM for Refund for Cash

Log in Webpos and create a ticket with a single product and paid totally in Cash.

Case 1) Validation applied incorrectly:
* Go to menu > Verified returns and return the ticket created previously.
* Remove the VR line
* Add a negative line (blind return) of the same product used previously
* Try to complete the payment with Card
=> Validation is still applied and Card payment is refused, despite being a blind return ticket

Case 2) Validation skipped
* Create an empty ticket and add a negative line (blind return) of the same product used previously
* Add a negative payment in Card but do not complete the ticket
* Remove the blind return line
* Go to menu > Verified returns and return the ticket created previously.
=> Verify that the payment added in Card is still present (which should not be possible because only Cash is allowed) and that it is possible to complete the return process by clicking on Done.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0050310

closed

igor_trebol

Payment Methods for Refunds: changes in payments/lines not controlled correctly

Notes
(0141666) hgbot (developer) 2022-10-05 10:48	Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 15280618449d1fbe533d0e1d14134d4917a69956 Author: Igor Trebol <igor.trebol@openbravo.com> Date: 05-10-2022 10:27:31 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/15280618449d1fbe533d0e1d14134d4917a69956 [^] Fixes ISSUE-50414: Verified return original payments now are re-calculated when removing a line --- M web-test/model/business-object/ticket/actions/DeleteLine.test.js M web/org.openbravo.retail.posterminal/app/model/business-object/ticket/actions/DeleteLine.js ---

(0141667) aferraz (viewer) 2022-10-05 10:50	MR: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/945 [^]

Issue History
Date Modified	Username	Field	Change
2022-10-05 10:16	igor_trebol	Type	defect => backport
2022-10-05 10:16	igor_trebol	Target Version	=> RR22Q4
2022-10-05 10:48	hgbot	Resolution	open => fixed
2022-10-05 10:48	hgbot	Status	scheduled => resolved
2022-10-05 10:48	hgbot	Fixed in Version	=> RR22Q4
2022-10-05 10:48	hgbot	Note Added: 0141666
2022-10-05 10:50	aferraz	Review Assigned To	=> aferraz
2022-10-05 10:50	aferraz	Status	resolved => closed
2022-10-05 10:50	aferraz	Note Added: 0141667