Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050411 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | always | 2022-10-04 18:57 | 2022-10-19 13:45 | |||
| Reporter | gorka_gil | View Status | public | |||||
| Assigned To | gorka_gil | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050411: Free products discounts should be tested by discounts engine before show as candidate | |||||||
| Description | - | |||||||
| Steps To Reproduce | Create a free product discount: - amount : 50 - gift notification : mark - free products tab: insect repelent - Include products: only those defined - Products tab: balaclaba Go to the pos - Refresh masterdata - add avalanche - click pay ERROR: it shows the discount as available, but it shouldn't since the discount only apply to balaclavas not avalanches When clicking on it doesn't do anything, but still it shouldn't be shown as available. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0142111) hgbot (developer) 2022-10-14 21:06 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/69 [^] |
|
(0142112) hgbot (developer) 2022-10-14 21:07 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1280 [^] |
|
(0142273) hgbot (developer) 2022-10-19 13:44 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/merge_requests/69 [^] |
|
(0142274) hgbot (developer) 2022-10-19 13:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 091666dfc2fedf6522f544910574535b774402c8 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 18-10-2022 05:52:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/091666dfc2fedf6522f544910574535b774402c8 [^] Fixed ISSUE-50411: check available gift product discounts in the discounts engine --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js --- |
|
(0142275) hgbot (developer) 2022-10-19 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 4ef0bc5088d318a672a1b543a255a29201b91248 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 18-10-2022 05:52:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4ef0bc5088d318a672a1b543a255a29201b91248 [^] Related to ISSUE-50411: Fix duplicates --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js --- |
|
(0142276) hgbot (developer) 2022-10-19 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 5b179b08455c7a995defe628956ff28ac7ec20c8 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 18-10-2022 05:52:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/5b179b08455c7a995defe628956ff28ac7ec20c8 [^] Related to ISSUE-50411: Fix condition to load the gift products when evaluating the discount --- M web/org.openbravo.retail.discounts/app/model/business-logic/discounts-engine/engine/optional-discount-engine.js --- |
|
(0142277) hgbot (developer) 2022-10-19 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 16b06e8a58b007c9bc2bccde7af5e7a2a2cb8d2d Author: Gorka Gil <gorka.gil@openbravo.com> Date: 18-10-2022 19:45:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/16b06e8a58b007c9bc2bccde7af5e7a2a2cb8d2d [^] Related to ISSUE-50411: adapt jest test --- M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js --- |
|
(0142278) hgbot (developer) 2022-10-19 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: 4a7d8e305aa7a810a1a2a66a7f56c74bd108fa91 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 19-10-2022 11:18:00 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/4a7d8e305aa7a810a1a2a66a7f56c74bd108fa91 [^] Related to ISSUE-50411: Add jest tests --- M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js --- |
|
(0142279) hgbot (developer) 2022-10-19 13:44 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts [^] Changeset: f640813f44eda4109a5d5088e1e9d6b905d3f67c Author: Gorka Gil <gorka.gil@openbravo.com> Date: 19-10-2022 11:20:26 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.discounts/-/commit/f640813f44eda4109a5d5088e1e9d6b905d3f67c [^] Related to ISSUE-50411: add deepfreeze to the jest tests --- M web-test/model/business-logic/discounts-engine/engine/optional-discount-engine.test.js --- |
|
(0142280) hgbot (developer) 2022-10-19 13:45 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1280 [^] |
|
(0142281) hgbot (developer) 2022-10-19 13:45 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 9ef31185ccad2836b5d1132d318c1196e9558840 Author: Gorka Gil <gorka.gil@openbravo.com> Date: 19-10-2022 11:44:50 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9ef31185ccad2836b5d1132d318c1196e9558840 [^] Fixed ISSUE-50411: check available gift product discounts in the discounts engine --- M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountPanelGrid/FeaturedDiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/FeaturedDiscount/FeaturedDiscountsPaymentFlowHook.js M web-jspack/org.openbravo.pos2/src/components/Discounts/ManualDiscount/DiscountPanelGrid/DiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountOnExitDialog/OrderDiscountOnExitDialog.js M web-jspack/org.openbravo.pos2/src/components/Discounts/OrderDiscount/OrderDiscountPanelGrid/OrderDiscountPanelGrid.jsx M web-jspack/org.openbravo.pos2/src/components/Discounts/shared/OptionalDiscountsUtils.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-10-04 18:57 | gorka_gil | New Issue | |
| 2022-10-04 18:57 | gorka_gil | Assigned To | => gorka_gil |
| 2022-10-04 18:57 | gorka_gil | Triggers an Emergency Pack | => No |
| 2022-10-04 18:59 | gorka_gil | Summary | Free products discounts should be tested by discounts enginee before show as candidate => Free products discounts should be tested by discounts engine before show as candidate |
| 2022-10-04 19:04 | gorka_gil | Relationship added | related to 0049961 |
| 2022-10-04 19:05 | gorka_gil | Status | new => scheduled |
| 2022-10-14 21:06 | hgbot | Note Added: 0142111 | |
| 2022-10-14 21:07 | hgbot | Note Added: 0142112 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142273 | |
| 2022-10-19 13:44 | hgbot | Resolution | open => fixed |
| 2022-10-19 13:44 | hgbot | Status | scheduled => closed |
| 2022-10-19 13:44 | hgbot | Fixed in Version | => RR23Q1 |
| 2022-10-19 13:44 | hgbot | Note Added: 0142274 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142275 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142276 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142277 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142278 | |
| 2022-10-19 13:44 | hgbot | Note Added: 0142279 | |
| 2022-10-19 13:45 | hgbot | Note Added: 0142280 | |
| 2022-10-19 13:45 | hgbot | Fixed in Version | RR23Q1 => 23Q1 |
| 2022-10-19 13:45 | hgbot | Note Added: 0142281 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |