Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0050380 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
backport | [POS2] POS | major | have not tried | 2022-09-30 13:52 | 2022-10-04 23:48 | |||
Reporter | AugustoMauch | View Status | public | |||||
Assigned To | AugustoMauch | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 22Q3.2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | |||||
Projection | none | ETA | none | Target Version | 22Q3.2 | |||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0050380: Keymap editor import entries should include an ID | |||||||
Description | When the processing of an import entry fails, the import entry manager will check the "id" property of the json object to properly manage the error. Note that this is not the id of the import entry (that one is stored in the messageId property) but a more business-oriented id | |||||||
Steps To Reproduce | Open POS2 - Using the keymap editor, force an error i.e by throwing an exception in the KeymapLoader class - Check that the following error is printed in the log: org.codehaus.jettison.json.JSONException: JSONObject["id"] not found. at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360) at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487) at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:244) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:156) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:88) at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338) at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628) at java.base/java.lang.Thread.run(Thread.java:829) | |||||||
Proposed Solution | Include an id in the request sent when saving a keymap editor change | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |
Notes | |
(0141539) hgbot (developer) 2022-09-30 13:53 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1240 [^] |
(0141549) hgbot (developer) 2022-10-03 09:25 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 9a94049453083bebeda44304a3c044cad2dbf4e0 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 03-10-2022 08:43:23 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9a94049453083bebeda44304a3c044cad2dbf4e0 [^] Fixes ISSUE-50380: Include an ID when saving a keymap editor change to prevent errors --- M web-jspack/org.openbravo.pos2/src/model/global/actions/SaveKeymap.js --- |
(0141550) hgbot (developer) 2022-10-03 09:25 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1240 [^] |
(0141635) hgbot (developer) 2022-10-04 12:49 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1245 [^] |
(0141636) hgbot (developer) 2022-10-04 12:52 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 31e07595b4977c206840b7528eefa271005d5056 Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 04-10-2022 12:45:34 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/31e07595b4977c206840b7528eefa271005d5056 [^] Related to ISSUE-50380: Fixes test --- M web-jspack/org.openbravo.pos2/src/model/global/__test__/SaveKeymap.test.js --- |
(0141637) hgbot (developer) 2022-10-04 12:52 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1245 [^] |
(0141656) hgbot (developer) 2022-10-04 23:48 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1246 [^] |
(0141657) hgbot (developer) 2022-10-04 23:48 |
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: be0d0baf85732d7e68460e84ea865942e6d8ab7c Author: Augusto Mauch <augusto.mauch@openbravo.com> Date: 04-10-2022 23:47:26 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/be0d0baf85732d7e68460e84ea865942e6d8ab7c [^] Related to ISSUE-50380: Fixes test --- M web-jspack/org.openbravo.pos2/src/model/global/__test__/SaveKeymap.test.js --- |
(0141658) hgbot (developer) 2022-10-04 23:48 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1246 [^] |
Issue History | |||
Date Modified | Username | Field | Change |
2022-09-30 13:52 | AugustoMauch | New Issue | |
2022-09-30 13:52 | AugustoMauch | Assigned To | => AugustoMauch |
2022-09-30 13:52 | AugustoMauch | Triggers an Emergency Pack | => No |
2022-09-30 13:53 | hgbot | Note Added: 0141539 | |
2022-10-03 08:41 | AugustoMauch | Status | new => scheduled |
2022-10-03 09:25 | hgbot | Resolution | open => fixed |
2022-10-03 09:25 | hgbot | Status | scheduled => resolved |
2022-10-03 09:25 | hgbot | Fixed in Version | => 22Q3.2 |
2022-10-03 09:25 | hgbot | Note Added: 0141549 | |
2022-10-03 09:25 | hgbot | Note Added: 0141550 | |
2022-10-04 12:49 | hgbot | Note Added: 0141635 | |
2022-10-04 12:52 | hgbot | Note Added: 0141636 | |
2022-10-04 12:52 | hgbot | Note Added: 0141637 | |
2022-10-04 12:52 | AugustoMauch | Status | resolved => closed |
2022-10-04 23:48 | hgbot | Note Added: 0141656 | |
2022-10-04 23:48 | hgbot | Note Added: 0141657 | |
2022-10-04 23:48 | hgbot | Note Added: 0141658 |
Copyright © 2000 - 2009 MantisBT Group |