Openbravo Issue Tracking System - POS2
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0050380POS2POSpublic2022-09-30 13:522022-10-04 23:48
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version22Q3.2Fixed in Version22Q3.2 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0050380: Keymap editor import entries should include an ID
DescriptionWhen the processing of an import entry fails, the import entry manager will check the "id" property of the json object to properly manage the error. Note that this is not the id of the import entry (that one is stored in the messageId property) but a more business-oriented id
Steps To ReproduceOpen POS2
- Using the keymap editor, force an error i.e by throwing an exception in the KeymapLoader class
- Check that the following error is printed in the log:

org.codehaus.jettison.json.JSONException: JSONObject["id"] not found.
    at org.codehaus.jettison.json.JSONObject.get(JSONObject.java:360)
    at org.codehaus.jettison.json.JSONObject.getString(JSONObject.java:487)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:244)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:156)
    at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:88)
    at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:57)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:421)
    at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:338)
    at java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
    at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
    at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
    at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
    at java.base/java.lang.Thread.run(Thread.java:829)
Proposed Solution    Include an id in the request sent when saving a keymap editor change
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2022-09-30 13:52AugustoMauchNew Issue
2022-09-30 13:52AugustoMauchAssigned To => AugustoMauch
2022-09-30 13:52AugustoMauchTriggers an Emergency Pack => No
2022-09-30 13:53hgbotNote Added: 0141539
2022-10-03 08:41AugustoMauchStatusnew => scheduled
2022-10-03 09:25hgbotResolutionopen => fixed
2022-10-03 09:25hgbotStatusscheduled => resolved
2022-10-03 09:25hgbotFixed in Version => 22Q3.2
2022-10-03 09:25hgbotNote Added: 0141549
2022-10-03 09:25hgbotNote Added: 0141550
2022-10-04 12:49hgbotNote Added: 0141635
2022-10-04 12:52hgbotNote Added: 0141636
2022-10-04 12:52hgbotNote Added: 0141637
2022-10-04 12:52AugustoMauchStatusresolved => closed
2022-10-04 23:48hgbotNote Added: 0141656
2022-10-04 23:48hgbotNote Added: 0141657
2022-10-04 23:48hgbotNote Added: 0141658

Notes
(0141539)
hgbot   
2022-09-30 13:53   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1240 [^]
(0141549)
hgbot   
2022-10-03 09:25   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 9a94049453083bebeda44304a3c044cad2dbf4e0
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 03-10-2022 08:43:23
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/9a94049453083bebeda44304a3c044cad2dbf4e0 [^]

Fixes ISSUE-50380: Include an ID when saving a keymap editor change to prevent errors

---
M web-jspack/org.openbravo.pos2/src/model/global/actions/SaveKeymap.js
---
(0141550)
hgbot   
2022-10-03 09:25   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1240 [^]
(0141635)
hgbot   
2022-10-04 12:49   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1245 [^]
(0141636)
hgbot   
2022-10-04 12:52   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 31e07595b4977c206840b7528eefa271005d5056
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 04-10-2022 12:45:34
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/31e07595b4977c206840b7528eefa271005d5056 [^]

Related to ISSUE-50380: Fixes test

---
M web-jspack/org.openbravo.pos2/src/model/global/__test__/SaveKeymap.test.js
---
(0141637)
hgbot   
2022-10-04 12:52   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1245 [^]
(0141656)
hgbot   
2022-10-04 23:48   
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1246 [^]
(0141657)
hgbot   
2022-10-04 23:48   
Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: be0d0baf85732d7e68460e84ea865942e6d8ab7c
Author: Augusto Mauch <augusto.mauch@openbravo.com>
Date: 04-10-2022 23:47:26
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/be0d0baf85732d7e68460e84ea865942e6d8ab7c [^]

Related to ISSUE-50380: Fixes test

---
M web-jspack/org.openbravo.pos2/src/model/global/__test__/SaveKeymap.test.js
---
(0141658)
hgbot   
2022-10-04 23:48   
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1246 [^]