Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050375 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| design defect | [POS2] Core | major | always | 2022-09-29 17:17 | 2022-10-13 16:19 | |||
| Reporter | dbaz | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 23Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050375: Primary and Secondary color variables should be revisited | |||||||
| Description | The current situation is: primary: *Pay button and primary popup buttons *Secondary popup buttons label *Receipt header *Scrollbar *Active element selection *Login spinning *Grid header *Label and focused status in inputs *Checkboxes *Radio buttons *Date picker *Quantity bubble in receipt *Receipt header in multiselection mode *Discount bubble *Payments and proof of payments vertical separation *Grid selection *Menu wizard selection secondary: *Not primary buttons on toolbars We plan to move to this situation (already donde in Figma): primary: *Receipt header *Scrollbar *Active element selection *Login spinning *Grid header *Label and focused status in inputs *Checkboxes *Radio buttons *Date picker *Quantity bubble in receipt *Receipt header in multiselection mode *Discount bubble *Payments and proof of payments vertical separation *Grid selection *Menu wizard selection secondary: *Pay button and primary popup buttons *Secondary popup buttons label tertiary: *Not primary buttons on toolbars Together with this, primary-variant, secondary-variant, background-variant, surface-variant (if exist) should be removed. Another new colors are needed *surface-inverse *on-surface-inverse (check Figma to see its values in dark theme) NOTE: Custom modules should be also revisited (ask dbaz) | |||||||
| Steps To Reproduce | . | |||||||
| Proposed Solution | This is just a suggestion of an efficient flow of solving it, but do it as you consider. Search for "variant" in SCSS and swap them by the no variant class. Massively replace, in this order: "--obc2-color-secondary" by "--obc2-color-tertiary" "--obc2-color-on-secondary" by "--obc2-color-on-tertiary" Create new variables: --obc2-color-tertiary-* --obc2-color-on-tertiary-* Search the componens in charge of the "Pay", "Apply" etc buttons, and the one in charge of the modal popup buttons, and replace the "-primary-" by "-secondary-" | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0142008) hgbot (developer) 2022-10-13 11:05 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/867 [^] |
|
(0142017) hgbot (developer) 2022-10-13 14:23 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1273 [^] |
|
(0142018) hgbot (developer) 2022-10-13 14:29 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/179 [^] |
|
(0142028) hgbot (developer) 2022-10-13 16:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/merge_requests/867 [^] |
|
(0142029) hgbot (developer) 2022-10-13 16:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2 [^] Changeset: 3084d3a8698abbfb88fc52e22d57c186c4c063c6 Author: Miguel de Juana <miguel.dejuana@openbravo.com> Date: 13-10-2022 14:19:12 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.core2/-/commit/3084d3a8698abbfb88fc52e22d57c186c4c063c6 [^] Fixes ISSUE-0050375: Primary and Secondary color variables should be revisited --- M web-jspack/org.openbravo.core2/src/assets/style/color.scss M web-jspack/org.openbravo.core2/src/components/AppBar/AppBar.scss M web-jspack/org.openbravo.core2/src/components/AppBar/UserButton/UserButton.scss M web-jspack/org.openbravo.core2/src/components/ApprovalDialog/ApprovalDialog.scss M web-jspack/org.openbravo.core2/src/components/BaseAccordion/stories/BaseAccordion.stories.scss M web-jspack/org.openbravo.core2/src/components/BaseButton/BaseButton.scss M web-jspack/org.openbravo.core2/src/components/BaseButtonGroup/BaseButtonGroup.scss M web-jspack/org.openbravo.core2/src/components/BaseContent/BaseContent.scss M web-jspack/org.openbravo.core2/src/components/BaseFormInput/BaseFormInput.scss M web-jspack/org.openbravo.core2/src/components/BaseFormTimePicker/BaseFormTimePicker.scss M web-jspack/org.openbravo.core2/src/components/BaseTextArea/BaseTextArea.scss M web-jspack/org.openbravo.core2/src/components/DrawerMenu/DrawerMenu.scss M web-jspack/org.openbravo.core2/src/components/FractionIncrementalInput/FractionIncrementalInput.scss M web-jspack/org.openbravo.core2/src/components/Grid/DataGrid/BaseHeaderRender.scss M web-jspack/org.openbravo.core2/src/components/LoadingCard/LoadingCard.scss M web-jspack/org.openbravo.core2/src/components/MainApp/MainApp.scss M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessBody/stories/MultiStepProcessBody.stories.scss M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessHeader/MultiStepProcessHeader.scss M web-jspack/org.openbravo.core2/src/components/MultiStepProcess/MultiStepProcessNextButton/stories/MultiStepProcessNextButton.stories.scss M web-jspack/org.openbravo.core2/src/components/SettingsButton/SettingItem/stories/SettingItem.stories.scss M web-jspack/org.openbravo.core2/src/components/StandardButton/StandardButton.scss M web-jspack/org.openbravo.core2/src/components/StatusBar/ServerStatusButton.scss --- |
|
(0142030) hgbot (developer) 2022-10-13 16:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^] Changeset: 95d0c113efbdf3c540fa2441cc88bd37800f7f54 Author: Miguel de Juana <miguel.dejuana@openbravo.com> Date: 13-10-2022 14:19:22 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/95d0c113efbdf3c540fa2441cc88bd37800f7f54 [^] Fixes ISSUE-0050375: Primary and Secondary color variables should be revisited --- M web-jspack/org.openbravo.pos2/src/components/ButtonBar3/ButtonBar3.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupProcess/stories/CashupProcessStories.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/CountPaymentMethodsStep/stories/CountPaymentMethodsStepStories.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CashupSteps/SelectDrawerStep/render/SelectDrawerStepStatusCellRender.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CountingToolDialog/CountingTool/AddRowPopover/AddRowPopover.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CountingToolDialog/CountingTool/AddRowPopover/stories/AddRowPopover.stories.scss M web-jspack/org.openbravo.pos2/src/components/Cashup/CountingToolDialog/stories/CountingToolDialog.stories.scss M web-jspack/org.openbravo.pos2/src/components/InitialCountWindow/stories/InitialCountWindow.stories.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeyMapEditor.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorCurrentIndicator/KeymapEditorCurrentIndicator.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorEditButton/KeymapEditorEditButton.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/KeymapEditorNewCategoryDialog/KeymapEditorCategoryDialog.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeyMapProductsGrid/KeyMapProductsGrid.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorCategoryLayoutPopover/KeymapEditorCategoryLayoutPopover.scss M web-jspack/org.openbravo.pos2/src/components/KeyMapEditor/steps/KeyMapEditorLayout/KeymapEditorProductPopover/KeymapEditorColorPicker/KeymapEditorColorPicker.scss M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentList/PaymentName.scss M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodCategoryButton.scss M web-jspack/org.openbravo.pos2/src/components/Payments/PaymentMethods/PaymentMethodsHighVolumePanel/PaymentMethodsHighVolumePanel.scss M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButton.scss M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContent.scss M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductButtonContent/ProductButtonContentImg.scss M web-jspack/org.openbravo.pos2/src/components/ProductButton/ProductCrossStockPopup/ProductCrossStockList/render/CrossStockInfoCellRender.scss M web-jspack/org.openbravo.pos2/src/components/ProductCategoryButton/ProductCategoryButton.scss M web-jspack/org.openbravo.pos2/src/components/ProductModifier/ProductModifierItemRender/ProductModifierItemRender.scss M web-jspack/org.openbravo.pos2/src/components/ProductScan/ProductScanProductInfo/ProductScanProductInfo.scss M web-jspack/org.openbravo.pos2/src/components/ProductSearch/AvailableProductFilterButtonContent/AvailableProductFilterButtonContent.scss M web-jspack/org.openbravo.pos2/src/components/ProductSearch/AvailableProductFilterList/AvailableProductFilterList.scss M web-jspack/org.openbravo.pos2/src/components/ProductSearch/FilteredProductsKeymap/FilteredProductsKeymap.scss M web-jspack/org.openbravo.pos2/src/components/ProductSearch/ProductSorting/ProductSorting.scss M web-jspack/org.openbravo.pos2/src/components/SchemaSelectorButton/SchemaSelectorButton.scss M web-jspack/org.openbravo.pos2/src/components/TerminalSchedule/TerminalSchedule.scss M web-jspack/org.openbravo.pos2/src/components/TerminalSchedule/TerminalScheduleWeekdays/TerminalScheduleWeekdays.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPAddressButton/TicketBPAddressButton.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketBPButton/TicketBPButtonGeneric.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderDeliveryButton/TicketHeaderDeliveryButton.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderDocumentnoButton/TicketHeaderDocumentnoButton.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketHeader/TicketHeaderIssueInvoiceChip/TicketHeaderIssueInvoiceChip.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineDeliveryControlVisual/TicketLineDeliveryControlVisual.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLineNote/CurrentTicketLineNote/CurrentTicketLineNote.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLinePopover/stories/TicketLinePopover.stories.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/StandardProductConfigurationItem.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineSchemaLabel/TicketLineSchemaLabel.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLineUnitConsumption.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/TicketLines.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/CustomProductConfigurationItem.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/MockAdvancedTicketLine.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketLines/stories/TicketLineUnitConsumption.stories.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketPopover/stories/TicketPopover.stories.scss M web-jspack/org.openbravo.pos2/src/components/Ticket/TicketTypeStatus.scss M web-jspack/org.openbravo.pos2/src/components/TicketList/TicketListRemoteGrid/render/TicketRemoteStoreCellRender.scss --- |
|
(0142031) hgbot (developer) 2022-10-13 16:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1273 [^] |
|
(0142032) hgbot (developer) 2022-10-13 16:19 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant [^] Changeset: 89a5a06a9995e3e480095a196d0040900b954f03 Author: miguel.dejuana <miguel.dejuana@openbravo.com> Date: 13-10-2022 14:29:03 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/commit/89a5a06a9995e3e480095a196d0040900b954f03 [^] Fixes ISSUE-0050375: Primary and Secondary color variables should be revisited --- M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryButton/MenuWizardCategoryButton.jsx M web-jspack/org.openbravo.pos2.restaurant/src/components/MenuWizard/MenuWizardCategoryKeymapLayout/MenuWizardCategoryButton/MenuWizardCategoryButton.scss M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/TicketMenuInProgressLineHeader/stories/TicketMenuInProgressLineHeader.stories.scss M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/TicketMenuInProgressLineItem/TicketMenuInProgressLineItem.scss M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/TicketMenuInProgressLineItems/TicketMenuInProgressLineItems.scss M web-jspack/org.openbravo.pos2.restaurant/src/components/TicketMenuLine/TicketMenuLineItems/TicketMenuLineItems.scss --- |
|
(0142033) hgbot (developer) 2022-10-13 16:19 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2.restaurant/-/merge_requests/179 [^] |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-29 17:17 | dbaz | New Issue | |
| 2022-09-29 17:17 | dbaz | Assigned To | => migueldejuana |
| 2022-09-29 17:17 | dbaz | OBNetwork customer | => No |
| 2022-09-29 17:17 | dbaz | Triggers an Emergency Pack | => No |
| 2022-10-01 14:46 | dbaz | Description Updated | View Revisions |
| 2022-10-01 14:46 | dbaz | Proposed Solution updated | |
| 2022-10-11 16:09 | dbaz | Proposed Solution updated | |
| 2022-10-11 16:11 | dbaz | Proposed Solution updated | |
| 2022-10-13 11:05 | hgbot | Merge Request Status | => open |
| 2022-10-13 11:05 | hgbot | Note Added: 0142008 | |
| 2022-10-13 14:23 | hgbot | Note Added: 0142017 | |
| 2022-10-13 14:29 | hgbot | Note Added: 0142018 | |
| 2022-10-13 16:16 | hgbot | Merge Request Status | open => approved |
| 2022-10-13 16:19 | hgbot | Resolution | open => fixed |
| 2022-10-13 16:19 | hgbot | Status | new => closed |
| 2022-10-13 16:19 | hgbot | Note Added: 0142028 | |
| 2022-10-13 16:19 | hgbot | Fixed in Version | => 23Q1 |
| 2022-10-13 16:19 | hgbot | Note Added: 0142029 | |
| 2022-10-13 16:19 | hgbot | Note Added: 0142030 | |
| 2022-10-13 16:19 | hgbot | Note Added: 0142031 | |
| 2022-10-13 16:19 | hgbot | Note Added: 0142032 | |
| 2022-10-13 16:19 | hgbot | Note Added: 0142033 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |