Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0050371 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [POS2] POS | major | have not tried | 2022-09-29 08:16 | 2022-10-03 16:16 | |||
| Reporter | alostale | View Status | public | |||||
| Assigned To | alostale | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0050371: optional discounts do not take into account CRM property conditions | |||||||
| Description | When a discount is marked as optional and it defines a CRM property condition, this condition is not taken into account. | |||||||
| Steps To Reproduce | In an instance with org.openbravo.discounts.propertycondition module installed. 1. In BO create a new discount that: a. Applies to all products b. Has an optional filter with a CRM property condition 2. Log in POS2. ERROR (technical) -> In dev console check discountPropertyCRMFilters property in OB.Discounts.Pos.optionalRuleImpls object -> ERROR: it's an empty array but it should contain the CRM property that was defined 3. Create a ticket with anonymous user and pay it. ERROR -> the discount is proposed even if not applicable to the user 4. Create a ticket with a CRM user that does not satisfy the CRM filter defined in the discout and pay it -> ERROR: it's an empty array but it should contain the CRM property that was defined | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||
|
|||||||||||||||||
 Relationships |
|
Notes |
|
|
(0141478) hgbot (developer) 2022-09-29 08:32 |
Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/9 [^] |
|
(0141582) hgbot (developer) 2022-10-03 16:16 |
Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/merge_requests/9 [^] |
|
(0141583) hgbot (developer) 2022-10-03 16:16 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition [^] Changeset: 1f1a10a622b8c1911209186099b6b9211c49b8cc Author: Asier Lostalé <asier.lostale@openbravo.com> Date: 03-10-2022 14:16:09 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.discounts.propertycondition/-/commit/1f1a10a622b8c1911209186099b6b9211c49b8cc [^] fixes BUG-50371: optional discounts don't take into account CRM properties Optional discounts are cached in a different object than automatic discounts, this object wasn't taken into account when crm properties were added. --- M web-jspack/org.openbravo.discounts.propertycondition/src/model/ticket/TicketExtension.js M web-jspack/org.openbravo.discounts.propertycondition/src/model/ticket/__test__/TicketExtension.test.js M web-jspack/org.openbravo.discounts.propertycondition/src/ob-init.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2022-09-29 08:16 | alostale | New Issue | |
| 2022-09-29 08:16 | alostale | Assigned To | => Retail |
| 2022-09-29 08:16 | alostale | Triggers an Emergency Pack | => No |
| 2022-09-29 08:17 | alostale | Relationship added | related to 0049884 |
| 2022-09-29 08:18 | alostale | Relationship added | related to 0049021 |
| 2022-09-29 08:19 | alostale | Steps to Reproduce Updated | View Revisions |
| 2022-09-29 08:30 | alostale | Summary | optional discounts do not take into account CRM property condiftions => optional discounts do not take into account CRM property conditions |
| 2022-09-29 08:32 | hgbot | Note Added: 0141478 | |
| 2022-09-29 08:34 | alostale | Assigned To | Retail => alostale |
| 2022-09-29 10:58 | alostale | Steps to Reproduce Updated | View Revisions |
| 2022-10-03 16:16 | hgbot | Note Added: 0141582 | |
| 2022-10-03 16:16 | hgbot | Resolution | open => fixed |
| 2022-10-03 16:16 | hgbot | Status | new => closed |
| 2022-10-03 16:16 | hgbot | Note Added: 0141583 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |