Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0050356
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Openbravo ERP] A. Platformminorhave not tried2022-09-27 17:232022-09-27 17:25
ReportercaristuView Statuspublic 
Assigned ToTriage Platform Base 
PriorityhighResolutionopenFixed in Version
StatusnewFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050356: Do not used generated JS code for defining sort normalizers

DescriptionCurrently we are using some generated code to define the sort normalizer function used by some references. See an example here[1].

Instead of using generating code for defining the function:

sortNormalizer: function (item, field, context){ return OB.Utilities.yesNoSortNormalizer(item, field, context);}

we should generate agnostic content

sortNormalizer: OB.Utilities.yesNoSortNormalizer

[1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/YesNoUIDefinition.java#L68 [^]
Steps To Reproduce.
Proposed SolutionThe main reason behind the current definition is that the normalizer functions are all defined in the ob-utilities file of the org.openbravo.client.application module, which is loaded after the code that defines the Smartclient types (because it is in a different component provider).

To avoid this we should move the definition of the normalizer functions from the ob-utilities file to a separate file that is imported with a component provider of a module that loads its content before the Smartclient types definition. One option could be to place them in the org.openbravo.client.kernel.module. Note this module already has a ob-kernel-utilities.js file.

The detected references with this problem so far are:
- YesNoUIDefinition
- ForeignKeyUIDefinition
- RelevantCharacteristicProperty
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
There are no notes attached to this issue.

- Issue History
Date Modified Username Field Change
2022-09-27 17:23 caristu New Issue
2022-09-27 17:23 caristu Assigned To => Triage Platform Base
2022-09-27 17:23 caristu Modules => Core
2022-09-27 17:23 caristu Triggers an Emergency Pack => No
2022-09-27 17:25 caristu Description Updated View Revisions


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker