Openbravo Issue Tracking System - Openbravo ERP | |||||
| View Issue Details | |||||
| ID | Project | Category | View Status | Date Submitted | Last Update |
| 0050356 | Openbravo ERP | A. Platform | public | 2022-09-27 17:23 | 2022-09-27 17:25 |
| Reporter | caristu | ||||
| Assigned To | Triage Platform Base | ||||
| Priority | high | Severity | minor | Reproducibility | have not tried |
| Status | new | Resolution | open | ||
| Platform | OS | 5 | OS Version | ||
| Product Version | |||||
| Target Version | Fixed in Version | ||||
| Merge Request Status | |||||
| Review Assigned To | |||||
| OBNetwork customer | |||||
| Web browser | |||||
| Modules | Core | ||||
| Support ticket | |||||
| Regression level | |||||
| Regression date | |||||
| Regression introduced in release | |||||
| Regression introduced by commit | |||||
| Triggers an Emergency Pack | No | ||||
| Summary | 0050356: Do not used generated JS code for defining sort normalizers | ||||
| Description | Currently we are using some generated code to define the sort normalizer function used by some references. See an example here[1]. Instead of using generating code for defining the function: sortNormalizer: function (item, field, context){ return OB.Utilities.yesNoSortNormalizer(item, field, context);} we should generate agnostic content sortNormalizer: OB.Utilities.yesNoSortNormalizer [1] https://gitlab.com/openbravo/product/openbravo/-/blob/master/modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/YesNoUIDefinition.java#L68 [^] | ||||
| Steps To Reproduce | . | ||||
| Proposed Solution | The main reason behind the current definition is that the normalizer functions are all defined in the ob-utilities file of the org.openbravo.client.application module, which is loaded after the code that defines the Smartclient types (because it is in a different component provider). To avoid this we should move the definition of the normalizer functions from the ob-utilities file to a separate file that is imported with a component provider of a module that loads its content before the Smartclient types definition. One option could be to place them in the org.openbravo.client.kernel.module. Note this module already has a ob-kernel-utilities.js file. The detected references with this problem so far are: - YesNoUIDefinition - ForeignKeyUIDefinition - RelevantCharacteristicProperty | ||||
| Additional Information | |||||
| Tags | No tags attached. | ||||
| Relationships | |||||
| Attached Files | |||||
| Issue History | |||||
| Date Modified | Username | Field | Change | ||
| 2022-09-27 17:23 | caristu | New Issue | |||
| 2022-09-27 17:23 | caristu | Assigned To | => Triage Platform Base | ||
| 2022-09-27 17:23 | caristu | Modules | => Core | ||
| 2022-09-27 17:23 | caristu | Triggers an Emergency Pack | => No | ||
| 2022-09-27 17:25 | caristu | Description Updated | bug_revision_view_page.php?rev_id=24788#r24788 | ||
| There are no notes attached to this issue. |