Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0050348

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

major

always

2022-09-26 18:27

2022-10-17 07:00

Reporter

axelmercado

View Status

public

Assigned To

ranjith_qualiantech_com

Priority

high

Resolution

fixed

Fixed in Version

RR23Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

pi

SCM revision

Merge Request Status

approved

Review Assigned To

OBNetwork customer

OBPS

Support ticket

49801

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0050348: Problem with new tpv payment methods with payment provider

Description

Create payment method without the definition of the preference but with payment provider. In this way we can create it on the fly without restarting the application server.

Steps To Reproduce

N/A

Proposed Solution

Patch provided by partner Practics

Tags

No tags attached.

keyboard-toolbars.diff [^] (1,447 bytes) 2022-09-26 18:27 [Show Content] [Hide Content]

--- a/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
+++ b/modules/org.openbravo.retail.posterminal/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
@@ -457,17 +457,20 @@
               if (providerGroups[payment.providerGroup.id]._button) {
                 btncomponent = null; // already added.
               } else {
+	            var permission = OB.MobileApp.model.hasPermission(
+                  payment.payment.searchKey
+                );
                 btncomponent = {
                   kind: 'OB.UI.BtnSide',
                   classes: 'obObposPointOfSaleUiToolbarPayment-obUiBtnSide',
                   btn: {
                     command: payment.providerGroup.id,
                     label: payment.providerGroup._identifier,
-                    permission: payment.payment.searchKey,
+                    permission: permission ? payment.payment.searchKey : null,
                     // Use the permissions of the FIRST payment in the provider group
                     definition: {
                       holdActive: true,
-                      permission: payment.payment.searchKey,
+                      permission: permission ? payment.payment.searchKey : null,
                       stateless: false,
                       action: function(keyboard, txt) {
                         me.payWithProviderGroup(

50348_posterminal.diff [^] (1,679 bytes) 2022-09-30 11:37 [Show Content] [Hide Content]

diff --git a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
index a463d2266f480641165a4c0acb222f4b0d9389ce..a7f05ff20e6a723fee3b2eb24a60dea210467d38 100644
--- a/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js
@@ -457,17 +457,22 @@ enyo.kind({
               if (providerGroups[payment.providerGroup.id]._button) {
                 btncomponent = null; // already added.
               } else {
+                const permission = OB.UTIL.isNullOrUndefined(
+                  OB.MobileApp.model.hasPermission(payment.payment.searchKey)
+                )
+                  ? null
+                  : payment.payment.searchKey;
                 btncomponent = {
                   kind: 'OB.UI.BtnSide',
                   classes: 'obObposPointOfSaleUiToolbarPayment-obUiBtnSide',
                   btn: {
                     command: payment.providerGroup.id,
                     label: payment.providerGroup._identifier,
-                    permission: payment.payment.searchKey,
+                    permission: permission,
                     // Use the permissions of the FIRST payment in the provider group
                     definition: {
                       holdActive: true,
-                      permission: payment.payment.searchKey,
+                      permission: permission,
                       stateless: false,
                       action: function(keyboard, txt) {
                         me.payWithProviderGroup(

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0141431) hgbot (developer) 2022-09-28 05:56	Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/935 [^]

(0142121) hgbot (developer) 2022-10-17 07:00	Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal [^] Changeset: 12be3b72def466dae24d2c46437c4f9dafb75228 Author: Ranjith S R <ranjith@qualiantech.com> Date: 17-10-2022 05:00:21 URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/commit/12be3b72def466dae24d2c46437c4f9dafb75228 [^] Fixed ISSUE-50348: Payment Button should be enabled if permission doesn't exists --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js ---

(0142122) hgbot (developer) 2022-10-17 07:00	Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.retail.posterminal/-/merge_requests/935 [^]

Issue History
Date Modified	Username	Field	Change
2022-09-26 18:27	axelmercado	New Issue
2022-09-26 18:27	axelmercado	Assigned To	=> Retail
2022-09-26 18:27	axelmercado	File Added: keyboard-toolbars.diff
2022-09-26 18:27	axelmercado	OBNetwork customer	=> OBPS
2022-09-26 18:27	axelmercado	Support ticket	=> 49801
2022-09-26 18:27	axelmercado	Triggers an Emergency Pack	=> No
2022-09-26 18:30	Practics	Issue Monitored: Practics
2022-09-27 12:55	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2022-09-27 12:56	ranjith_qualiantech_com	Status	new => scheduled
2022-09-28 05:56	hgbot	Merge Request Status	=> open
2022-09-28 05:56	hgbot	Note Added: 0141431
2022-09-30 11:37	ranjith_qualiantech_com	File Added: 50348_posterminal.diff
2022-10-17 07:00	hgbot	Merge Request Status	open => approved
2022-10-17 07:00	hgbot	Resolution	open => fixed
2022-10-17 07:00	hgbot	Status	scheduled => closed
2022-10-17 07:00	hgbot	Fixed in Version	=> RR23Q1
2022-10-17 07:00	hgbot	Note Added: 0142121
2022-10-17 07:00	hgbot	Note Added: 0142122

Copyright © 2000 - 2009 MantisBT Group