Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0050339

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[POS2] POS

major

N/A

2022-09-26 16:34

2022-09-27 12:22

Reporter

caristu

View Status

public

Assigned To

jorgewederago

Priority

immediate

Resolution

fixed

Fixed in Version

22Q4

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Oracle

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

2022-09-07

Regression introduced in release

Regression introduced by commit

https://gitlab.com/openbravo/product/openbravo/-/commit/89e0ab142d4900b5f62e41ac256caa728e78aa73 [^]

Triggers an Emergency Pack

No

Summary

0050339: UpdateExtBPConfig modulescript execution fails in Oracle

Description

UpdateExtBPConfig modulescript execution fails in Oracle with the following error:

     [java] Execution of moduleScript org.openbravo.modulescript.UpdateExtBPConfig failed.
     [java] at org.openbravo.modulescript.ModuleScriptHandler.execute(ModuleScriptHandler.java:69)
     [java] at org.openbravo.ddlutils.process.DBUpdater.executeModuleScripts(DBUpdater.java:176)
     [java] at org.openbravo.ddlutils.process.DBUpdater.update(DBUpdater.java:118)75157 [main] INFO org.openbravo.base.ExecutionLimitBaseProcess - Executing moduleScript: org.openbravo.modulescript.UpdateExtBPConfig
     [java]
     [java] 75162 [main] ERROR org.openbravo.base.ExecutionLimitBaseProcess - Error executing moduleScript org.openbravo.modulescript.UpdateExtBPConfig: ORA-00933: SQL command not properly ended
...

Steps To Reproduce

Using an environment with Oracle database:

1- Preparation steps:
1a- Apply the attached patch to force the execution of the UpdateExtBPConfig modulescript
1b- Compile the changes: ant compile.modulescript -Dmodule=org.openbravo

2- Run ant update.database. It fails

Tags

No tags attached.

removeLimits.diff [^] (716 bytes) 2022-09-26 16:34 [Show Content] [Hide Content]

diff --git a/src-util/modulescript/src/org/openbravo/modulescript/UpdateExtBPConfig.java b/src-util/modulescript/src/org/openbravo/modulescript/UpdateExtBPConfig.java
index 2322c056b0..afb0544e5e 100644
--- a/src-util/modulescript/src/org/openbravo/modulescript/UpdateExtBPConfig.java
+++ b/src-util/modulescript/src/org/openbravo/modulescript/UpdateExtBPConfig.java
@@ -44,11 +44,6 @@ public class UpdateExtBPConfig extends ModuleScript {
     }
   }
 
-  @Override
-  protected ModuleScriptExecutionLimits getModuleScriptExecutionLimits() {
-    return new ModuleScriptExecutionLimits("0", null, new OpenbravoVersion(3, 0, 223900));
-  }
-
   @Override
   protected boolean executeOnInstall() {
     return false;

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

feature request

closed

It is needed to create a structure to support 3 different forms for CRM Connector

Notes
(0141391) hgbot (developer) 2022-09-27 09:24	Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/717 [^]

(0141397) hgbot (developer) 2022-09-27 12:22	Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: dd87c2c6f646d42da27d898e5d026081500bf058 Author: Jorge Wederago <jorge.wederago@openbravo.com> Date: 27-09-2022 10:22:13 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/dd87c2c6f646d42da27d898e5d026081500bf058 [^] Fix ISSUE-50339: UpdateExtBPConfig modulescript execution fails in Oracle --- M src-util/modulescript/build/classes/org/openbravo/modulescript/UpdateExtBPConfig.class M src-util/modulescript/src/org/openbravo/modulescript/UpdateExtBPConfig.java ---

(0141398) hgbot (developer) 2022-09-27 12:22	Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/717 [^]

Issue History
Date Modified	Username	Field	Change
2022-09-26 16:34	caristu	New Issue
2022-09-26 16:34	caristu	Assigned To	=> Retail
2022-09-26 16:34	caristu	File Added: removeLimits.diff
2022-09-26 16:34	caristu	Regression date	=> 2022-09-07
2022-09-26 16:34	caristu	Regression introduced by commit	=> https://gitlab.com/openbravo/product/openbravo/-/commit/89e0ab142d4900b5f62e41ac256caa728e78aa73 [^]
2022-09-26 16:34	caristu	Triggers an Emergency Pack	=> No
2022-09-26 16:34	caristu	Issue generated from	0050057
2022-09-26 16:34	caristu	Relationship added	caused by 0050057
2022-09-26 16:38	caristu	Severity	minor => major
2022-09-26 17:04	jorgewederago	Assigned To	Retail => jorgewederago
2022-09-26 17:04	jorgewederago	Status	new => scheduled
2022-09-27 09:24	hgbot	Note Added: 0141391
2022-09-27 12:22	hgbot	Note Added: 0141397
2022-09-27 12:22	hgbot	Note Added: 0141398
2022-09-27 12:22	marvintm	Status	scheduled => resolved
2022-09-27 12:22	marvintm	Fixed in Version	=> 22Q4
2022-09-27 12:22	marvintm	Resolution	open => fixed
2022-09-27 12:22	marvintm	Review Assigned To	=> marvintm
2022-09-27 12:22	marvintm	Status	resolved => closed

Copyright © 2000 - 2009 MantisBT Group