Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0050221
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[POS2] POSmajorhave not tried2022-09-12 11:052022-09-12 11:47
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version22Q4
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0050221: Coupon Delivery Control Method does not work

DescriptionIn pos2 standard without custom overrides the coupon delivery control method results in a javascript error [1]


[1]
Uncaught (in promise) DOMException: Failed to execute 'put' on 'IDBObjectStore': #<Promise> could not be cloned.
    at https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:118123 [^]
    at Array.forEach (<anonymous>)
    at OB.App.Class.IndexedDBController.write (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:118106 [^])
    at OB.App.Class.IndexedDBController.put (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:117969 [^])
    at Object.put (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:174097 [^])
    at OB.App.Class.SynchronizationBuffer.onMessagesChanged (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:175822 [^])
    at https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:112480 [^]
    at Array.forEach (<anonymous>)
    at OB.App.Class.PersistenceChangeListenerManager.handleChange (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/8.efb9cf6e.chunk.js:1:112445 [^])
    at Object.m [as dispatch] (https://restaurant-demo.services.openbravo.com/openbravo/web/pos/static/js/12.3f0ae5b0.chunk.js:2:111818 [^])
Steps To ReproduceSet a delivery control method as coupon, or print a coupon when the pager does not work because the pager is not connected.

The error occurs because the system passes an unresolved promise in the message which is stored in to the messagebuffer. The messagebuffer tries to persist itself but promises can not be persisted.
Proposed SolutionRemove the word async here [1], it is not needed

[1]
https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/blob/master/web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/CouponDeliveryControlMethod.js#L35 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0141013)
hgbot (developer)
2022-09-12 11:46

 Merge Request created: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1194 [^]
(0141014)
hgbot (developer)
2022-09-12 11:47

 Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2 [^]
Changeset: 8a897e2563d5cdc41d4356aceb70e0a5d8bf4278
Author: Martin Taal <martin.taal@openbravo.com>
Date: 12-09-2022 11:45:48
URL: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/commit/8a897e2563d5cdc41d4356aceb70e0a5d8bf4278 [^]

Fixed ISSUE-50221: remove not needed async keyword to allow saving in the message buffer'

---
M web-jspack/org.openbravo.pos2/src/core/pickupPoint/deliveryControl/coupon/CouponDeliveryControlMethod.js
---
(0141015)
hgbot (developer)
2022-09-12 11:47

 Merge request merged: https://gitlab.com/openbravo/product/pmods/org.openbravo.pos2/-/merge_requests/1194 [^]

- Issue History
Date Modified Username Field Change
2022-09-12 11:05 mtaal New Issue
2022-09-12 11:05 mtaal Assigned To => mtaal
2022-09-12 11:05 mtaal Triggers an Emergency Pack => No
2022-09-12 11:46 hgbot Note Added: 0141013
2022-09-12 11:47 hgbot Resolution open => fixed
2022-09-12 11:47 hgbot Status new => closed
2022-09-12 11:47 hgbot Fixed in Version => 22Q4
2022-09-12 11:47 hgbot Note Added: 0141014
2022-09-12 11:47 hgbot Note Added: 0141015

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker